diff mbox series

[wwwdocs] +[invoke.texi] Update GCN for gfx90a (was: Re: [committed] amdgcn: Add gfx90a support)

Message ID 7a1081da-0ed1-f00c-6e24-680c992f8173@codesourcery.com
State New
Headers show
Series [wwwdocs] +[invoke.texi] Update GCN for gfx90a (was: Re: [committed] amdgcn: Add gfx90a support) | expand

Commit Message

Tobias Burnus May 24, 2022, 4:44 p.m. UTC
On 24.05.22 17:31, Andrew Stubbs wrote:
> amdgcn: Add gfx90a support

Attached is an attempt to update invoke.texi

And to update the gcc-13/changes.html. Regarding the latter, I have to
versions – the first is more readable, the latter makes more clear where
to use it, but reads much worse. – Pick one or suggest a better one.

OK for the two patches?

Tobias

PS: I was thinking of mentioning that GCN now requires llvm-mc of LLVM
13.0.1 or higher (during build + installed as assembler) but I then
thought that changes.html is not the best place and there is an error
during build, stating what is needed.
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

Comments

Tobias Burnus May 24, 2022, 5:08 p.m. UTC | #1
On 24.05.22 18:44, Tobias Burnus wrote:
> On 24.05.22 17:31, Andrew Stubbs wrote:
>> amdgcn: Add gfx90a support
>
> Attached is an attempt to update invoke.texi
> And to update the gcc-13/changes.html. Regarding the latter, I have to
> versions – the first is more readable, the latter makes more clear
> where to use it, but reads much worse. – Pick one or suggest a better
> one.

[wwwdocs, only]: Actually, regarding the gcc-13/changes, I am wondering
whether the best choice is to use the first wording but link to the
-march= page. That's what the new variant now does – see attachment.

(The linked-to page is:
https://gcc.gnu.org/onlinedocs/gcc/AMD-GCN-Options.html and
gfx906/gfx90a is added by the patch in the previous email in this thread.)

Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
Andrew Stubbs May 25, 2022, 9:18 a.m. UTC | #2
On 24/05/2022 17:44, Tobias Burnus wrote:
> On 24.05.22 17:31, Andrew Stubbs wrote:
>> amdgcn: Add gfx90a support
> 
> Attached is an attempt to update invoke.texi

I've deliberately avoided the MI100 and MI200 names because they're 
really not that simple. MI100 is gfx908, but MI150 is gfx906 and MI125 
is gfx900. I'm not sure what's going on with the MI200 series, now or in 
the future.

> And to update the gcc-13/changes.html. Regarding the latter, I have to 
> versions – the first is more readable, the latter makes more clear where 
> to use it, but reads much worse. – Pick one or suggest a better one.

I can only see one option?

> PS: I was thinking of mentioning that GCN now requires llvm-mc of LLVM 
> 13.0.1 or higher (during build + installed as assembler) but I then 
> thought that changes.html is not the best place and there is an error 
> during build, stating what is needed.

I'm going to update the Wiki page today. I'm not sure where else it is 
currently documented.

Andrew
Tobias Burnus May 25, 2022, 11:16 a.m. UTC | #3
On 25.05.22 11:18, Andrew Stubbs wrote:
> On 24/05/2022 17:44, Tobias Burnus wrote:
>> On 24.05.22 17:31, Andrew Stubbs wrote:
>>> amdgcn: Add gfx90a support
> I've deliberately avoided the MI100 and MI200 names because they're
> really not that simple. MI100 is gfx908, but MI150 is gfx906 and MI125
> is gfx900.

(The last two were misread – they should be MI50 and MI25.)

The MI100 and MI200 names show up in the documents:

* '"AMD Instinct MI100" Instruction Set Architecture / Reference Guide'
   https://developer.amd.com/wp-content/resources/CDNA1_Shader_ISA_14December2020.pdf
* '"AMD Instinct MI200" Instruction Set Architecture / Reference Guide'
   https://developer.amd.com/wp-content/resources/CDNA2_Shader_ISA_4February2022.pdf

>> And to update the gcc-13/changes.html.
> I can only see one option?

In one patch, I had two <li> to choose from, in the revised follow-up patch,
which was compile (nothing to choose from).

Updated diffs attached. — OK?

>> [...] GCN now requires llvm-mc of LLVM 13.0.1 or higher [..]
> I'm going to update the Wiki page today. I'm not sure where else it is
> currently documented.

I think that's the only place.

Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
Andrew Stubbs May 25, 2022, 11:41 a.m. UTC | #4
On 25/05/2022 12:16, Tobias Burnus wrote:
> On 25.05.22 11:18, Andrew Stubbs wrote:
>> On 24/05/2022 17:44, Tobias Burnus wrote:
>>> On 24.05.22 17:31, Andrew Stubbs wrote:
>>>> amdgcn: Add gfx90a support
>> I've deliberately avoided the MI100 and MI200 names because they're 
>> really not that simple. MI100 is gfx908, but MI150 is gfx906 and MI125 
>> is gfx900.
> 
> (The last two were misread – they should be MI50 and MI25.)
> 
> The MI100 and MI200 names show up in the documents:
> 
> * '"AMD Instinct MI100" Instruction Set Architecture / Reference Guide'
>    
> https://developer.amd.com/wp-content/resources/CDNA1_Shader_ISA_14December2020.pdf 
> 
> * '"AMD Instinct MI200" Instruction Set Architecture / Reference Guide'
>    
> https://developer.amd.com/wp-content/resources/CDNA2_Shader_ISA_4February2022.pdf 
> 
> 
>>> And to update the gcc-13/changes.html. 
>> I can only see one option?
> 
> In one patch, I had two <li> to choose from, in the revised follow-up 
> patch,
> which was compile (nothing to choose from).
> 
> Updated diffs attached. — OK?

OK, sorry for the confusion.

>>> [...] GCN now requires llvm-mc of LLVM 13.0.1 or higher [..]
>> I'm going to update the Wiki page today. I'm not sure where else it is 
>> currently documented.
> 
> I think that's the only place.

It's done now.

Andrew
diff mbox series

Patch

gcc-13/changes.html: Add gfx90a to GCN

diff --git a/htdocs/gcc-13/changes.html b/htdocs/gcc-13/changes.html
index 6c5b2a37..745aa65c 100644
--- a/htdocs/gcc-13/changes.html
+++ b/htdocs/gcc-13/changes.html
@@ -95,6 +95,14 @@  a work-in-progress.</p>
 
 <!-- <h3 id="aarch64">AArch64</h3> -->
 
+<h3 id="amdgcn">AMD Radeon (GCN)</h3>
+<ul>
+  <li>Support for the Instinct MI200 series (<code>gfx90a</code>) has been
+      added.</li>
+  <li>The <code>-march=</code> and <code>-mtune=</code> flags now support
+      <code>gfx90a</code> for the Instinct MI200 series (gfx90a).</li>
+</ul>
+
 <!-- <h3 id="arc">ARC</h3> -->
 
 <!-- <h3 id="arm">arm</h3> -->