diff mbox series

vhost-user: Use correct macro name TARGET_PPC64

Message ID 20220503180108.34506-1-muriloo@linux.ibm.com
State New
Headers show
Series vhost-user: Use correct macro name TARGET_PPC64 | expand

Commit Message

Murilo Opsfelder Araújo May 3, 2022, 6:01 p.m. UTC
The correct name of the macro is TARGET_PPC64.

Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
Cc: Peter Turschmid <peter.turschm@nutanix.com>
---
 hw/virtio/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Henrique Barboza May 3, 2022, 6:16 p.m. UTC | #1
On 5/3/22 15:01, Murilo Opsfelder Araujo wrote:
> The correct name of the macro is TARGET_PPC64.
> 
> Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
> Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
> Cc: Peter Turschmid <peter.turschm@nutanix.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


>   hw/virtio/vhost-user.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 9c4f84f35f..e356c72c81 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -51,7 +51,7 @@
>   #include "hw/acpi/acpi.h"
>   #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
>   
> -#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
> +#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
>   #include "hw/ppc/spapr.h"
>   #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
>
Daniel Henrique Barboza May 4, 2022, 8:42 p.m. UTC | #2
Michael,

I'll send a PR in the next few days. This change seems trivial enough to me
to push via the PPC64 tree.

Let me know if you're ok with that or if you want to pick it via the vhost tree.



Thanks,


Daniel


On 5/3/22 15:01, Murilo Opsfelder Araujo wrote:
> The correct name of the macro is TARGET_PPC64.
> 
> Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
> Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
> Cc: Peter Turschmid <peter.turschm@nutanix.com>
> ---
>   hw/virtio/vhost-user.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 9c4f84f35f..e356c72c81 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -51,7 +51,7 @@
>   #include "hw/acpi/acpi.h"
>   #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
>   
> -#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
> +#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
>   #include "hw/ppc/spapr.h"
>   #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
>
Michael S. Tsirkin May 4, 2022, 8:59 p.m. UTC | #3
On Tue, May 03, 2022 at 03:01:08PM -0300, Murilo Opsfelder Araujo wrote:
> The correct name of the macro is TARGET_PPC64.
> 
> Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
> Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
> Cc: Peter Turschmid <peter.turschm@nutanix.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

ok to merge through the ppc tree

> ---
>  hw/virtio/vhost-user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 9c4f84f35f..e356c72c81 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -51,7 +51,7 @@
>  #include "hw/acpi/acpi.h"
>  #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
>  
> -#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
> +#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
>  #include "hw/ppc/spapr.h"
>  #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
>  
> -- 
> 2.35.1
Daniel Henrique Barboza May 4, 2022, 9:45 p.m. UTC | #4
On 5/4/22 17:59, Michael S. Tsirkin wrote:
> On Tue, May 03, 2022 at 03:01:08PM -0300, Murilo Opsfelder Araujo wrote:
>> The correct name of the macro is TARGET_PPC64.
>>
>> Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
>> Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
>> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
>> Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
>> Cc: Peter Turschmid <peter.turschm@nutanix.com>
> 
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> 
> ok to merge through the ppc tree

Thanks for the r-b.  Queued in gitlab.com/danielhb/qemu/tree/ppc-next.



Daniel

> 
>> ---
>>   hw/virtio/vhost-user.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
>> index 9c4f84f35f..e356c72c81 100644
>> --- a/hw/virtio/vhost-user.c
>> +++ b/hw/virtio/vhost-user.c
>> @@ -51,7 +51,7 @@
>>   #include "hw/acpi/acpi.h"
>>   #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
>>   
>> -#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
>> +#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
>>   #include "hw/ppc/spapr.h"
>>   #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
>>   
>> -- 
>> 2.35.1
> 
>
Raphael Norwitz May 4, 2022, 11:44 p.m. UTC | #5
On Tue, May 03, 2022 at 03:01:08PM -0300, Murilo Opsfelder Araujo wrote:
> The correct name of the macro is TARGET_PPC64.
> 
> Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
> Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
> Cc: Peter Turschmid <peter.turschm@nutanix.com>

Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>

> ---
>  hw/virtio/vhost-user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 9c4f84f35f..e356c72c81 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -51,7 +51,7 @@
>  #include "hw/acpi/acpi.h"
>  #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
>  
> -#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
> +#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
>  #include "hw/ppc/spapr.h"
>  #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
>  
> -- 
> 2.35.1
>
diff mbox series

Patch

diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 9c4f84f35f..e356c72c81 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -51,7 +51,7 @@ 
 #include "hw/acpi/acpi.h"
 #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
 
-#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
+#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
 #include "hw/ppc/spapr.h"
 #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS