diff mbox series

[net-next,1/2] ice: link representors to PCI device

Message ID 20220328145828.10097-2-marcin.szycik@linux.intel.com
State Accepted
Delegated to: Anthony Nguyen
Headers show
Series ice: improve port representor naming scheme | expand

Commit Message

Marcin Szycik March 28, 2022, 2:58 p.m. UTC
From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

Link port representors to parent PCI device to benefit from
systemd defined naming scheme.

Example from ip tool:
 - without linking:
  eth0 ...
 - with linking:
  eth0 ...
  altname enp24s0f0npf0vf0

The port representor name is being shown in altname, because the name is
longer than IFNAMSIZ (16) limit. Altname can be used in ip tool.

Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
---
 drivers/net/ethernet/intel/ice/ice_repr.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Penigalapati, Sandeep May 4, 2022, 8:33 a.m. UTC | #1
>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Marcin Szycik
>Sent: Monday, March 28, 2022 8:28 PM
>To: intel-wired-lan@lists.osuosl.org
>Subject: [Intel-wired-lan] [PATCH net-next 1/2] ice: link representors to PCI
>device
>
>From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>
>Link port representors to parent PCI device to benefit from systemd defined
>naming scheme.
>
>Example from ip tool:
> - without linking:
>  eth0 ...
> - with linking:
>  eth0 ...
>  altname enp24s0f0npf0vf0
>
>The port representor name is being shown in altname, because the name is
>longer than IFNAMSIZ (16) limit. Altname can be used in ip tool.
>
>Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>---
> drivers/net/ethernet/intel/ice/ice_repr.c | 1 +
> 1 file changed, 1 insertion(+)
>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/ice/ice_repr.c b/drivers/net/ethernet/intel/ice/ice_repr.c
index 848f2adea563..78ee82511329 100644
--- a/drivers/net/ethernet/intel/ice/ice_repr.c
+++ b/drivers/net/ethernet/intel/ice/ice_repr.c
@@ -333,6 +333,7 @@  static int ice_repr_add(struct ice_vf *vf)
 	repr->netdev->min_mtu = ETH_MIN_MTU;
 	repr->netdev->max_mtu = ICE_MAX_MTU;
 
+	SET_NETDEV_DEV(repr->netdev, ice_pf_to_dev(vf->pf));
 	err = ice_repr_reg_netdev(repr->netdev);
 	if (err)
 		goto err_netdev;