| Message ID | 20220503105528.12824-3-kavyasree.kotagiri@microchip.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for lan966 flexcom multiplexer | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 03/05/2022 12:55, Kavyasree Kotagiri wrote: > Add lan966 flexcom compatible string and flexcom mux > device tree properties > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > --- > .../devicetree/bindings/mfd/atmel,flexcom.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > index 62dea9b891d8..3e056857c44a 100644 > --- a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > @@ -18,6 +18,7 @@ properties: > compatible: > enum: > - atmel,sama5d2-flexcom > + - microchip,lan966-flexcom > > reg: > minItems: 1 > @@ -45,6 +46,19 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [0, 1, 2] > > + # The following optional mux properties are only for lan966 flexcoms You need allOf:if:then restricting these per compatible. > + mux-controls: > + minItems: 1 maxItems instead > + description: Phandle to the mux controller to map flexcom chip-select > + to flexcom shared pin. > + > + mux-control-names: It looks like mux-consumer, right? You should instead include (in allOf) the mux-consumer.yaml. > + description: String to label the mux controller. > + minItems: 1 > + items: > + - const: cs0 > + - const: cs1 > + > required: > - compatible > - reg > @@ -64,5 +78,7 @@ examples: > #size-cells = <1>; > ranges = <0x0 0xf8034000 0x800>; > atmel,flexcom-mode = <2>; > + mux-controls = <&mux 0>; > + mux-control-names = "cs0"; > }; > ... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml index 62dea9b891d8..3e056857c44a 100644 --- a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml @@ -18,6 +18,7 @@ properties: compatible: enum: - atmel,sama5d2-flexcom + - microchip,lan966-flexcom reg: minItems: 1 @@ -45,6 +46,19 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 enum: [0, 1, 2] + # The following optional mux properties are only for lan966 flexcoms + mux-controls: + minItems: 1 + description: Phandle to the mux controller to map flexcom chip-select + to flexcom shared pin. + + mux-control-names: + description: String to label the mux controller. + minItems: 1 + items: + - const: cs0 + - const: cs1 + required: - compatible - reg @@ -64,5 +78,7 @@ examples: #size-cells = <1>; ranges = <0x0 0xf8034000 0x800>; atmel,flexcom-mode = <2>; + mux-controls = <&mux 0>; + mux-control-names = "cs0"; }; ...
Add lan966 flexcom compatible string and flexcom mux device tree properties Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> --- .../devicetree/bindings/mfd/atmel,flexcom.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)