| Message ID | orlevp91zp.fsf@lxoliva.fsfla.org |
|---|---|
| State | New |
| Headers | show |
| Series | testsuite: vect: update unaligned message | expand |
On Thu, 28 Apr 2022, Alexandre Oliva wrote: > > gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c covers ppc variants > that accept and reject misaligned accesses. The message that it > expects for rejection was removed in the gcc-11 development cycle by > commit r11-1969. The patch adjusted multiple tests to use the message > introduced in r11-1945, but missed this one. > > Regstrapped on powerpc64el-linux-gnu. Ok to install? > > Also tested on x86_64-linux-gnu-x-ppc64-vx7r2 with gcc-11. Ok for > gcc-11? OK. > > for gcc/testsuite/ChangeLog > > * gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c: Update > the expected message for the case in which unaligned accesses > are not allowed. > --- > .../gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c b/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c > index 72b4930d9bbbe..c57f065cccdd6 100644 > --- a/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c > +++ b/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c > @@ -46,5 +46,5 @@ int main (void) > return main1 (); > } > > -/* { dg-final { scan-tree-dump-times "not vectorized: unsupported unaligned store" 1 "vect" { target { ! vect_hw_misalign } } } } */ > +/* { dg-final { scan-tree-dump-times "unsupported unaligned access" 1 "vect" { target { ! vect_hw_misalign } } } } */ > /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 0 "vect" { target { ! vect_hw_misalign } } } } */ > >
On Apr 28, 2022, Richard Biener <rguenther@suse.de> wrote: > On Thu, 28 Apr 2022, Alexandre Oliva wrote: >> >> gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c covers ppc variants >> that accept and reject misaligned accesses. The message that it >> expects for rejection was removed in the gcc-11 development cycle by >> commit r11-1969. The patch adjusted multiple tests to use the message >> introduced in r11-1945, but missed this one. >> >> Regstrapped on powerpc64el-linux-gnu. Ok to install? >> >> Also tested on x86_64-linux-gnu-x-ppc64-vx7r2 with gcc-11. Ok for >> gcc-11? > OK. I checked it in the trunk so far, but I missed the gcc-12 branching. This is surely not critical for gcc-12, but it's so trivial that I wonder if I could install it in both gcc-12 and gcc-11 branches and forget about it, or wait until 12.1 is final. WDYT? >> for gcc/testsuite/ChangeLog >> >> * gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c: Update >> the expected message for the case in which unaligned accesses >> are not allowed. >> -/* { dg-final { scan-tree-dump-times "not vectorized: unsupported unaligned store" 1 "vect" { target { ! vect_hw_misalign } } } } */ >> +/* { dg-final { scan-tree-dump-times "unsupported unaligned access" 1 "vect" { target { ! vect_hw_misalign } } } } */
On Mon, 2 May 2022, Alexandre Oliva wrote: > On Apr 28, 2022, Richard Biener <rguenther@suse.de> wrote: > > > On Thu, 28 Apr 2022, Alexandre Oliva wrote: > >> > >> gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c covers ppc variants > >> that accept and reject misaligned accesses. The message that it > >> expects for rejection was removed in the gcc-11 development cycle by > >> commit r11-1969. The patch adjusted multiple tests to use the message > >> introduced in r11-1945, but missed this one. > >> > >> Regstrapped on powerpc64el-linux-gnu. Ok to install? > >> > >> Also tested on x86_64-linux-gnu-x-ppc64-vx7r2 with gcc-11. Ok for > >> gcc-11? > > > OK. > > I checked it in the trunk so far, but I missed the gcc-12 branching. > This is surely not critical for gcc-12, but it's so trivial that I > wonder if I could install it in both gcc-12 and gcc-11 branches and > forget about it, or wait until 12.1 is final. WDYT? It's OK for the 12 branch now. Richard. > >> for gcc/testsuite/ChangeLog > >> > >> * gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c: Update > >> the expected message for the case in which unaligned accesses > >> are not allowed. > > >> -/* { dg-final { scan-tree-dump-times "not vectorized: unsupported unaligned store" 1 "vect" { target { ! vect_hw_misalign } } } } */ > >> +/* { dg-final { scan-tree-dump-times "unsupported unaligned access" 1 "vect" { target { ! vect_hw_misalign } } } } */ > > >
diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c b/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c index 72b4930d9bbbe..c57f065cccdd6 100644 --- a/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c +++ b/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c @@ -46,5 +46,5 @@ int main (void) return main1 (); } -/* { dg-final { scan-tree-dump-times "not vectorized: unsupported unaligned store" 1 "vect" { target { ! vect_hw_misalign } } } } */ +/* { dg-final { scan-tree-dump-times "unsupported unaligned access" 1 "vect" { target { ! vect_hw_misalign } } } } */ /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 0 "vect" { target { ! vect_hw_misalign } } } } */