Message ID | 20220429115252.2360496-1-pgwipeout@gmail.com |
---|---|
Headers | show |
Series | Add support for several new rk3566 SBCs | expand |
On Fri, 29 Apr 2022 07:52:45 -0400, Peter Geis wrote: > The following series adds support for the following single board > computers: > - Pine64 Quartz64 Model B > - Pine64 SoQuartz SoM with RPi CM4IO carrier board > - Firefly Station M2 > > Patches 1, 2, and 3 add the requisite dt-bindings. > Patch 4 adds support for the SFC to the rk356x device tree. > Patch 5 adds the Quartz64 Model B device tree. > Patch 6 adds the SoQuartz CM4IO device tree. > Patch 7 adds the Firefly Station M2 device tree. > > [...] Applied, thanks! [4/7] arm64: dts: rockchip: add rk356x sfc support commit: 13e0ee34f39c01948a7bbaab0b3c225d9b00a5bb Best regards,
On 4/29/22 13:52, Peter Geis wrote: > Add a device tree for the Pine64 Quartz64 Model B single board computer. > This board ouputs debug on uart2 and supports the following components: > Gigabit Ethernet > USB2 x2 (one port otg capable) > USB3 > PCIe/SATA M2 > HDMI > DSI (RPi compatible pinout) > CSI (RPi compatible pinout) > A/B/G/N WiFi > Bluetooth > SDMMC > eMMC > SPI Flash > PI-40 compatible pin header > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3566-quartz64-b.dts | 615 ++++++++++++++++++ > 2 files changed, 616 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 4ae9f35434b8..252ee47b8a1d 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -59,5 +59,6 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.1.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.2.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-b.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > new file mode 100644 > index 000000000000..184ab7e1d178 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > @@ -0,0 +1,615 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * > + */ > + > +/dts-v1/; > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/pinctrl/rockchip.h> > +#include "rk3566.dtsi" > + > +/ { > + model = "Pine64 RK3566 Quartz64-B Board"; > + compatible = "pine64,quartz64-b", "rockchip,rk3566"; > + [..] > + > +&mdio1 { > + rgmii_phy1: ethernet-phy@0 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <0x1>; Hi, The reg value doesn't match the node name. Other 2 boards use "reg = <0>" with label "rgmii_phy1". Could you check? Johan > + }; > +}; > +
Am Sonntag, 1. Mai 2022, 09:06:33 CEST schrieb Johan Jonker: > > On 4/29/22 13:52, Peter Geis wrote: > > Add a device tree for the Pine64 Quartz64 Model B single board computer. > > This board ouputs debug on uart2 and supports the following components: > > Gigabit Ethernet > > USB2 x2 (one port otg capable) > > USB3 > > PCIe/SATA M2 > > HDMI > > DSI (RPi compatible pinout) > > CSI (RPi compatible pinout) > > A/B/G/N WiFi > > Bluetooth > > SDMMC > > eMMC > > SPI Flash > > PI-40 compatible pin header > > > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > > --- > > arch/arm64/boot/dts/rockchip/Makefile | 1 + > > .../boot/dts/rockchip/rk3566-quartz64-b.dts | 615 ++++++++++++++++++ > > 2 files changed, 616 insertions(+) > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > > > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > > index 4ae9f35434b8..252ee47b8a1d 100644 > > --- a/arch/arm64/boot/dts/rockchip/Makefile > > +++ b/arch/arm64/boot/dts/rockchip/Makefile > > @@ -59,5 +59,6 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.1.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.2.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a.dtb > > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-b.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > > new file mode 100644 > > index 000000000000..184ab7e1d178 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > > @@ -0,0 +1,615 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * > > + */ > > + > > +/dts-v1/; > > + > > +#include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/pinctrl/rockchip.h> > > +#include "rk3566.dtsi" > > + > > +/ { > > + model = "Pine64 RK3566 Quartz64-B Board"; > > + compatible = "pine64,quartz64-b", "rockchip,rk3566"; > > + > > [..] > > > + > > +&mdio1 { > > > + rgmii_phy1: ethernet-phy@0 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0x1>; > > Hi, > > The reg value doesn't match the node name. > Other 2 boards use "reg = <0>" with label "rgmii_phy1". > Could you check? I do have an older Quartz-B in my boardfarm and in that older devicetree the phy-reg also is "0" instead of the "1" used here. Is that a hardware-change? Thanks Heiko
On Sun, May 1, 2022 at 7:31 AM Heiko Stübner <heiko@sntech.de> wrote: > > Am Sonntag, 1. Mai 2022, 09:06:33 CEST schrieb Johan Jonker: > > > > On 4/29/22 13:52, Peter Geis wrote: > > > Add a device tree for the Pine64 Quartz64 Model B single board computer. > > > This board ouputs debug on uart2 and supports the following components: > > > Gigabit Ethernet > > > USB2 x2 (one port otg capable) > > > USB3 > > > PCIe/SATA M2 > > > HDMI > > > DSI (RPi compatible pinout) > > > CSI (RPi compatible pinout) > > > A/B/G/N WiFi > > > Bluetooth > > > SDMMC > > > eMMC > > > SPI Flash > > > PI-40 compatible pin header > > > > > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > > > --- > > > arch/arm64/boot/dts/rockchip/Makefile | 1 + > > > .../boot/dts/rockchip/rk3566-quartz64-b.dts | 615 ++++++++++++++++++ > > > 2 files changed, 616 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > > > index 4ae9f35434b8..252ee47b8a1d 100644 > > > --- a/arch/arm64/boot/dts/rockchip/Makefile > > > +++ b/arch/arm64/boot/dts/rockchip/Makefile > > > @@ -59,5 +59,6 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.1.dtb > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.2.dtb > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a.dtb > > > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-b.dtb > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > > > new file mode 100644 > > > index 000000000000..184ab7e1d178 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > > > @@ -0,0 +1,615 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * > > > + */ > > > + > > > +/dts-v1/; > > > + > > > +#include <dt-bindings/gpio/gpio.h> > > > +#include <dt-bindings/pinctrl/rockchip.h> > > > +#include "rk3566.dtsi" > > > + > > > +/ { > > > + model = "Pine64 RK3566 Quartz64-B Board"; > > > + compatible = "pine64,quartz64-b", "rockchip,rk3566"; > > > + > > > > [..] > > > > > + > > > +&mdio1 { > > > > > + rgmii_phy1: ethernet-phy@0 { > > > + compatible = "ethernet-phy-ieee802.3-c22"; > > > + reg = <0x1>; > > > > Hi, > > > > The reg value doesn't match the node name. > > Other 2 boards use "reg = <0>" with label "rgmii_phy1". > > Could you check? > > I do have an older Quartz-B in my boardfarm and in that older > devicetree the phy-reg also is "0" instead of the "1" used here. > > Is that a hardware-change? The ethernet maintainers previously brought up that 0x0 is the broadcast address for the mdio-bus. They requested we put the actual bus id of the phy even on single phy busses. This is the first one I've confirmed the bus address on. Though I realized ethernet-phy@0 should be ethernet-phy@1 since you mentioned this. Strange dtbs-check doesn't catch this, would you fix it in line Heiko or do you want another revision? > > Thanks > Heiko > >
Am Sonntag, 1. Mai 2022, 13:48:02 CEST schrieb Peter Geis: > On Sun, May 1, 2022 at 7:31 AM Heiko Stübner <heiko@sntech.de> wrote: > > > > Am Sonntag, 1. Mai 2022, 09:06:33 CEST schrieb Johan Jonker: > > > > > > On 4/29/22 13:52, Peter Geis wrote: > > > > Add a device tree for the Pine64 Quartz64 Model B single board computer. > > > > This board ouputs debug on uart2 and supports the following components: > > > > Gigabit Ethernet > > > > USB2 x2 (one port otg capable) > > > > USB3 > > > > PCIe/SATA M2 > > > > HDMI > > > > DSI (RPi compatible pinout) > > > > CSI (RPi compatible pinout) > > > > A/B/G/N WiFi > > > > Bluetooth > > > > SDMMC > > > > eMMC > > > > SPI Flash > > > > PI-40 compatible pin header > > > > > > > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > > > > --- > > > > arch/arm64/boot/dts/rockchip/Makefile | 1 + > > > > .../boot/dts/rockchip/rk3566-quartz64-b.dts | 615 ++++++++++++++++++ > > > > 2 files changed, 616 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > > > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > > > > index 4ae9f35434b8..252ee47b8a1d 100644 > > > > --- a/arch/arm64/boot/dts/rockchip/Makefile > > > > +++ b/arch/arm64/boot/dts/rockchip/Makefile > > > > @@ -59,5 +59,6 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.1.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.2.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a.dtb > > > > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-b.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > > > > new file mode 100644 > > > > index 000000000000..184ab7e1d178 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > > > > @@ -0,0 +1,615 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * > > > > + */ > > > > + > > > > +/dts-v1/; > > > > + > > > > +#include <dt-bindings/gpio/gpio.h> > > > > +#include <dt-bindings/pinctrl/rockchip.h> > > > > +#include "rk3566.dtsi" > > > > + > > > > +/ { > > > > + model = "Pine64 RK3566 Quartz64-B Board"; > > > > + compatible = "pine64,quartz64-b", "rockchip,rk3566"; > > > > + > > > > > > [..] > > > > > > > + > > > > +&mdio1 { > > > > > > > + rgmii_phy1: ethernet-phy@0 { > > > > + compatible = "ethernet-phy-ieee802.3-c22"; > > > > + reg = <0x1>; > > > > > > Hi, > > > > > > The reg value doesn't match the node name. > > > Other 2 boards use "reg = <0>" with label "rgmii_phy1". > > > Could you check? > > > > I do have an older Quartz-B in my boardfarm and in that older > > devicetree the phy-reg also is "0" instead of the "1" used here. > > > > Is that a hardware-change? > > The ethernet maintainers previously brought up that 0x0 is the > broadcast address for the mdio-bus. They requested we put the actual > bus id of the phy even on single phy busses. This is the first one > I've confirmed the bus address on. > > Though I realized ethernet-phy@0 should be ethernet-phy@1 since you > mentioned this. Strange dtbs-check doesn't catch this, would you fix > it in line Heiko no that's ok, I can fix that up. Just wanted to clarify what the intention was first :-) > or do you want another revision? > > > > > Thanks > > Heiko > > > > >
On Fri, 29 Apr 2022 07:52:45 -0400, Peter Geis wrote: > The following series adds support for the following single board > computers: > - Pine64 Quartz64 Model B > - Pine64 SoQuartz SoM with RPi CM4IO carrier board > - Firefly Station M2 > > Patches 1, 2, and 3 add the requisite dt-bindings. > Patch 4 adds support for the SFC to the rk356x device tree. > Patch 5 adds the Quartz64 Model B device tree. > Patch 6 adds the SoQuartz CM4IO device tree. > Patch 7 adds the Firefly Station M2 device tree. > > [...] Applied, thanks! [1/7] dt-bindings: arm: rockchip: Add Pine64 Quartz64 Model B commit: c37415f55bdadffe5b4c0e7981e9fc7e8b96beea [2/7] dt-bindings: arm: rockchip: Add Pine64 SoQuartz SoM commit: c466828fb3ba8cb7f5c3bf28766da9b70bf9745e [3/7] dt-bindings: arm: rockchip: Add Firefly Station M2 commit: e52ded5543708e0382f236ce35372a63f4568341 [5/7] arm64: dts: rockchip: add Pine64 Quartz64-B device tree commit: dcc8c66bef79befa6c9ebe7d7d62b0ce66983c20 [6/7] arm64: dts: rockchip: add SoQuartz CM4IO dts commit: 5859b5a9c3ac92d831bed164374cb837519524ad [7/7] arm64: dts: rockchip: add dts for Firefly Station M2 rk3566 commit: 30ac9b4e25d8cece00d32c7419f9d919f55421fe I've adjusted the styling of comments a bit, also dropped one double newline as well as fixed the node name for the ethernet-phy for QuartzB. Best regards,