diff mbox

Massive breakage with your libgcc patches

Message ID ydd4nyl2esq.fsf@manam.CeBiTec.Uni-Bielefeld.DE
State New
Headers show

Commit Message

Rainer Orth Nov. 3, 2011, 7:20 p.m. UTC 
Bernd Schmidt <bernds@codesourcery.com> writes:

> I've tried again on x86_64, still no such failure. Are you quite sure
> the binutils directory is up-to-date? (Try a clean checkout with CVS).

It was up-to-date, but somehow mangled (haven't yet investigated
how/why).  Anyway, with a fresh anon-CVS checkout of the 2.22 branch, I
can now build libgcc up to the failure point.

> You can drop most of the gcc configure options if the tools are in your
> path.

I wasn't completely certain about it and wanted to avoid a possible
source of problems.

I've now managed to reproduce the problem.  In a checkout of the gcc
tree before my patches, unwind-dw2.o isn't built.  I could trace this to
LIB2ADD_EH not being overridden any longer, so the default was used.  I
had missed the addition of libgcc/config/c6x/t-c6x-elf since I've
normalized the names of the target fragments to consistently use
$cpu/t-elf, not $cpu/t-$cpu-elf.

Simply merging the contents of c6x/t-c6x-elf into c6x/t-elf allowed the
libgcc build to complete for me.

Here's the patch I've come up with.  Should I commit it now or would you
like to do a full testsuite run first?

Sorry again for the trouble.

	Rainer


2011-11-03  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* config/c6x/t-elf (LIB2ADDEH): Set.
	* config/c6x/t-c6x-elf: Remove.

Comments

Bernd Schmidt Nov. 4, 2011, 11:29 a.m. UTC | #1 
On 11/03/11 20:20, Rainer Orth wrote:
> Here's the patch I've come up with.  Should I commit it now or would you
> like to do a full testsuite run first?

Please commit, thanks.


Bernd
Bernd Schmidt Nov. 7, 2011, 1:12 p.m. UTC | #2 
On 11/03/11 20:20, Rainer Orth wrote:
> 
> 	* config/c6x/t-elf (LIB2ADDEH): Set.
> 	* config/c6x/t-c6x-elf: Remove.

It builds now, but parts of libgcc are missing. There's no sign of
muldf3, for examples.


Bernd
diff mbox

Patch

# HG changeset patch
# Parent 42f16488e80434634dcd1100a993e7f81c37ada8
Restore c6x-elf bootstrap

diff --git a/libgcc/config/c6x/t-c6x-elf b/libgcc/config/c6x/t-c6x-elf
deleted file mode 100644
--- a/libgcc/config/c6x/t-c6x-elf
+++ /dev/null
@@ -1,4 +0,0 @@ 
-LIB2ADDEH = $(srcdir)/config/c6x/unwind-c6x.c \
-  $(srcdir)/config/c6x/libunwind.S \
-  $(srcdir)/config/c6x/pr-support.c $(srcdir)/unwind-c.c
-
diff --git a/libgcc/config/c6x/t-elf b/libgcc/config/c6x/t-elf
--- a/libgcc/config/c6x/t-elf
+++ b/libgcc/config/c6x/t-elf
@@ -22,6 +22,10 @@  LIB2ADD = $(srcdir)/config/c6x/gef.c \
 # Avoid failures when the user's GOT becomes too large.
 HOST_LIBGCC2_CFLAGS = -msdata=none
 
+LIB2ADDEH = $(srcdir)/config/c6x/unwind-c6x.c \
+  $(srcdir)/config/c6x/libunwind.S \
+  $(srcdir)/config/c6x/pr-support.c $(srcdir)/unwind-c.c
+
 # Assemble startup files.
 crti.o: $(srcdir)/config/c6x/crti.S
 	$(crt_compile) -c $(CRTSTUFF_T_CFLAGS) $<