Message ID | 20220422060152.13534-1-rex-bc.chen@mediatek.com |
---|---|
Headers | show |
Series | Cleanup MediaTek clk reset drivers and support MT8192/MT8195 | expand |
Il 22/04/22 08:01, Rex-BC Chen ha scritto: > Add a new file "reset.h" to place some definitions for clock reset. > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 22/04/22 08:01, Rex-BC Chen ha scritto: > To make drivers more readable, we modify the indentation of the drivers > and reorder the location of functions. > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 22/04/22 08:01, Rex-BC Chen ha scritto: > To make drivers more clear and readable, we extract common code > within assert and deassert to mtk_reset_update_set_clr() and > mtk_reset_update(). > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 22/04/22 08:01, Rex-BC Chen ha scritto: > To declare the reset data easier instead of using many input variables > to mtk_register_reset_controller(). > > - Add mtk_clk_rst_desc to input the reset register data. > - Rename "mtk_reset" to "mtk_clk_rst_data". We use it to store reset > register data and store reset controller device. It's more easy to > manager the data for each reset controller. > - Extract container_of in update functions to to_mtk_clk_rst_data(). > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 22/04/22 08:01, Rex-BC Chen ha scritto: > To make error handling, we add return for mtk_clk_register_rst_ctrl(). > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 22/04/22 08:01, Rex-BC Chen ha scritto: > There are two versions for clock reset register control of MediaTek > SoCs. The old hardware is one bit per reset control, and does not > have separate registers for bit set, clear and read-back operations. > This matches the scheme supported by the simple reset driver. > > However, because we need to use our data structure "struct mtk_reset", > we can not use the operation of simple reset driver. We keep the > original functions and name this version as "MTK_RST_SIMPLE". > > In this patch: > - Add a version enum to separate different MediaTek reset hardware. > - Merge the reset register function of simple and set_clr into one > function "mtk_register_reset_controller". > - Rename input variable "num_regs" to "rst_set_nr" to avoid > confusion. This variable is used to define the number of reset set. > - Rename "regofs" to "reg_ofs". > - Adjust delaration type for mtk_register_reset_controller(). > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 22/04/22 08:01, Rex-BC Chen ha scritto: > It's a proper implementation using device to register reset controller. > Howerver, some clock drviers of MediaTeks only provide device_node. > Therefore, we still remain register reset function with device_node and > add a function with device to register reset controller. > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>