| Message ID | 20220417210436.6203-1-singh.kuldeep87k@gmail.com |
|---|---|
| Headers | show |
| Series | Convert Qcom BAM dma binding to json format | expand |
Hi Kuldeep, On Mon, 18 Apr 2022 at 02:34, Kuldeep Singh <singh.kuldeep87k@gmail.com> wrote: > > Qcom BAM DT spec expects generic DMA controller node name as > "dma-controller" to enable validations. This is already fixed with in-flight patch <https://lore.kernel.org/lkml/20220211214941.f55q5yksittut3ep@amazon.com/T/#mb84230b9b8e06544859ccf5e16a7651fac79c933> Thanks, Bhupesh > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > v3: Add Krzysztof R-b tag > --- > v2: No change > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index b9a48cfd760f..c4cfab92a44e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -707,7 +707,7 @@ tsens1: thermal-sensor@4ad000 { > #thermal-sensor-cells = <1>; > }; > > - cryptobam: dma@644000 { > + cryptobam: dma-controller@644000 { > compatible = "qcom,bam-v1.7.0"; > reg = <0x00644000 0x24000>; > interrupts = <GIC_SPI 206 IRQ_TYPE_LEVEL_HIGH>; > -- > 2.25.1 >
On Mon, Apr 18, 2022 at 11:02:11AM +0530, Bhupesh Sharma wrote: > This is already fixed with in-flight patch > <https://lore.kernel.org/lkml/20220211214941.f55q5yksittut3ep@amazon.com/T/#mb84230b9b8e06544859ccf5e16a7651fac79c933> Your change is currently not accepted/merged and don't think it's in maintainer's queue as well. So, probably it's not in-flight patch as of now.
On Tue, Apr 19, 2022 at 02:37:19AM +0530, Bhupesh Sharma wrote: > My patch already has an ACK from the DMA maintainer, whereas your's is > still in review. Sincere apologies, I saw your original patch only and missed Ack. Please note, mine change is reviewed by FDT maintainer. > So please drop this patch from the next version. If we are going to have mine binding version, then skipping dts change here will trigger Rob's bot warning.
Patch 1,2,3,4,5 require generic node name for dma and 6/6 is actual conversion change. Looking forward towards review comments. Thanks! --- v3: - Add Krzysztof's R-b tags for dts changes - Add qcom,ee as required property(Krzysztof) - Use type as boolean - Add min/max to qcom,ee - Clocks are required ones, skip them as it's users are not fixed. --- v2: - Add more variants of ip4019-ap/dk-{01/04/07} for dma node rename - Add #dma-cells in binding file - use additionalproperties as false --- Kuldeep Singh (6): ARM: dts: qcom: apq8064: User generic node name for DMA ARM: dts: qcom: mdm9615: User generic node name for DMA arm64: dts: qcom: msm8996: User generic node name for DMA ARM: dts: qcom: ipq4019: User generic node name for DMA ARM: dts: qcom: ipq8064: User generic node name for DMA dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format .../devicetree/bindings/dma/qcom,bam-dma.yaml | 97 +++++++++++++++++++ .../devicetree/bindings/dma/qcom_bam_dma.txt | 52 ---------- arch/arm/boot/dts/qcom-apq8064.dtsi | 6 +- arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 4 +- .../boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts | 2 +- arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 2 +- arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi | 4 +- arch/arm/boot/dts/qcom-ipq4019.dtsi | 6 +- arch/arm/boot/dts/qcom-ipq8064.dtsi | 4 +- arch/arm/boot/dts/qcom-mdm9615.dtsi | 4 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- 11 files changed, 114 insertions(+), 69 deletions(-) create mode 100644 Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml delete mode 100644 Documentation/devicetree/bindings/dma/qcom_bam_dma.txt