Message ID | 20220408151237.3165046-1-pgwipeout@gmail.com |
---|---|
Headers | show |
Series | enable usb support on rk356x | expand |
Hi seems like usb (2+3) is broken in 5.18-rc1 i see controllers, ports are powered, but no device detection. maybe anyone else have same behaviour with different board? regards Frank
On Fri, Apr 8, 2022 at 12:14 PM Frank Wunderlich <frank-w@public-files.de> wrote: > > Hi Good Evening, > > seems like usb (2+3) is broken in 5.18-rc1 > > i see controllers, ports are powered, but no device detection. > > maybe anyone else have same behaviour with different board? Yes, it seems you are correct, there has been a regression with xhci between v5.17 and v5.18. I'm bisecting now. > > regards Frank Thanks for reporting it! Very Respectfully, Peter Geis
Tested on mediatek board (mt7623/bpi-r2) and there xhci is working. So it is no problem in core/protocol and specific to rockchip xhci driver. at least i nailed it down to these 2 commits in drivers/usb/dwc3/core.c, without them it works 5114c3ee2487 2022-01-27 usb: dwc3: Calculate REFCLKPER based on reference clock 33fb697ec7e5 2022-01-27 usb: dwc3: Get clocks individually regards Frank > Gesendet: Samstag, 09. April 2022 um 01:39 Uhr > Von: "Peter Geis" <pgwipeout@gmail.com> > On Fri, Apr 8, 2022 at 12:14 PM Frank Wunderlich > <frank-w@public-files.de> wrote: > > seems like usb (2+3) is broken in 5.18-rc1 > > > > i see controllers, ports are powered, but no device detection. > > > > maybe anyone else have same behaviour with different board? > > Yes, it seems you are correct, there has been a regression with xhci > between v5.17 and v5.18. > I'm bisecting now.
Got it, these Patches require different clock names ref_clk => ref bus_clk => bus_early after renaming usb works on my board will send an follow-up patch for this series regards Frank > Gesendet: Samstag, 09. April 2022 um 09:23 Uhr > Von: "Frank Wunderlich" <frank-w@public-files.de> > > at least i nailed it down to these 2 commits in drivers/usb/dwc3/core.c, without them it works > > 5114c3ee2487 2022-01-27 usb: dwc3: Calculate REFCLKPER based on reference clock > 33fb697ec7e5 2022-01-27 usb: dwc3: Get clocks individually
On Sat, Apr 9, 2022 at 3:37 AM Frank Wunderlich <frank-w@public-files.de> wrote: > > Got it, > these Patches require different clock names > > ref_clk => ref > bus_clk => bus_early > > after renaming usb works on my board > > will send an follow-up patch for this series > > regards Frank > > > > Gesendet: Samstag, 09. April 2022 um 09:23 Uhr > > Von: "Frank Wunderlich" <frank-w@public-files.de> > > > > at least i nailed it down to these 2 commits in drivers/usb/dwc3/core.c, without them it works > > > > 5114c3ee2487 2022-01-27 usb: dwc3: Calculate REFCLKPER based on reference clock > > 33fb697ec7e5 2022-01-27 usb: dwc3: Get clocks individually > I've submitted a fix for the dwc3 issue. https://patchwork.kernel.org/project/linux-rockchip/patch/20220409152116.3834354-1-pgwipeout@gmail.com/ The offending commit was: 33fb697ec7e5 ("usb: dwc3: Get clocks individually"). It breaks backwards compatibility with rk3328, which follows the rockchip,dwc3.yaml dt-binding, and thus this series as well. This fix is standalone and necessary no matter which route we decide to go with this series (and the rk3328/rk3399 support as well). With this patch, dwc3 is functional on the rk356x as the series was submitted, so if we decide to fix everything all at once, that is a viable option. For those not following the other conversation, here is the TLDR: - rockchip,dwc3.yaml has different clock names than snps,dwc3.yaml - rk3328 and rk356x attach directly to the dwc3 core driver - rk3399 uses the dwc3-simple driver, which still uses the clk_bulk api. - commit 33fb697ec7e5 changed to individual clocks, which follow snps,dwc3.yaml naming - to correct this beyond my fix patch, we would need to align rockchip,dwc3.yaml with snps,dwc3.yaml, which means rk3328, rk3399, and rk356x will move to the snps clock naming scheme. I think we need Rob Herring to weigh in here, as this is a rather uncomfortable dt-binding issue.
On Fri, 8 Apr 2022 11:12:32 -0400, Peter Geis wrote: > Good Morning, > > This is my patch series that I have maintained out of tree until the > combophy driver landed. > > This has been rebased on v5.18-rc1, several patches in the previous > series already landed and have been dropped. > > [...] Applied, thanks! [1/5] dt-bindings: soc: grf: add rk3566-pipe-grf compatible commit: 2a872dd86eeb349f169df0a204668afa578a94b2 [2/5] soc: rockchip: set dwc3 clock for rk3566 commit: 5c0bb71138770d85ea840acd379edc6471b867ee [3/5] arm64: dts: rockchip: add rk356x dwc3 usb3 nodes commit: 9f4c480f24e2ce1d464ff9d5f8a249a485acdc7f [4/5] arm64: dts: rockchip: enable dwc3 on quartz64-a commit: e432309ff8bf2a148bbdd4946ca1580c6b5b610c [5/5] arm64: dts: rockchip: add usb3 support to rk3568-evb1-v10 commit: d6cfb110b0fdfb4e61ef4e3c3ab89a8f21b4d1b8 Best regards,