| Message ID | 20220331151440.3643482-2-michael@walle.cc |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [RFC,net-next,1/3] dt-bindings: net: convert mscc-miim to YAML format | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 31/03/2022 17:14, Michael Walle wrote: > Add the (optional) clock input of the MDIO controller and indicate that > the common clock-frequency property is supported. The driver can use it > to set the desired MDIO bus frequency. > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > Documentation/devicetree/bindings/net/mscc,miim.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/mscc,miim.yaml b/Documentation/devicetree/bindings/net/mscc,miim.yaml > index b52bf1732755..e9e8ddcdade9 100644 > --- a/Documentation/devicetree/bindings/net/mscc,miim.yaml > +++ b/Documentation/devicetree/bindings/net/mscc,miim.yaml > @@ -32,6 +32,11 @@ properties: > > interrupts: true > > + clocks: > + maxItems: 1 > + > + clock-frequency: true This looks unusual clock-frequency is usually for clock providers but this is a consumer, so it is not a common frequency here. You mention that "driver can use it", so it's not a hardware description but some feature for the driver. We have this already - use assigned-clock* in your DTS. Best regards, Krzysztof
On Thu, Mar 31, 2022 at 10:05:48PM +0200, Krzysztof Kozlowski wrote: > On 31/03/2022 17:14, Michael Walle wrote: > > Add the (optional) clock input of the MDIO controller and indicate that > > the common clock-frequency property is supported. The driver can use it > > to set the desired MDIO bus frequency. > > > > Signed-off-by: Michael Walle <michael@walle.cc> > > --- > > Documentation/devicetree/bindings/net/mscc,miim.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/mscc,miim.yaml b/Documentation/devicetree/bindings/net/mscc,miim.yaml > > index b52bf1732755..e9e8ddcdade9 100644 > > --- a/Documentation/devicetree/bindings/net/mscc,miim.yaml > > +++ b/Documentation/devicetree/bindings/net/mscc,miim.yaml > > @@ -32,6 +32,11 @@ properties: > > > > interrupts: true > > > > + clocks: > > + maxItems: 1 > > + > > + clock-frequency: true > > This looks unusual clock-frequency is usually for clock providers but > this is a consumer, so it is not a common frequency here. You mention > that "driver can use it", so it's not a hardware description but some > feature for the driver. We have this already - use assigned-clock* in > your DTS. Please see Documentation/devicetree/bindings/net/mdio.yaml clock-frequency: description: Desired MDIO bus clock frequency in Hz. Values greater than IEEE 802.3 defined 2.5MHz should only be used when all devices on the bus support the given clock speed. The MDIO bus master provides the MDIO bus clock, so in a sense, the device is a provider. although it does also make use of the clock itself. It is a hardware description, because the users of the bus make use of the clock, i.e. the PHY devices on the bus. It is also identical to i2c bus masters Documentation/devicetree/bindings/i2c/i2c.txt says: - clock-frequency frequency of bus clock in Hz. Andrew
On 31/03/2022 22:16, Andrew Lunn wrote: > On Thu, Mar 31, 2022 at 10:05:48PM +0200, Krzysztof Kozlowski wrote: >> On 31/03/2022 17:14, Michael Walle wrote: >>> Add the (optional) clock input of the MDIO controller and indicate that >>> the common clock-frequency property is supported. The driver can use it >>> to set the desired MDIO bus frequency. >>> >>> Signed-off-by: Michael Walle <michael@walle.cc> >>> --- >>> Documentation/devicetree/bindings/net/mscc,miim.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/mscc,miim.yaml b/Documentation/devicetree/bindings/net/mscc,miim.yaml >>> index b52bf1732755..e9e8ddcdade9 100644 >>> --- a/Documentation/devicetree/bindings/net/mscc,miim.yaml >>> +++ b/Documentation/devicetree/bindings/net/mscc,miim.yaml >>> @@ -32,6 +32,11 @@ properties: >>> >>> interrupts: true >>> >>> + clocks: >>> + maxItems: 1 >>> + >>> + clock-frequency: true >> >> This looks unusual clock-frequency is usually for clock providers but >> this is a consumer, so it is not a common frequency here. You mention >> that "driver can use it", so it's not a hardware description but some >> feature for the driver. We have this already - use assigned-clock* in >> your DTS. > > Please see > > Documentation/devicetree/bindings/net/mdio.yaml > > clock-frequency: > description: > Desired MDIO bus clock frequency in Hz. Values greater than IEEE 802.3 > defined 2.5MHz should only be used when all devices on the bus support > the given clock speed. > > The MDIO bus master provides the MDIO bus clock, so in a sense, the > device is a provider. although it does also make use of the clock > itself. It is a hardware description, because the users of the bus > make use of the clock, i.e. the PHY devices on the bus. > > It is also identical to i2c bus masters > Documentation/devicetree/bindings/i2c/i2c.txt says: > Thanks, it's good. Indeed buses also use this property. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/mscc,miim.yaml b/Documentation/devicetree/bindings/net/mscc,miim.yaml index b52bf1732755..e9e8ddcdade9 100644 --- a/Documentation/devicetree/bindings/net/mscc,miim.yaml +++ b/Documentation/devicetree/bindings/net/mscc,miim.yaml @@ -32,6 +32,11 @@ properties: interrupts: true + clocks: + maxItems: 1 + + clock-frequency: true + required: - compatible - reg
Add the (optional) clock input of the MDIO controller and indicate that the common clock-frequency property is supported. The driver can use it to set the desired MDIO bus frequency. Signed-off-by: Michael Walle <michael@walle.cc> --- Documentation/devicetree/bindings/net/mscc,miim.yaml | 5 +++++ 1 file changed, 5 insertions(+)