| Message ID | 20220304000311.970267-2-joel@jms.id.au |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: Convert GFX bindings to yaml | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, Mar 4, 2022 at 1:03 AM Joel Stanley <joel@jms.id.au> wrote: > The example needs updating to match the to be added yaml bindings for > the gfx node. > > Signed-off-by: Joel Stanley <joel@jms.id.au> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> I guess you will merge this elsewhere or shall I apply it to the pinctrl tree? Yours, Linus Walleij
On Tue, 15 Mar 2022 at 01:21, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Fri, Mar 4, 2022 at 1:03 AM Joel Stanley <joel@jms.id.au> wrote: > > > The example needs updating to match the to be added yaml bindings for > > the gfx node. > > > > Signed-off-by: Joel Stanley <joel@jms.id.au> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > I guess you will merge this elsewhere or shall I apply it to the pinctrl tree? Feel free to take this one. > > Yours, > Linus Walleij
On Fri, Mar 4, 2022 at 1:03 AM Joel Stanley <joel@jms.id.au> wrote: > The example needs updating to match the to be added yaml bindings for > the gfx node. > > Signed-off-by: Joel Stanley <joel@jms.id.au> Patch applied. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml index d316cc082107..9969997c2f1b 100644 --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml @@ -73,6 +73,7 @@ additionalProperties: false examples: - | + #include <dt-bindings/clock/aspeed-clock.h> apb { compatible = "simple-bus"; #address-cells = <1>; @@ -82,6 +83,8 @@ examples: syscon: scu@1e6e2000 { compatible = "aspeed,ast2500-scu", "syscon", "simple-mfd"; reg = <0x1e6e2000 0x1a8>; + #clock-cells = <1>; + #reset-cells = <1>; pinctrl: pinctrl { compatible = "aspeed,ast2500-pinctrl"; @@ -102,6 +105,12 @@ examples: gfx: display@1e6e6000 { compatible = "aspeed,ast2500-gfx", "syscon"; reg = <0x1e6e6000 0x1000>; + reg-io-width = <4>; + clocks = <&syscon ASPEED_CLK_GATE_D1CLK>; + resets = <&syscon ASPEED_RESET_CRT1>; + interrupts = <0x19>; + syscon = <&syscon>; + memory-region = <&gfx_memory>; }; }; @@ -128,3 +137,10 @@ examples: }; }; }; + + gfx_memory: framebuffer { + size = <0x01000000>; + alignment = <0x01000000>; + compatible = "shared-dma-pool"; + reusable; + };
The example needs updating to match the to be added yaml bindings for the gfx node. Signed-off-by: Joel Stanley <joel@jms.id.au> --- .../bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)