mbox series

[v2,0/8] pinctrl: ocelot: convert to YAML format

Message ID 20220318202547.1650687-1-michael@walle.cc
Headers show
Series pinctrl: ocelot: convert to YAML format | expand

Message

Michael Walle March 18, 2022, 8:25 p.m. UTC 
Convert the pinctrl ocelot binding to the new YAML format. Pin
configuration nodes should have a "-pins" postfix. But unfortunately,
there are many device trees which don't follow this. First rename
all these nodes and then convert the binding to the YAML format so
that the validation will pass.

Because there were no maintainers before and there is none in
MAINTAINERS I added Alexandre Belloni and Lars Povlsen, juding by
the commits - to the binding as maintainers. Please tell me if you
disagree.

changes since v1:
 - drop "Device Tree Binding" from the title of the binding
 - describe reg properties and provide minItems and set it differently
   depending on the compatible string
 - skip interrupt description
 - move required section after patternProperties

Michael Walle (8):
  MIPS: mscc: jaguar2: fix pinctrl nodes
  MIPS: mscc: ocelot: fix MIIM1 pinctrl node name
  MIPS: mscc: ocelot: fix PHY interrupt pinctrl node name
  MIPS: mscc: ocelot: fix load/save GPIO pinctrl name
  MIPS: mscc: serval: fix pinctrl node names
  arm64: dts: sparx5: fix pinctrl node names
  ARM: dts: lan9662-pcb8291: fix pinctrl node name
  dt-bindings: pinctrl: convert ocelot-pinctrl to YAML format

 .../bindings/pinctrl/mscc,ocelot-pinctrl.txt  |  42 -------
 .../bindings/pinctrl/mscc,ocelot-pinctrl.yaml | 108 ++++++++++++++++++
 arch/arm/boot/dts/lan966x-pcb8291.dts         |   2 +-
 .../dts/microchip/sparx5_pcb134_board.dtsi    |  26 ++---
 .../dts/microchip/sparx5_pcb135_board.dtsi    |  10 +-
 arch/mips/boot/dts/mscc/jaguar2_pcb110.dts    |  10 +-
 arch/mips/boot/dts/mscc/jaguar2_pcb111.dts    |  10 +-
 arch/mips/boot/dts/mscc/jaguar2_pcb118.dts    |   6 +-
 arch/mips/boot/dts/mscc/ocelot.dtsi           |   4 +-
 arch/mips/boot/dts/mscc/ocelot_pcb120.dts     |   6 +-
 arch/mips/boot/dts/mscc/serval_common.dtsi    |  14 +--
 11 files changed, 152 insertions(+), 86 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.txt
 create mode 100644 Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml

Comments

Sergei Shtylyov March 19, 2022, 8:24 a.m. UTC | #1 
Hello!

On 3/18/22 11:25 PM, Michael Walle wrote:

> The pinctrl device tree binding will be converted to YAML format. All
> the pin nodes should end with "-pins". Fix them.

   It does end with "pins" already, right?

> Fixes: 290deaa10c50 ("ARM: dts: add DT for lan966 SoC and 2-port board pcb8291")
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  arch/arm/boot/dts/lan966x-pcb8291.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 3281af90ac6d..3c7e3a7d6f14 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -35,7 +35,7 @@ fc3_b_pins: fcb3-spi-pins {
>  		function = "fc3_b";
>  	};
>  
> -	can0_b_pins:  can0_b_pins {
> +	can0_b_pins:  can0-b-pins {

   Mhm, I can't even see what is changed here... :-/

[...]

MBR, Sergey
Michael Walle March 19, 2022, 11:38 a.m. UTC | #2 
Hi,

Am 2022-03-19 09:24, schrieb Sergei Shtylyov:
> Hello!
> 
> On 3/18/22 11:25 PM, Michael Walle wrote:
> 
>> The pinctrl device tree binding will be converted to YAML format. All
>> the pin nodes should end with "-pins". Fix them.
> 
>    It does end with "pins" already, right?

It ends with "_pins". Please note the underscore.

>> Fixes: 290deaa10c50 ("ARM: dts: add DT for lan966 SoC and 2-port board 
>> pcb8291")
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>>  arch/arm/boot/dts/lan966x-pcb8291.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts 
>> b/arch/arm/boot/dts/lan966x-pcb8291.dts
>> index 3281af90ac6d..3c7e3a7d6f14 100644
>> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
>> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
>> @@ -35,7 +35,7 @@ fc3_b_pins: fcb3-spi-pins {
>>  		function = "fc3_b";
>>  	};
>> 
>> -	can0_b_pins:  can0_b_pins {
>> +	can0_b_pins:  can0-b-pins {
> 
>    Mhm, I can't even see what is changed here... :-/

The name of the node, s/_/-/

-michael
Krzysztof Kozlowski March 19, 2022, 2:32 p.m. UTC | #3 
On 18/03/2022 21:25, Michael Walle wrote:
> The pinctrl device tree binding will be converted to YAML format. All
> the pin nodes should end with "-pins". Fix them.
> 
> Fixes: 15324652f612 ("MIPS: dts: ocelot: describe the load/save GPIO")

There is no bug here, so no need for fix.

> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  arch/mips/boot/dts/mscc/ocelot_pcb120.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/mscc/ocelot_pcb120.dts b/arch/mips/boot/dts/mscc/ocelot_pcb120.dts
> index cda6c5ff58ad..d348742c233d 100644
> --- a/arch/mips/boot/dts/mscc/ocelot_pcb120.dts
> +++ b/arch/mips/boot/dts/mscc/ocelot_pcb120.dts
> @@ -27,7 +27,7 @@ phy_int_pins: phy-int-pins {
>  		function = "gpio";
>  	};
>  
> -	phy_load_save_pins: phy_load_save_pins {
> +	phy_load_save_pins: phy-load-save-pins {
>  		pins = "GPIO_10";

This should be squashed with previous patch or with the next one. There
is no point to align names with dtschema/dt spec one by one. Make the
conversion per entire board file or SoC.


Best regards,
Krzysztof
Krzysztof Kozlowski March 19, 2022, 2:34 p.m. UTC | #4 
On 18/03/2022 21:25, Michael Walle wrote:
> The pinctrl device tree binding will be converted to YAML format. All
> the pin nodes should end with "-pins". Fix them.
> 
> Fixes: ("arm64: dts: sparx5: Add i2c devices, i2c muxes")

Here and in all commits, there is no bug to be fixed. Please remove
"Fixes" and remove "fix" word from commit msg and commit subject,
because you trick stable-AUTOSEL to pick up this patch to stables. This
must not go to stables as you can break out of tree usages.

There is no bug and there is no fix.

Best regards,
Krzysztof
Sergei Shtylyov March 20, 2022, 8:20 a.m. UTC | #5 
On 3/19/22 2:38 PM, Michael Walle wrote:

[...]
>>> The pinctrl device tree binding will be converted to YAML format. All
>>> the pin nodes should end with "-pins". Fix them.
>>
>>    It does end with "pins" already, right?
> 
> It ends with "_pins". Please note the underscore.

   Ah!

>>> Fixes: 290deaa10c50 ("ARM: dts: add DT for lan966 SoC and 2-port board pcb8291")
>>> Signed-off-by: Michael Walle <michael@walle.cc>
>>> ---
>>>  arch/arm/boot/dts/lan966x-pcb8291.dts | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
>>> index 3281af90ac6d..3c7e3a7d6f14 100644
>>> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
>>> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
>>> @@ -35,7 +35,7 @@ fc3_b_pins: fcb3-spi-pins {
>>>          function = "fc3_b";
>>>      };
>>>
>>> -    can0_b_pins:  can0_b_pins {
>>> +    can0_b_pins:  can0-b-pins {
>>
>>    Mhm, I can't even see what is changed here... :-/
> 
> The name of the node, s/_/-/

   Indeed! I must have been blind then, sorry. :-)

> -michael

MBR, Sergey