diff mbox series

[net-next,1/5] dt-bindings: net: lan966x: Extend with FDMA interrupt

Message ID 20220317185159.1661469-2-horatiu.vultur@microchip.com
State Changes Requested, archived
Headers show
Series net: lan966x: Add support for FDMA | expand

Checks

Context Check Description
robh/patch-applied fail

Commit Message

Horatiu Vultur March 17, 2022, 6:51 p.m. UTC
Extend dt-bindings for lan966x with FDMA interrupt. This is generated
when receiving a frame or when a frame was transmitted. The interrupt
needs to be enable for each frame.

Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
 .../devicetree/bindings/net/microchip,lan966x-switch.yaml       | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michael Walle March 18, 2022, 2:14 a.m. UTC | #1
> Extend dt-bindings for lan966x with FDMA interrupt. This is generated
> when receiving a frame or when a frame was transmitted. The interrupt
> needs to be enable for each frame.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  .../devicetree/bindings/net/microchip,lan966x-switch.yaml       | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> index 13812768b923..14e0bae5965f 100644
> --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> @@ -39,6 +39,7 @@ properties:
>        - description: frame dma based extraction
>        - description: analyzer interrupt
>        - description: ptp interrupt
> +      - description: fdma interrupt
>  
>    interrupt-names:
>      minItems: 1
> @@ -47,6 +48,7 @@ properties:
>        - const: fdma
>        - const: ana
>        - const: ptp
> +      - const: fdma

This interrupt is already described (three lines above), no?

-michael
Horatiu Vultur March 18, 2022, 7:54 a.m. UTC | #2
The 03/18/2022 03:14, Michael Walle wrote:
> 
> > Extend dt-bindings for lan966x with FDMA interrupt. This is generated
> > when receiving a frame or when a frame was transmitted. The interrupt
> > needs to be enable for each frame.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> >  .../devicetree/bindings/net/microchip,lan966x-switch.yaml       | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > index 13812768b923..14e0bae5965f 100644
> > --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > @@ -39,6 +39,7 @@ properties:
> >        - description: frame dma based extraction
> >        - description: analyzer interrupt
> >        - description: ptp interrupt
> > +      - description: fdma interrupt
> >
> >    interrupt-names:
> >      minItems: 1
> > @@ -47,6 +48,7 @@ properties:
> >        - const: fdma
> >        - const: ana
> >        - const: ptp
> > +      - const: fdma
> 
> This interrupt is already described (three lines above), no?

Yes you are right.
So I will drop this patch in the next version.

> 
> -michael
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
index 13812768b923..14e0bae5965f 100644
--- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
+++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
@@ -39,6 +39,7 @@  properties:
       - description: frame dma based extraction
       - description: analyzer interrupt
       - description: ptp interrupt
+      - description: fdma interrupt
 
   interrupt-names:
     minItems: 1
@@ -47,6 +48,7 @@  properties:
       - const: fdma
       - const: ana
       - const: ptp
+      - const: fdma
 
   resets:
     items: