| Message ID | 20220316095433.20225-2-singh.kuldeep87k@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Fix dtbs warnings for arch timer | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 16/03/2022 10:54, Kuldeep Singh wrote: > Compatibles entries of arch timer includes few extra items and enum > pairs which are redundant and can be simplified in a more clear, concise > and readable way. Do it. > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > --- > .../devicetree/bindings/timer/arm,arch_timer.yaml | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On Wed, Mar 16, 2022 at 05:29:07PM +0100, Krzysztof Kozlowski wrote: > On 16/03/2022 10:54, Kuldeep Singh wrote: > > Compatibles entries of arch timer includes few extra items and enum > > pairs which are redundant and can be simplified in a more clear, concise > > and readable way. Do it. > > > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > > --- > > .../devicetree/bindings/timer/arm,arch_timer.yaml | 12 ++++-------- > > 1 file changed, 4 insertions(+), 8 deletions(-) > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Thanks for your time in reviewing this. - Kuldeep
diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml index df8ce87fd54b..ba2910f0a7b2 100644 --- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml @@ -21,17 +21,13 @@ description: |+ properties: compatible: oneOf: + - enum: + - arm,armv7-timer + - arm,armv8-timer - items: - enum: - arm,cortex-a15-timer - - enum: - - arm,armv7-timer - - items: - - enum: - - arm,armv7-timer - - items: - - enum: - - arm,armv8-timer + - const: arm,armv7-timer interrupts: minItems: 1
Compatibles entries of arch timer includes few extra items and enum pairs which are redundant and can be simplified in a more clear, concise and readable way. Do it. Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> --- .../devicetree/bindings/timer/arm,arch_timer.yaml | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)