| Message ID | 20220316095433.20225-3-singh.kuldeep87k@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Fix dtbs warnings for arch timer | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 16/03/2022 10:54, Kuldeep Singh wrote: > Renesas RZ/N1D platform uses compatible "arm,cortex-a7-timer" in > conjugation with "arm,armv7-timer". Since, initial entry is not > documented, it start raising dtbs_check warnings. > > ['arm,cortex-a7-timer', 'arm,armv7-timer'] is too long > 'arm,cortex-a7-timer' is not one of ['arm,armv7-timer', 'arm,armv8-timer'] > 'arm,cortex-a7-timer' is not one of ['arm,cortex-a15-timer'] > > In general, removing an existing entry is mostly devastating considering > backward compatibility. Therefore, document it. How removing undocumented and unused compatible is devastating for backwards compatibility? I don't see it. DTS is rather wrong, not bindings. Otherwise please explain it more, why DTS is correct. Best regards, Krzysztof
On Wed, Mar 16, 2022 at 05:28:49PM +0100, Krzysztof Kozlowski wrote: > On 16/03/2022 10:54, Kuldeep Singh wrote: > > Renesas RZ/N1D platform uses compatible "arm,cortex-a7-timer" in > > conjugation with "arm,armv7-timer". Since, initial entry is not > > documented, it start raising dtbs_check warnings. > > > > ['arm,cortex-a7-timer', 'arm,armv7-timer'] is too long > > 'arm,cortex-a7-timer' is not one of ['arm,armv7-timer', 'arm,armv8-timer'] > > 'arm,cortex-a7-timer' is not one of ['arm,cortex-a15-timer'] > > > > In general, removing an existing entry is mostly devastating considering > > backward compatibility. Therefore, document it. > > How removing undocumented and unused compatible is devastating for > backwards compatibility? I don't see it. > > DTS is rather wrong, not bindings. Otherwise please explain it more, why > DTS is correct. Please see my comment on 3/3 patch. - Kuldeep
diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml index ba2910f0a7b2..ea390e5df71d 100644 --- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml @@ -26,6 +26,7 @@ properties: - arm,armv8-timer - items: - enum: + - arm,cortex-a7-timer - arm,cortex-a15-timer - const: arm,armv7-timer
Renesas RZ/N1D platform uses compatible "arm,cortex-a7-timer" in conjugation with "arm,armv7-timer". Since, initial entry is not documented, it start raising dtbs_check warnings. ['arm,cortex-a7-timer', 'arm,armv7-timer'] is too long 'arm,cortex-a7-timer' is not one of ['arm,armv7-timer', 'arm,armv8-timer'] 'arm,cortex-a7-timer' is not one of ['arm,cortex-a15-timer'] In general, removing an existing entry is mostly devastating considering backward compatibility. Therefore, document it. Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> --- Documentation/devicetree/bindings/timer/arm,arch_timer.yaml | 1 + 1 file changed, 1 insertion(+)