Message ID | 1319875606-7794-1-git-send-email-lindner_marek@yahoo.de |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Marek Lindner <lindner_marek@yahoo.de> Date: Sat, 29 Oct 2011 10:06:43 +0200 > git://git.open-mesh.org/linux-merge.git batman-adv/maint Pulled, but long term you should shore up your datastructures to handle that issue in patch #3. Make a common header: struct tt_entry_common { u8 addr[ETH_ALEN]; struct hlist_node hash_entry; }; Then use that at the beginning of both structures: struct tt_local_entry { struct tt_entry_common common; unsigned long last_seen; ... }; struct tt_global_entry { struct tt_entry_comomn common; struct orig_node *orig_node; ... }; And &p->common is what gets passed into tt_response_fill_table(). -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sunday 30 October 2011 03:07:45 David Miller wrote: [...] > Make a common header: > > struct tt_entry_common { > u8 addr[ETH_ALEN]; > struct hlist_node hash_entry; > }; > > Then use that at the beginning of both structures: > > struct tt_local_entry { > struct tt_entry_common common; > unsigned long last_seen; > ... > }; > > struct tt_global_entry { > struct tt_entry_comomn common; > struct orig_node *orig_node; > ... > }; > > And &p->common is what gets passed into tt_response_fill_table(). Thanks for the pull. This is exactly the long term solution we want to submit later to net-next. But we also wanted to keep the patch as small as possible for stable@kernel.org Thanks, Sven