| Message ID | 20220224081121.10389-2-jamin_lin@aspeedtech.com |
|---|---|
| State | New |
| Headers | show |
| Series | fix compiling warnings for AST2600 A1 SPL | expand |
On Thu, 24 Feb 2022 at 08:11, Jamin Lin <jamin_lin@aspeedtech.com> wrote: > > remove duplicated define > > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> > --- > include/configs/evb_ast2600a1_spl.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/include/configs/evb_ast2600a1_spl.h b/include/configs/evb_ast2600a1_spl.h > index 655896b237..006cc4345b 100644 > --- a/include/configs/evb_ast2600a1_spl.h > +++ b/include/configs/evb_ast2600a1_spl.h > @@ -42,13 +42,6 @@ > #endif > #endif > > -/* SPL */ > -#define CONFIG_SPL_TEXT_BASE 0x00000000 > -#define CONFIG_SPL_MAX_SIZE 0x0000E800 > -#define CONFIG_SPL_STACK 0x10010000 > -#define CONFIG_SPL_BSS_START_ADDR 0x90000000 > -#define CONFIG_SPL_BSS_MAX_SIZE 0x00100000 A good cleanup. While we're here, can we clean up the various ast2600 config headers? There is a large diff between the a0 and the a1 spl header. I know the A0 has a smaller SRAM. Are there any other differences required? > - > #define CONFIG_SUPPORT_EMMC_BOOT > > #endif /* __CONFIG_H */ > -- > 2.17.1 >
The 02/24/2022 11:43, Joel Stanley wrote: > On Thu, 24 Feb 2022 at 08:11, Jamin Lin <jamin_lin@aspeedtech.com> wrote: > > > > remove duplicated define > > > > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> > > --- > > include/configs/evb_ast2600a1_spl.h | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/include/configs/evb_ast2600a1_spl.h b/include/configs/evb_ast2600a1_spl.h > > index 655896b237..006cc4345b 100644 > > --- a/include/configs/evb_ast2600a1_spl.h > > +++ b/include/configs/evb_ast2600a1_spl.h > > @@ -42,13 +42,6 @@ > > #endif > > #endif > > > > -/* SPL */ > > -#define CONFIG_SPL_TEXT_BASE 0x00000000 > > -#define CONFIG_SPL_MAX_SIZE 0x0000E800 > > -#define CONFIG_SPL_STACK 0x10010000 > > -#define CONFIG_SPL_BSS_START_ADDR 0x90000000 > > -#define CONFIG_SPL_BSS_MAX_SIZE 0x00100000 > > A good cleanup. While we're here, can we clean up the various ast2600 > config headers? > We do not have a plan to merge them. > There is a large diff between the a0 and the a1 spl header. I know the > A0 has a smaller SRAM. Are there any other differences required? > A0 did not support "boot from emmc", "secure boot image size", please refer to our Errata for detail. > > - > > #define CONFIG_SUPPORT_EMMC_BOOT > > > > #endif /* __CONFIG_H */ > > -- > > 2.17.1 > >
02/24/2022 11:43, Joel Stanley wrote: > On Thu, 24 Feb 2022 at 08:11, Jamin Lin <jamin_lin@aspeedtech.com> wrote: > > > > remove duplicated define > > > > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> > > --- > > include/configs/evb_ast2600a1_spl.h | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/include/configs/evb_ast2600a1_spl.h b/include/configs/evb_ast2600a1_spl.h > > index 655896b237..006cc4345b 100644 > > --- a/include/configs/evb_ast2600a1_spl.h > > +++ b/include/configs/evb_ast2600a1_spl.h > > @@ -42,13 +42,6 @@ > > #endif > > #endif > > > > -/* SPL */ > > -#define CONFIG_SPL_TEXT_BASE 0x00000000 > > -#define CONFIG_SPL_MAX_SIZE 0x0000E800 > > -#define CONFIG_SPL_STACK 0x10010000 > > -#define CONFIG_SPL_BSS_START_ADDR 0x90000000 > > -#define CONFIG_SPL_BSS_MAX_SIZE 0x00100000 > > A good cleanup. While we're here, can we clean up the various ast2600 > config headers? > We do not have a plan to merge them. > There is a large diff between the a0 and the a1 spl header. I know the > A0 has a smaller SRAM. Are there any other differences required? > A0 did not support "boot from emmc", "secure boot image size", please refer to our Errata for detail. > > - > > #define CONFIG_SUPPORT_EMMC_BOOT > > > > #endif /* __CONFIG_H */ > > -- > > 2.17.1 > >
diff --git a/include/configs/evb_ast2600a1_spl.h b/include/configs/evb_ast2600a1_spl.h index 655896b237..006cc4345b 100644 --- a/include/configs/evb_ast2600a1_spl.h +++ b/include/configs/evb_ast2600a1_spl.h @@ -42,13 +42,6 @@ #endif #endif -/* SPL */ -#define CONFIG_SPL_TEXT_BASE 0x00000000 -#define CONFIG_SPL_MAX_SIZE 0x0000E800 -#define CONFIG_SPL_STACK 0x10010000 -#define CONFIG_SPL_BSS_START_ADDR 0x90000000 -#define CONFIG_SPL_BSS_MAX_SIZE 0x00100000 - #define CONFIG_SUPPORT_EMMC_BOOT #endif /* __CONFIG_H */
remove duplicated define Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> --- include/configs/evb_ast2600a1_spl.h | 7 ------- 1 file changed, 7 deletions(-)