| Message ID | 20220221132606.39480-1-fb@ltec.ch |
|---|---|
| State | Accepted |
| Commit | 551f426011e31fad37fe66108ffdf05eb48e3176 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | arm: pdu001: Setup pinmux for console UART as early as possible | expand |
On Mon, Feb 21, 2022 at 02:26:05PM +0100, Felix Brack wrote: > To make sure we get a working console as soon as possible in the SPL the > UART pins require to be configured earlier. This is especially > true for the pins of UART3, since the PDU001 board uses this UART for > the console by default. > > Signed-off-by: Felix Brack <fb@ltec.ch> > --- > > board/eets/pdu001/board.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) Does this replace https://patchwork.ozlabs.org/project/uboot/patch/20220215142723.45242-1-fb@ltec.ch/ or go in addition to it? Thanks!
Hi Tom, On 21.02.22 14:34, Tom Rini wrote: > On Mon, Feb 21, 2022 at 02:26:05PM +0100, Felix Brack wrote: > >> To make sure we get a working console as soon as possible in the SPL the >> UART pins require to be configured earlier. This is especially >> true for the pins of UART3, since the PDU001 board uses this UART for >> the console by default. >> >> Signed-off-by: Felix Brack <fb@ltec.ch> >> --- >> >> board/eets/pdu001/board.c | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) > > Does this replace > https://patchwork.ozlabs.org/project/uboot/patch/20220215142723.45242-1-fb@ltec.ch/ > or go in addition to it? Thanks! > No it's not a replacement. It is kind of addition but not related to the early debugging UART, hence a second patch.
On Mon, Feb 21, 2022 at 02:50:19PM +0100, Felix Brack wrote: > Hi Tom, > > On 21.02.22 14:34, Tom Rini wrote: > > On Mon, Feb 21, 2022 at 02:26:05PM +0100, Felix Brack wrote: > > > >> To make sure we get a working console as soon as possible in the SPL the > >> UART pins require to be configured earlier. This is especially > >> true for the pins of UART3, since the PDU001 board uses this UART for > >> the console by default. > >> > >> Signed-off-by: Felix Brack <fb@ltec.ch> > >> --- > >> > >> board/eets/pdu001/board.c | 30 ++++++++++++++++++++++++++++++ > >> 1 file changed, 30 insertions(+) > > > > Does this replace > > https://patchwork.ozlabs.org/project/uboot/patch/20220215142723.45242-1-fb@ltec.ch/ > > or go in addition to it? Thanks! > > > No it's not a replacement. It is kind of addition but not related to the > early debugging UART, hence a second patch. OK, thanks just confirming.
On Mon, Feb 21, 2022 at 02:26:05PM +0100, Felix Brack wrote: > To make sure we get a working console as soon as possible in the SPL the > UART pins require to be configured earlier. This is especially > true for the pins of UART3, since the PDU001 board uses this UART for > the console by default. > > Signed-off-by: Felix Brack <fb@ltec.ch> Applied to u-boot/master, thanks!
diff --git a/board/eets/pdu001/board.c b/board/eets/pdu001/board.c index 9f3cfd4f84..4aeb84071b 100644 --- a/board/eets/pdu001/board.c +++ b/board/eets/pdu001/board.c @@ -216,6 +216,36 @@ const struct dpll_params *get_dpll_ddr_params(void) return &dpll_ddr; } +void set_uart_mux_conf(void) +{ + switch (CONFIG_CONS_INDEX) { + case 1: { + enable_uart0_pin_mux(); + break; + } + case 2: { + enable_uart1_pin_mux(); + break; + } + case 3: { + enable_uart2_pin_mux(); + break; + } + case 4: { + enable_uart3_pin_mux(); + break; + } + case 5: { + enable_uart4_pin_mux(); + break; + } + case 6: { + enable_uart5_pin_mux(); + break; + } + } +} + void set_mux_conf_regs(void) { /* done first by the ROM and afterwards by the pin controller driver */
To make sure we get a working console as soon as possible in the SPL the UART pins require to be configured earlier. This is especially true for the pins of UART3, since the PDU001 board uses this UART for the console by default. Signed-off-by: Felix Brack <fb@ltec.ch> --- board/eets/pdu001/board.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)