| Message ID | 20220217155549.1084829-3-marcus.hoffmann@othermo.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | defconfig fixes | expand |
On 17/02/22 16:55, Marcus Hoffmann wrote: > Fixes the following error during image generation: > ERROR: hdimage(sdcard.img): part boot: 'partition-type' is only valid > for mbr and hybrid partition-table-type > > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/2103784375 > > Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Best regards
Marcus, All, On 2022-02-17 16:55 +0100, Marcus Hoffmann spake thusly: > Fixes the following error during image generation: > ERROR: hdimage(sdcard.img): part boot: 'partition-type' is only valid > for mbr and hybrid partition-table-type > > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/2103784375 > > Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de> > --- > board/orangepi/orangepi-rk3399/genimage.cfg | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/board/orangepi/orangepi-rk3399/genimage.cfg b/board/orangepi/orangepi-rk3399/genimage.cfg > index c94e0bc7cc..a02166172f 100644 > --- a/board/orangepi/orangepi-rk3399/genimage.cfg > +++ b/board/orangepi/orangepi-rk3399/genimage.cfg > @@ -26,14 +26,13 @@ image sdcard.img { > } > > partition boot { > - partition-type = 0xC > + partition-type-uuid = F > bootable = "true" > image = "boot.vfat" > offset = 16M > } > > partition rootfs { > - partition-type = 0x83 Why don't you also switch this one to partition-type-uuid? Regards, Yann E. MORIN. > image = "rootfs.ext4" > } > } > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Yann, On 17.02.22 22:44, Yann E. MORIN wrote: > Marcus, All, > > On 2022-02-17 16:55 +0100, Marcus Hoffmann spake thusly: >> Fixes the following error during image generation: >> ERROR: hdimage(sdcard.img): part boot: 'partition-type' is only valid >> for mbr and hybrid partition-table-type >> >> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/2103784375 >> >> Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de> >> --- >> board/orangepi/orangepi-rk3399/genimage.cfg | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/board/orangepi/orangepi-rk3399/genimage.cfg b/board/orangepi/orangepi-rk3399/genimage.cfg >> index c94e0bc7cc..a02166172f 100644 >> --- a/board/orangepi/orangepi-rk3399/genimage.cfg >> +++ b/board/orangepi/orangepi-rk3399/genimage.cfg >> @@ -26,14 +26,13 @@ image sdcard.img { >> } >> >> partition boot { >> - partition-type = 0xC >> + partition-type-uuid = F >> bootable = "true" >> image = "boot.vfat" >> offset = 16M >> } >> >> partition rootfs { >> - partition-type = 0x83 > > Why don't you also switch this one to partition-type-uuid? The replacement for this would be "partition-type-uuid = L", which is the default. I believe I saw a patch recently that removed those default entries, which is why I didn't include it. Best, Marcus > > Regards, > Yann E. MORIN. > >> image = "rootfs.ext4" >> } >> } >> -- >> 2.25.1 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot >
Hi Yann, On 17/02/22 22:44, Yann E. MORIN wrote: > Marcus, All, > > On 2022-02-17 16:55 +0100, Marcus Hoffmann spake thusly: >> Fixes the following error during image generation: >> ERROR: hdimage(sdcard.img): part boot: 'partition-type' is only valid >> for mbr and hybrid partition-table-type >> >> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/2103784375 >> >> Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de> >> --- >> board/orangepi/orangepi-rk3399/genimage.cfg | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/board/orangepi/orangepi-rk3399/genimage.cfg b/board/orangepi/orangepi-rk3399/genimage.cfg >> index c94e0bc7cc..a02166172f 100644 >> --- a/board/orangepi/orangepi-rk3399/genimage.cfg >> +++ b/board/orangepi/orangepi-rk3399/genimage.cfg >> @@ -26,14 +26,13 @@ image sdcard.img { >> } >> >> partition boot { >> - partition-type = 0xC >> + partition-type-uuid = F >> bootable = "true" >> image = "boot.vfat" >> offset = 16M >> } >> >> partition rootfs { >> - partition-type = 0x83 > > Why don't you also switch this one to partition-type-uuid? I've been asked by Arnout to drop L since it's the default: https://lists.buildroot.org/pipermail/buildroot/2022-February/636945.html I see both Thomas and Arnout seem to go for single letters intead of extended specific partition-type-uuid. That's why I didn't comment on this point that only removes partition-type. Best regards
On 17/02/2022 16:55, Marcus Hoffmann wrote: > Fixes the following error during image generation: > ERROR: hdimage(sdcard.img): part boot: 'partition-type' is only valid > for mbr and hybrid partition-table-type > > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/2103784375 > > Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de> Applied to master, thanks. Regards, Arnout > --- > board/orangepi/orangepi-rk3399/genimage.cfg | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/board/orangepi/orangepi-rk3399/genimage.cfg b/board/orangepi/orangepi-rk3399/genimage.cfg > index c94e0bc7cc..a02166172f 100644 > --- a/board/orangepi/orangepi-rk3399/genimage.cfg > +++ b/board/orangepi/orangepi-rk3399/genimage.cfg > @@ -26,14 +26,13 @@ image sdcard.img { > } > > partition boot { > - partition-type = 0xC > + partition-type-uuid = F > bootable = "true" > image = "boot.vfat" > offset = 16M > } > > partition rootfs { > - partition-type = 0x83 > image = "rootfs.ext4" > } > }
diff --git a/board/orangepi/orangepi-rk3399/genimage.cfg b/board/orangepi/orangepi-rk3399/genimage.cfg index c94e0bc7cc..a02166172f 100644 --- a/board/orangepi/orangepi-rk3399/genimage.cfg +++ b/board/orangepi/orangepi-rk3399/genimage.cfg @@ -26,14 +26,13 @@ image sdcard.img { } partition boot { - partition-type = 0xC + partition-type-uuid = F bootable = "true" image = "boot.vfat" offset = 16M } partition rootfs { - partition-type = 0x83 image = "rootfs.ext4" } }
Fixes the following error during image generation: ERROR: hdimage(sdcard.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/2103784375 Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de> --- board/orangepi/orangepi-rk3399/genimage.cfg | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)