diff mbox series

[1/2] configs/friendlyarm_nanopi_r2s_defconfig: uboot needs openssl

Message ID 20220217151054.865073-2-marcus.hoffmann@othermo.de
State Superseded
Headers show
Series defconfig fixes | expand

Commit Message

Marcus Hoffmann Feb. 17, 2022, 3:10 p.m. UTC
Fixes the following compile error:

In file included from include/bootm.h:10,
                 from tools/image-host.c:12:
include/image.h:1178:12: fatal error: openssl/evp.h: No such file or directory
 1178 | #  include <openssl/evp.h>
      |            ^~~~~~~~~~~~~~~
compilation terminated.

Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
---
 configs/friendlyarm_nanopi_r2s_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Giulio Benetti Feb. 17, 2022, 3:20 p.m. UTC | #1
Hi Marcus,

> Il giorno 17 feb 2022, alle ore 16:11, Marcus Hoffmann <marcus.hoffmann@othermo.de> ha scritto:
> 
> Fixes the following compile error:
> 
> In file included from include/bootm.h:10,
>                 from tools/image-host.c:12:
> include/image.h:1178:12: fatal error: openssl/evp.h: No such file or directory
> 1178 | #  include <openssl/evp.h>
>      |            ^~~~~~~~~~~~~~~
> compilation terminated.
> 
> Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
> ---
> configs/friendlyarm_nanopi_r2s_defconfig | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/configs/friendlyarm_nanopi_r2s_defconfig b/configs/friendlyarm_nanopi_r2s_defconfig
> index 818c847f4b..ce252a5d76 100644
> --- a/configs/friendlyarm_nanopi_r2s_defconfig
> +++ b/configs/friendlyarm_nanopi_r2s_defconfig
> @@ -30,6 +30,7 @@ BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2021.10"
> BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nanopi-r2s-rk3328"
> BR2_TARGET_UBOOT_NEEDS_DTC=y
> BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
> BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
> BR2_TARGET_UBOOT_FORMAT_CUSTOM=y

Thank you for the patch, have you verified it’s enough by building it using utils/docker-run?

Best regards
Giulio

> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Marcus Hoffmann Feb. 17, 2022, 3:22 p.m. UTC | #2
Hi Gulio,

On 17.02.22 16:20, Giulio Benetti wrote:
> Hi Marcus,
> 
>> Il giorno 17 feb 2022, alle ore 16:11, Marcus Hoffmann <marcus.hoffmann@othermo.de> ha scritto:
>>
>> Fixes the following compile error:
>>
>> In file included from include/bootm.h:10,
>>                  from tools/image-host.c:12:
>> include/image.h:1178:12: fatal error: openssl/evp.h: No such file or directory
>> 1178 | #  include <openssl/evp.h>
>>       |            ^~~~~~~~~~~~~~~
>> compilation terminated.
>>
>> Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
>> ---
>> configs/friendlyarm_nanopi_r2s_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/friendlyarm_nanopi_r2s_defconfig b/configs/friendlyarm_nanopi_r2s_defconfig
>> index 818c847f4b..ce252a5d76 100644
>> --- a/configs/friendlyarm_nanopi_r2s_defconfig
>> +++ b/configs/friendlyarm_nanopi_r2s_defconfig
>> @@ -30,6 +30,7 @@ BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2021.10"
>> BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nanopi-r2s-rk3328"
>> BR2_TARGET_UBOOT_NEEDS_DTC=y
>> BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
>> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
>> BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
>> BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
>> BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
> 
> Thank you for the patch, have you verified it’s enough by building it using utils/docker-run?

Yes, this fixes the build with docker-run. (same for the other defconfig)

Marcus

> 
> Best regards
> Giulio
> 
>> -- 
>> 2.25.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>
Giulio Benetti Feb. 17, 2022, 3:32 p.m. UTC | #3
On 17/02/22 16:22, Marcus Hoffmann wrote:
> Hi Gulio,
> 
> On 17.02.22 16:20, Giulio Benetti wrote:
>> Hi Marcus,
>>
>>> Il giorno 17 feb 2022, alle ore 16:11, Marcus Hoffmann <marcus.hoffmann@othermo.de> ha scritto:
>>>
>>> Fixes the following compile error:
>>>
>>> In file included from include/bootm.h:10,
>>>                   from tools/image-host.c:12:
>>> include/image.h:1178:12: fatal error: openssl/evp.h: No such file or directory
>>> 1178 | #  include <openssl/evp.h>
>>>        |            ^~~~~~~~~~~~~~~
>>> compilation terminated.
>>>
>>> Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
>>> ---
>>> configs/friendlyarm_nanopi_r2s_defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/configs/friendlyarm_nanopi_r2s_defconfig b/configs/friendlyarm_nanopi_r2s_defconfig
>>> index 818c847f4b..ce252a5d76 100644
>>> --- a/configs/friendlyarm_nanopi_r2s_defconfig
>>> +++ b/configs/friendlyarm_nanopi_r2s_defconfig
>>> @@ -30,6 +30,7 @@ BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2021.10"
>>> BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nanopi-r2s-rk3328"
>>> BR2_TARGET_UBOOT_NEEDS_DTC=y
>>> BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
>>> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
>>> BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
>>> BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
>>> BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
>>
>> Thank you for the patch, have you verified it’s enough by building it using utils/docker-run?
> 
> Yes, this fixes the build with docker-run. (same for the other defconfig)

Perfect, can you re-send both patches with:
"Fixes:" in commit log?
tag?

Thank you!

Best regards
diff mbox series

Patch

diff --git a/configs/friendlyarm_nanopi_r2s_defconfig b/configs/friendlyarm_nanopi_r2s_defconfig
index 818c847f4b..ce252a5d76 100644
--- a/configs/friendlyarm_nanopi_r2s_defconfig
+++ b/configs/friendlyarm_nanopi_r2s_defconfig
@@ -30,6 +30,7 @@  BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2021.10"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nanopi-r2s-rk3328"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM=y