| Message ID | 20220207113129.2701722-1-ani@anisinha.ca |
|---|---|
| Headers | show |
| Series | hw/smbios: fix table memory corruption with large memory vms | expand |
On Mon, Feb 07, 2022 at 05:01:26PM +0530, Ani Sinha wrote: > This patchset tries to address the issue raised in > https://bugzilla.redhat.com/show_bug.cgi?id=2023977 . > > Patch 2 and patch 3 are dependent on patch 1. > Patch 1 makes some code cleanup to make thing more readable and also is > a preparatory patch for patches 2 and 3. Patch 2 is the actual fix. > Patch 3 adds an additional assertion because of changes introduced in > patch 2. Ani, typically it is best to copy everyone on the cover letter. There are exceptions e.g. when the patchset is huge and the CC list would grow too big, but that is the rule. Thanks! > Ani Sinha (3): > hw/smbios: code cleanup - use macro definitions for table base > addresses > hw/smbios: fix table memory corruption with large memory vms > hw/smbios: add an assertion to ensure tables 19 and 32 do not collide > > hw/smbios/smbios.c | 58 ++++++++++++++++++++++++++++++++++------------ > 1 file changed, 43 insertions(+), 15 deletions(-) > > -- > 2.25.1 > > >
On Mon, Feb 14, 2022 at 20:04 Michael S. Tsirkin <mst@redhat.com> wrote: > > On Mon, Feb 07, 2022 at 05:01:26PM +0530, Ani Sinha wrote: > > This patchset tries to address the issue raised in > > https://bugzilla.redhat.com/show_bug.cgi?id=2023977 . > > > > Patch 2 and patch 3 are dependent on patch 1. > > Patch 1 makes some code cleanup to make thing more readable and also is > > a preparatory patch for patches 2 and 3. Patch 2 is the actual fix. > > Patch 3 adds an additional assertion because of changes introduced in > > patch 2. > > > Ani, typically it is best to copy everyone on the cover letter. > There are exceptions e.g. when the patchset is huge and the > CC list would grow too big, but that is the rule. Thanks! > > Yes that was not intentional. I overlooked the fact that the git send-email was not adding you and Igor both. Sorry about that. With v3 which I sent out earlier, I’ve explicitly added you both. > >
This patchset tries to address the issue raised in https://bugzilla.redhat.com/show_bug.cgi?id=2023977 . Patch 2 and patch 3 are dependent on patch 1. Patch 1 makes some code cleanup to make thing more readable and also is a preparatory patch for patches 2 and 3. Patch 2 is the actual fix. Patch 3 adds an additional assertion because of changes introduced in patch 2. Ani Sinha (3): hw/smbios: code cleanup - use macro definitions for table base addresses hw/smbios: fix table memory corruption with large memory vms hw/smbios: add an assertion to ensure tables 19 and 32 do not collide hw/smbios/smbios.c | 58 ++++++++++++++++++++++++++++++++++------------ 1 file changed, 43 insertions(+), 15 deletions(-)