| Message ID | 20220214030631.4969-1-guodong.liu@mediatek.com |
|---|---|
| Headers | show |
| Series | pinctrl: mediatek: Support pinctrl driver on mt8186 | expand |
Il 14/02/22 04:06, Guodong Liu ha scritto: > This commit includes pinctrl driver for mt8186. > > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/pinctrl/mediatek/Kconfig | 7 + > drivers/pinctrl/mediatek/Makefile | 1 + > drivers/pinctrl/mediatek/pinctrl-mt8186.c | 1311 ++++++++++ > drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h | 2186 +++++++++++++++++ > 4 files changed, 3505 insertions(+) > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt8186.c > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h >
Il 14/02/22 04:06, Guodong Liu ha scritto: > Change "mediatek,rsel_resistance_in_si_unit" to > "mediatek,rsel-resistance-in-si-unit" > > Fixes: fb34a9ae383a ("pinctrl: mediatek: support rsel feature") > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com> A note for maintainers: luckily, this property hasn't been used in any device-tree yet, so we luckily (since naming convention was not compliant) don't have to worry about retro-compatibility for old DTs; so... Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c > index d4e02c5d74a8..38c0f0c4cf95 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-paris.c > +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c > @@ -989,7 +989,7 @@ int mtk_paris_pinctrl_probe(struct platform_device *pdev, > hw->nbase = hw->soc->nbase_names; > > if (of_find_property(hw->dev->of_node, > - "mediatek,rsel_resistance_in_si_unit", NULL)) > + "mediatek,rsel-resistance-in-si-unit", NULL)) > hw->rsel_si_unit = true; > else > hw->rsel_si_unit = false; >
changes since v3: - remove generic descriptions for common properties - remove quotes - drop "." - drop "-" on description - move partial "bias-pull-up" description info to the example - don't break the code into two lines, maximux 84 columns is fine - add the required fixes tag changes since v2: - update reg property - update reg-names property - sync rsel resistance selection property same as patch 3 - repair constraints is not indented correctly for bias-pull-{up,down} - add "type: boolean" to the list of valid values. This corresponds to having bias-pull-{up,down} without any arguments. - add dual file license for file "mt8186-pinfunc.h" - add patch 3 to change "mediatek,rsel_resistance_in_si_unit" to "mediatek,rsel-resistance-in-si-unit" changes since v1: - add default pinctrl config to consistent with other MTK pinctrl drivers Patch 1 add pinctrl file and binding document. Patch 2 add pinctrl chip driver on mt8186. Patch 3 canonical rsel resistance selection property. Guodong Liu (3): dt-bindings: pinctrl: mt8186: add pinctrl file and binding document pinctrl: add pinctrl driver on mt8186 pinctrl: canonical rsel resistance selection property .../bindings/pinctrl/pinctrl-mt8186.yaml | 302 +++ drivers/pinctrl/mediatek/Kconfig | 7 + drivers/pinctrl/mediatek/Makefile | 1 + drivers/pinctrl/mediatek/pinctrl-mt8186.c | 1311 ++++++++++ drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h | 2186 +++++++++++++++++ drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +- include/dt-bindings/pinctrl/mt8186-pinfunc.h | 1174 +++++++++ 7 files changed, 4982 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt8186.c create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h create mode 100644 include/dt-bindings/pinctrl/mt8186-pinfunc.h