Message ID | cover.1643880577.git.quic_schowdhu@quicinc.com |
---|---|
Headers | show |
Series | Add Embedded USB Debugger (EUD) driver | expand |
On Thu, Feb 03, 2022 at 04:04:32PM +0530, Souradeep Chowdhury wrote: > Add support for control peripheral of EUD (Embedded USB Debugger) to > listen to events such as USB attach/detach, pet EUD to indicate software > is functional.Reusing the platform device kobj, sysfs entry 'enable' is > created to enable or disable EUD. > > To enable the eud the following needs to be done > echo 1 > /sys/bus/platform/.../enable > > To disable eud, following is the command > echo 0 > /sys/bus/platform/.../enable > > Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com> > --- > Documentation/ABI/testing/sysfs-driver-eud | 9 ++ > drivers/usb/common/Kconfig | 10 ++ > drivers/usb/common/Makefile | 1 + > drivers/usb/common/qcom_eud.c | 251 +++++++++++++++++++++++++++++ This really should be drivers/usb/misc/ right? No other code uses anything from this driver which is what "common" is for. thanks, greg k-h
On 2/3/2022 4:44 PM, Greg KH wrote: > On Thu, Feb 03, 2022 at 04:04:32PM +0530, Souradeep Chowdhury wrote: >> Add support for control peripheral of EUD (Embedded USB Debugger) to >> listen to events such as USB attach/detach, pet EUD to indicate software >> is functional.Reusing the platform device kobj, sysfs entry 'enable' is >> created to enable or disable EUD. >> >> To enable the eud the following needs to be done >> echo 1 > /sys/bus/platform/.../enable >> >> To disable eud, following is the command >> echo 0 > /sys/bus/platform/.../enable >> >> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com> >> --- >> Documentation/ABI/testing/sysfs-driver-eud | 9 ++ >> drivers/usb/common/Kconfig | 10 ++ >> drivers/usb/common/Makefile | 1 + >> drivers/usb/common/qcom_eud.c | 251 +++++++++++++++++++++++++++++ > This really should be drivers/usb/misc/ right? No other code uses > anything from this driver which is what "common" is for. Ack > > thanks, > > greg k-h