mbox series

[v6,0/2] Driver for Open Profile for DICE

Message ID 20220104100645.1810028-1-dbrazdil@google.com
Headers show
Series Driver for Open Profile for DICE | expand

Message

David Brazdil Jan. 4, 2022, 10:06 a.m. UTC
Open Profile for DICE is an open protocol for measured boot compatible
with the Trusted Computing Group's Device Identifier Composition
Engine (DICE) specification. The generated Compound Device Identifier
(CDI) certificates represent the measured hardware/software combination
and can be used by userspace for remote attestation and sealing.

This patchset adds DeviceTree bindings for the DICE device referencing
a reserved memory region containing the CDIs, and a driver that exposes
the memory region to userspace via a misc device.

See https://pigweed.googlesource.com/open-dice for more details.

The patches are based on top of v5.16-rc8 and can also be found here:
  https://android-kvm.googlesource.com/linux topic/dice_v6

Changes since v5:
  * replaced 'additionalProperties' with 'unevaluatedProperties' in DT YAML

Changes since v4:
  * registered compatible in 'reserved_mem_matches'
  * removed unnecessary DT node, only reserved-memory
  * fixed typos in comments

Changes since v3:
  * align with semantics of read/write
  * fix kerneldoc warnings
  * fix printf format warnings

Changes since v2:
  * renamed from 'dice' to 'open-dice'
  * replaced ioctls with read/write
  * replaced memzero_explicit with memset
  * allowed multiple instances
  * expanded Kconfig description

Changes since v1:
  * converted to miscdevice
  * all mappings now write-combine to simplify semantics
  * removed atomic state, any attempt at exclusive access
  * simplified wipe, applied on ioctl, not on release
  * fixed ioctl return value

David Brazdil (2):
  dt-bindings: reserved-memory: Open Profile for DICE
  misc: open-dice: Add driver to expose DICE data to userspace

 .../reserved-memory/google,open-dice.yaml     |  45 +++++
 drivers/misc/Kconfig                          |  12 ++
 drivers/misc/Makefile                         |   1 +
 drivers/misc/open-dice.c                      | 188 ++++++++++++++++++
 drivers/of/platform.c                         |   1 +
 5 files changed, 247 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/reserved-memory/google,open-dice.yaml
 create mode 100644 drivers/misc/open-dice.c

--
2.34.1.448.ga2b2bfdf31-goog

Comments

Greg Kroah-Hartman Jan. 26, 2022, 9:04 a.m. UTC | #1
On Tue, Jan 04, 2022 at 10:06:43AM +0000, David Brazdil wrote:
> Open Profile for DICE is an open protocol for measured boot compatible
> with the Trusted Computing Group's Device Identifier Composition
> Engine (DICE) specification. The generated Compound Device Identifier
> (CDI) certificates represent the measured hardware/software combination
> and can be used by userspace for remote attestation and sealing.
> 
> This patchset adds DeviceTree bindings for the DICE device referencing
> a reserved memory region containing the CDIs, and a driver that exposes
> the memory region to userspace via a misc device.
> 
> See https://pigweed.googlesource.com/open-dice for more details.
> 
> The patches are based on top of v5.16-rc8 and can also be found here:
>   https://android-kvm.googlesource.com/linux topic/dice_v6
> 
> Changes since v5:
>   * replaced 'additionalProperties' with 'unevaluatedProperties' in DT YAML

I am going to drop this version from my review queue as I think you have
a new one instead, right?

thanks,

greg k-h
David Brazdil Jan. 26, 2022, 10:39 a.m. UTC | #2
Hi Greg,

On Wed, Jan 26, 2022 at 10:04:20AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 04, 2022 at 10:06:43AM +0000, David Brazdil wrote:
> > Open Profile for DICE is an open protocol for measured boot compatible
> > with the Trusted Computing Group's Device Identifier Composition
> > Engine (DICE) specification. The generated Compound Device Identifier
> > (CDI) certificates represent the measured hardware/software combination
> > and can be used by userspace for remote attestation and sealing.
> > 
> > This patchset adds DeviceTree bindings for the DICE device referencing
> > a reserved memory region containing the CDIs, and a driver that exposes
> > the memory region to userspace via a misc device.
> > 
> > See https://pigweed.googlesource.com/open-dice for more details.
> > 
> > The patches are based on top of v5.16-rc8 and can also be found here:
> >   https://android-kvm.googlesource.com/linux topic/dice_v6
> > 
> > Changes since v5:
> >   * replaced 'additionalProperties' with 'unevaluatedProperties' in DT YAML
> 
> I am going to drop this version from my review queue as I think you have
> a new one instead, right?

Sorry for the radio silence and yes, please drop from your queue. I need
to post a new one and get back to Wedson. Hopefully today.

David