mbox series

[net-next,v2,0/2] Allow disabling KSZ switch refclock

Message ID 20220125171140.258190-1-robert.hancock@calian.com
Headers show
Series Allow disabling KSZ switch refclock | expand

Message

Robert Hancock Jan. 25, 2022, 5:11 p.m. UTC 
The reference clock output from the KSZ9477 and related Microchip
switch devices is not required on all board designs. Add a device
tree property to disable it for power and EMI reasons.

Changes since v1:
-added Acked-by on patch 1, rebase to net-next

Robert Hancock (2):
  net: dsa: microchip: Document property to disable reference clock
  net: dsa: microchip: Add property to disable reference clock

 .../devicetree/bindings/net/dsa/microchip,ksz.yaml         | 5 +++++
 drivers/net/dsa/microchip/ksz9477.c                        | 7 ++++++-
 drivers/net/dsa/microchip/ksz_common.c                     | 2 ++
 drivers/net/dsa/microchip/ksz_common.h                     | 1 +
 4 files changed, 14 insertions(+), 1 deletion(-)

Comments

Andrew Lunn Jan. 25, 2022, 5:32 p.m. UTC | #1 
>  		dev->synclko_125 = of_property_read_bool(dev->dev->of_node,
>  							 "microchip,synclko-125");
> +		dev->synclko_disable = of_property_read_bool(dev->dev->of_node,
> +							     "microchip,synclko-disable");

It seems like microchip,synclko-125 and microchip,synclko-disable are
mutually exclusive? Please add an -EINVAL if both a present.

This should also be mentioned in the binding document.

Thanks
	Andrew