mbox series

[v4,0/9] Nuvoton WPCM450 pinctrl and GPIO driver

Message ID 20220109173000.1242703-1-j.neuschaefer@gmx.net
Headers show
Series Nuvoton WPCM450 pinctrl and GPIO driver | expand

Message

J. Neuschäfer Jan. 9, 2022, 5:29 p.m. UTC 
This is version 4 of the WPCM450 pinctrl/GPIO driver patchset,
with some small, (hopefully) final improvements and cleanups
(see patches 4 and 5).

I'm targetting 5.18, it's now too close to the 5.17 merge window anyway.

Best regards,
Jonathan Neuschäfer

v3:
- https://lore.kernel.org/lkml/20211224200935.93817-1-j.neuschaefer@gmx.net/

v2:
- https://lore.kernel.org/lkml/20211207210823.1975632-1-j.neuschaefer@gmx.net/

v1:
- https://lore.kernel.org/lkml/20210602120329.2444672-1-j.neuschaefer@gmx.net/

> This series adds support for pinctrl and GPIO in the Nuvoton WPCM450 SoC.
> Both my DT bindings and my driver are based on the work done by others for
> the newer Nuvoton NPCM7xx SoC, and I've tried to keep both similar.
>
> Instead of extending the pinctrl-npcm7xx driver to add WPCM450 support,
> I copied/forked it. The pinmux mechanism is very similar (using MFSEL1 and
> MFSEL2 registers), but the GPIO register interface has been redesigned for
> NPCM7xx; adding support for the older GPIO controller would make the driver
> harder to understand, while only enabling a small amount of code sharing.
>
> The DT binding in YAML format might make a good template for also converting
> the nuvoton,npcm7xx-pinctrl binding to YAML.
>
> Both in the DT binding and in the driver I kept the name "pinctrl". For the
> driver, I find it accurate enough because it handles pinctrl and GPIO. For
> the DT node, it's a bit less accurate because the register block at 0xb8003000
> is about GPIOs, and pin control happens in the global control registers (GCR)
> block, except for input debouncing. So, "GPIO" might be the more appropriate
> name component there.

Jonathan Neuschäfer (9):
  dt-bindings: arm/npcm: Add binding for global control registers (GCR)
  MAINTAINERS: Match all of bindings/arm/npcm/ as part of NPCM
    architecture
  ARM: dts: wpcm450: Add global control registers (GCR) node
  dt-bindings: pinctrl: Add Nuvoton WPCM450
  pinctrl: nuvoton: Add driver for WPCM450
  ARM: dts: wpcm450: Add pinctrl and GPIO nodes
  ARM: dts: wpcm450: Add pin functions
  ARM: dts: wpcm450-supermicro-x9sci-ln4f: Add GPIO LEDs and buttons
  ARM: dts: wpcm450: Add pinmux information to UART0

 .../bindings/arm/npcm/nuvoton,gcr.yaml        |   48 +
 .../pinctrl/nuvoton,wpcm450-pinctrl.yaml      |  160 +++
 MAINTAINERS                                   |    2 +
 .../nuvoton-wpcm450-supermicro-x9sci-ln4f.dts |   43 +
 arch/arm/boot/dts/nuvoton-wpcm450.dtsi        |  384 ++++++
 drivers/pinctrl/Makefile                      |    2 +-
 drivers/pinctrl/nuvoton/Kconfig               |   18 +
 drivers/pinctrl/nuvoton/Makefile              |    1 +
 drivers/pinctrl/nuvoton/pinctrl-wpcm450.c     | 1130 +++++++++++++++++
 9 files changed, 1787 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml
 create mode 100644 drivers/pinctrl/nuvoton/pinctrl-wpcm450.c

--
2.30.2

Comments

Linus Walleij Jan. 16, 2022, 12:38 a.m. UTC | #1 
On Sun, Jan 9, 2022 at 6:34 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:

> This is version 4 of the WPCM450 pinctrl/GPIO driver patchset,
> with some small, (hopefully) final improvements and cleanups
> (see patches 4 and 5).

It looks good to me, but I'd like some confirmation that Andy
is happy with it.

> I'm targetting 5.18, it's now too close to the 5.17 merge window anyway.

Could you rebase it on v5.17-rc and resend it once that comes out?
It would help me a lot to have a known good baseline.

Thanks!
Linus Walleij
J. Neuschäfer Jan. 16, 2022, 11:36 a.m. UTC | #2 
On Sun, Jan 16, 2022 at 01:38:32AM +0100, Linus Walleij wrote:
> On Sun, Jan 9, 2022 at 6:34 PM Jonathan Neuschäfer
> <j.neuschaefer@gmx.net> wrote:
> 
> > This is version 4 of the WPCM450 pinctrl/GPIO driver patchset,
> > with some small, (hopefully) final improvements and cleanups
> > (see patches 4 and 5).
> 
> It looks good to me, but I'd like some confirmation that Andy
> is happy with it.
> 
> > I'm targetting 5.18, it's now too close to the 5.17 merge window anyway.
> 
> Could you rebase it on v5.17-rc and resend it once that comes out?
> It would help me a lot to have a known good baseline.

Yes, I'll do it.


Jonathan