| Message ID | 20220105155109.3744828-1-rsalvaterra@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Rui Salvaterra |
| Headers | show |
| Series | kernel/5.10: disable CONFIG_DEVTMPFS{,_MOUNT} | expand |
On Wed, Jan 05, 2022 at 03:51:09PM +0000, Rui Salvaterra wrote: > We rely on procd to create/populate /dev for us. These can be safely disabled. NACK. Disabling this will afaik break LXC and containers relying on it. We could enable it selectively on !SMALL_FLASH instead, to safe space on targets where anyway there are no resources for containers. > > Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> > --- > target/linux/archs38/config-5.10 | 1 - > target/linux/layerscape/armv7/config-5.10 | 2 -- > target/linux/layerscape/armv8_64b/config-5.10 | 2 -- > target/linux/mediatek/mt7622/config-5.10 | 2 -- > target/linux/oxnas/config-5.10 | 2 -- > target/linux/rockchip/armv8/config-5.10 | 2 -- > 6 files changed, 11 deletions(-) > > diff --git a/target/linux/archs38/config-5.10 b/target/linux/archs38/config-5.10 > index 5ba3877a64..b082a47331 100644 > --- a/target/linux/archs38/config-5.10 > +++ b/target/linux/archs38/config-5.10 > @@ -84,7 +84,6 @@ CONFIG_CRYPTO_RNG=y > CONFIG_CRYPTO_RNG2=y > CONFIG_CRYPTO_RNG_DEFAULT=y > CONFIG_CRYPTO_SHA256=y > -CONFIG_DEVTMPFS=y > CONFIG_DMADEVICES=y > CONFIG_DMA_DIRECT_REMAP=y > CONFIG_DMA_ENGINE=y > diff --git a/target/linux/layerscape/armv7/config-5.10 b/target/linux/layerscape/armv7/config-5.10 > index 0ec201030f..dd97d67cba 100644 > --- a/target/linux/layerscape/armv7/config-5.10 > +++ b/target/linux/layerscape/armv7/config-5.10 > @@ -170,8 +170,6 @@ CONFIG_DETECT_HUNG_TASK=y > # CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND is not set > # CONFIG_DEVFREQ_GOV_USERSPACE is not set > # CONFIG_DEVFREQ_THERMAL is not set > -CONFIG_DEVTMPFS=y > -CONFIG_DEVTMPFS_MOUNT=y > CONFIG_DMADEVICES=y > CONFIG_DMA_CMA=y > CONFIG_DMA_ENGINE=y > diff --git a/target/linux/layerscape/armv8_64b/config-5.10 b/target/linux/layerscape/armv8_64b/config-5.10 > index aa4be18f05..03c85a5aef 100644 > --- a/target/linux/layerscape/armv8_64b/config-5.10 > +++ b/target/linux/layerscape/armv8_64b/config-5.10 > @@ -204,8 +204,6 @@ CONFIG_DECOMPRESS_LZMA=y > CONFIG_DECOMPRESS_LZO=y > CONFIG_DECOMPRESS_XZ=y > CONFIG_DETECT_HUNG_TASK=y > -CONFIG_DEVTMPFS=y > -CONFIG_DEVTMPFS_MOUNT=y > CONFIG_DIMLIB=y > CONFIG_DMADEVICES=y > CONFIG_DMATEST=y > diff --git a/target/linux/mediatek/mt7622/config-5.10 b/target/linux/mediatek/mt7622/config-5.10 > index da1b283f70..946cab7738 100644 > --- a/target/linux/mediatek/mt7622/config-5.10 > +++ b/target/linux/mediatek/mt7622/config-5.10 > @@ -134,8 +134,6 @@ CONFIG_CRYPTO_SHA256=y > CONFIG_CRYPTO_ZSTD=y > CONFIG_DCACHE_WORD_ACCESS=y > CONFIG_DEBUG_MISC=y > -CONFIG_DEVTMPFS=y > -CONFIG_DEVTMPFS_MOUNT=y > CONFIG_DIMLIB=y > CONFIG_DMADEVICES=y > CONFIG_DMATEST=y > diff --git a/target/linux/oxnas/config-5.10 b/target/linux/oxnas/config-5.10 > index b0e4789d1e..93fbf5386d 100644 > --- a/target/linux/oxnas/config-5.10 > +++ b/target/linux/oxnas/config-5.10 > @@ -117,8 +117,6 @@ CONFIG_DECOMPRESS_LZ4=y > CONFIG_DECOMPRESS_LZMA=y > CONFIG_DECOMPRESS_LZO=y > CONFIG_DECOMPRESS_XZ=y > -CONFIG_DEVTMPFS=y > -CONFIG_DEVTMPFS_MOUNT=y > CONFIG_DMA_CMA=y > CONFIG_DMA_REMAP=y > CONFIG_DNOTIFY=y > diff --git a/target/linux/rockchip/armv8/config-5.10 b/target/linux/rockchip/armv8/config-5.10 > index 9769bab72d..1063489dc6 100644 > --- a/target/linux/rockchip/armv8/config-5.10 > +++ b/target/linux/rockchip/armv8/config-5.10 > @@ -167,8 +167,6 @@ CONFIG_DEVFREQ_GOV_USERSPACE=y > # CONFIG_DEVFREQ_THERMAL is not set > CONFIG_DEVMEM=y > # CONFIG_DEVPORT is not set > -CONFIG_DEVTMPFS=y > -CONFIG_DEVTMPFS_MOUNT=y > CONFIG_DMADEVICES=y > CONFIG_DMA_CMA=y > CONFIG_DMA_DIRECT_REMAP=y > -- > 2.34.1 > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
On Wed, Jan 05, 2022 at 03:54:56PM +0000, Daniel Golle wrote: > On Wed, Jan 05, 2022 at 03:51:09PM +0000, Rui Salvaterra wrote: > > We rely on procd to create/populate /dev for us. These can be safely disabled. > > NACK. Disabling this will afaik break LXC and containers relying on it. > We could enable it selectively on !SMALL_FLASH instead, to safe space > on targets where anyway there are no resources for containers. Just realizing that this is already defined in Config-kernel.in, so removing it from the target configs is the right thing to do, just the reasoning is different ;) > > > > > Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> > > --- > > target/linux/archs38/config-5.10 | 1 - > > target/linux/layerscape/armv7/config-5.10 | 2 -- > > target/linux/layerscape/armv8_64b/config-5.10 | 2 -- > > target/linux/mediatek/mt7622/config-5.10 | 2 -- > > target/linux/oxnas/config-5.10 | 2 -- > > target/linux/rockchip/armv8/config-5.10 | 2 -- > > 6 files changed, 11 deletions(-) > > > > diff --git a/target/linux/archs38/config-5.10 b/target/linux/archs38/config-5.10 > > index 5ba3877a64..b082a47331 100644 > > --- a/target/linux/archs38/config-5.10 > > +++ b/target/linux/archs38/config-5.10 > > @@ -84,7 +84,6 @@ CONFIG_CRYPTO_RNG=y > > CONFIG_CRYPTO_RNG2=y > > CONFIG_CRYPTO_RNG_DEFAULT=y > > CONFIG_CRYPTO_SHA256=y > > -CONFIG_DEVTMPFS=y > > CONFIG_DMADEVICES=y > > CONFIG_DMA_DIRECT_REMAP=y > > CONFIG_DMA_ENGINE=y > > diff --git a/target/linux/layerscape/armv7/config-5.10 b/target/linux/layerscape/armv7/config-5.10 > > index 0ec201030f..dd97d67cba 100644 > > --- a/target/linux/layerscape/armv7/config-5.10 > > +++ b/target/linux/layerscape/armv7/config-5.10 > > @@ -170,8 +170,6 @@ CONFIG_DETECT_HUNG_TASK=y > > # CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND is not set > > # CONFIG_DEVFREQ_GOV_USERSPACE is not set > > # CONFIG_DEVFREQ_THERMAL is not set > > -CONFIG_DEVTMPFS=y > > -CONFIG_DEVTMPFS_MOUNT=y > > CONFIG_DMADEVICES=y > > CONFIG_DMA_CMA=y > > CONFIG_DMA_ENGINE=y > > diff --git a/target/linux/layerscape/armv8_64b/config-5.10 b/target/linux/layerscape/armv8_64b/config-5.10 > > index aa4be18f05..03c85a5aef 100644 > > --- a/target/linux/layerscape/armv8_64b/config-5.10 > > +++ b/target/linux/layerscape/armv8_64b/config-5.10 > > @@ -204,8 +204,6 @@ CONFIG_DECOMPRESS_LZMA=y > > CONFIG_DECOMPRESS_LZO=y > > CONFIG_DECOMPRESS_XZ=y > > CONFIG_DETECT_HUNG_TASK=y > > -CONFIG_DEVTMPFS=y > > -CONFIG_DEVTMPFS_MOUNT=y > > CONFIG_DIMLIB=y > > CONFIG_DMADEVICES=y > > CONFIG_DMATEST=y > > diff --git a/target/linux/mediatek/mt7622/config-5.10 b/target/linux/mediatek/mt7622/config-5.10 > > index da1b283f70..946cab7738 100644 > > --- a/target/linux/mediatek/mt7622/config-5.10 > > +++ b/target/linux/mediatek/mt7622/config-5.10 > > @@ -134,8 +134,6 @@ CONFIG_CRYPTO_SHA256=y > > CONFIG_CRYPTO_ZSTD=y > > CONFIG_DCACHE_WORD_ACCESS=y > > CONFIG_DEBUG_MISC=y > > -CONFIG_DEVTMPFS=y > > -CONFIG_DEVTMPFS_MOUNT=y > > CONFIG_DIMLIB=y > > CONFIG_DMADEVICES=y > > CONFIG_DMATEST=y > > diff --git a/target/linux/oxnas/config-5.10 b/target/linux/oxnas/config-5.10 > > index b0e4789d1e..93fbf5386d 100644 > > --- a/target/linux/oxnas/config-5.10 > > +++ b/target/linux/oxnas/config-5.10 > > @@ -117,8 +117,6 @@ CONFIG_DECOMPRESS_LZ4=y > > CONFIG_DECOMPRESS_LZMA=y > > CONFIG_DECOMPRESS_LZO=y > > CONFIG_DECOMPRESS_XZ=y > > -CONFIG_DEVTMPFS=y > > -CONFIG_DEVTMPFS_MOUNT=y > > CONFIG_DMA_CMA=y > > CONFIG_DMA_REMAP=y > > CONFIG_DNOTIFY=y > > diff --git a/target/linux/rockchip/armv8/config-5.10 b/target/linux/rockchip/armv8/config-5.10 > > index 9769bab72d..1063489dc6 100644 > > --- a/target/linux/rockchip/armv8/config-5.10 > > +++ b/target/linux/rockchip/armv8/config-5.10 > > @@ -167,8 +167,6 @@ CONFIG_DEVFREQ_GOV_USERSPACE=y > > # CONFIG_DEVFREQ_THERMAL is not set > > CONFIG_DEVMEM=y > > # CONFIG_DEVPORT is not set > > -CONFIG_DEVTMPFS=y > > -CONFIG_DEVTMPFS_MOUNT=y > > CONFIG_DMADEVICES=y > > CONFIG_DMA_CMA=y > > CONFIG_DMA_DIRECT_REMAP=y > > -- > > 2.34.1 > > > > > > _______________________________________________ > > openwrt-devel mailing list > > openwrt-devel@lists.openwrt.org > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff --git a/target/linux/archs38/config-5.10 b/target/linux/archs38/config-5.10 index 5ba3877a64..b082a47331 100644 --- a/target/linux/archs38/config-5.10 +++ b/target/linux/archs38/config-5.10 @@ -84,7 +84,6 @@ CONFIG_CRYPTO_RNG=y CONFIG_CRYPTO_RNG2=y CONFIG_CRYPTO_RNG_DEFAULT=y CONFIG_CRYPTO_SHA256=y -CONFIG_DEVTMPFS=y CONFIG_DMADEVICES=y CONFIG_DMA_DIRECT_REMAP=y CONFIG_DMA_ENGINE=y diff --git a/target/linux/layerscape/armv7/config-5.10 b/target/linux/layerscape/armv7/config-5.10 index 0ec201030f..dd97d67cba 100644 --- a/target/linux/layerscape/armv7/config-5.10 +++ b/target/linux/layerscape/armv7/config-5.10 @@ -170,8 +170,6 @@ CONFIG_DETECT_HUNG_TASK=y # CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND is not set # CONFIG_DEVFREQ_GOV_USERSPACE is not set # CONFIG_DEVFREQ_THERMAL is not set -CONFIG_DEVTMPFS=y -CONFIG_DEVTMPFS_MOUNT=y CONFIG_DMADEVICES=y CONFIG_DMA_CMA=y CONFIG_DMA_ENGINE=y diff --git a/target/linux/layerscape/armv8_64b/config-5.10 b/target/linux/layerscape/armv8_64b/config-5.10 index aa4be18f05..03c85a5aef 100644 --- a/target/linux/layerscape/armv8_64b/config-5.10 +++ b/target/linux/layerscape/armv8_64b/config-5.10 @@ -204,8 +204,6 @@ CONFIG_DECOMPRESS_LZMA=y CONFIG_DECOMPRESS_LZO=y CONFIG_DECOMPRESS_XZ=y CONFIG_DETECT_HUNG_TASK=y -CONFIG_DEVTMPFS=y -CONFIG_DEVTMPFS_MOUNT=y CONFIG_DIMLIB=y CONFIG_DMADEVICES=y CONFIG_DMATEST=y diff --git a/target/linux/mediatek/mt7622/config-5.10 b/target/linux/mediatek/mt7622/config-5.10 index da1b283f70..946cab7738 100644 --- a/target/linux/mediatek/mt7622/config-5.10 +++ b/target/linux/mediatek/mt7622/config-5.10 @@ -134,8 +134,6 @@ CONFIG_CRYPTO_SHA256=y CONFIG_CRYPTO_ZSTD=y CONFIG_DCACHE_WORD_ACCESS=y CONFIG_DEBUG_MISC=y -CONFIG_DEVTMPFS=y -CONFIG_DEVTMPFS_MOUNT=y CONFIG_DIMLIB=y CONFIG_DMADEVICES=y CONFIG_DMATEST=y diff --git a/target/linux/oxnas/config-5.10 b/target/linux/oxnas/config-5.10 index b0e4789d1e..93fbf5386d 100644 --- a/target/linux/oxnas/config-5.10 +++ b/target/linux/oxnas/config-5.10 @@ -117,8 +117,6 @@ CONFIG_DECOMPRESS_LZ4=y CONFIG_DECOMPRESS_LZMA=y CONFIG_DECOMPRESS_LZO=y CONFIG_DECOMPRESS_XZ=y -CONFIG_DEVTMPFS=y -CONFIG_DEVTMPFS_MOUNT=y CONFIG_DMA_CMA=y CONFIG_DMA_REMAP=y CONFIG_DNOTIFY=y diff --git a/target/linux/rockchip/armv8/config-5.10 b/target/linux/rockchip/armv8/config-5.10 index 9769bab72d..1063489dc6 100644 --- a/target/linux/rockchip/armv8/config-5.10 +++ b/target/linux/rockchip/armv8/config-5.10 @@ -167,8 +167,6 @@ CONFIG_DEVFREQ_GOV_USERSPACE=y # CONFIG_DEVFREQ_THERMAL is not set CONFIG_DEVMEM=y # CONFIG_DEVPORT is not set -CONFIG_DEVTMPFS=y -CONFIG_DEVTMPFS_MOUNT=y CONFIG_DMADEVICES=y CONFIG_DMA_CMA=y CONFIG_DMA_DIRECT_REMAP=y
We rely on procd to create/populate /dev for us. These can be safely disabled. Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> --- target/linux/archs38/config-5.10 | 1 - target/linux/layerscape/armv7/config-5.10 | 2 -- target/linux/layerscape/armv8_64b/config-5.10 | 2 -- target/linux/mediatek/mt7622/config-5.10 | 2 -- target/linux/oxnas/config-5.10 | 2 -- target/linux/rockchip/armv8/config-5.10 | 2 -- 6 files changed, 11 deletions(-)