| Message ID | 1640042998-117712-1-git-send-email-jdamato@fastly.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [net-queue] i40e: Remove unused RX realloc stat | expand |
On Mon, 2021-12-20 at 15:29 -0800, Joe Damato wrote: > rx_stats.realloc_count was not being incremented after 1a557afc4dd5, > so > remove it. A couple of nits for you. When referencing a commit, you should include the title in addition to the SHA [1]. Also, unused code should be sent to next-queue. Thanks, Tony > The debugfs string was left but hardcoded to 0. This is intended to > prevent breaking any existing code / scripts that are parsing debugfs > for i40e. > > Signed-off-by: Joe Damato <jdamato@fastly.com> > Fixes: 1a557afc4dd5 ("i40e: Refactor receive routine") https://www.kernel.org/doc/html/latest/process/submitting- patches.html#describe-your-changes
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c index 1e57cc8..90fff05 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c @@ -275,9 +275,8 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid) rx_ring->rx_stats.alloc_page_failed, rx_ring->rx_stats.alloc_buff_failed); dev_info(&pf->pdev->dev, - " rx_rings[%i]: rx_stats: realloc_count = %lld, page_reuse_count = %lld\n", + " rx_rings[%i]: rx_stats: realloc_count = 0, page_reuse_count = %lld\n", i, - rx_ring->rx_stats.realloc_count, rx_ring->rx_stats.page_reuse_count); dev_info(&pf->pdev->dev, " rx_rings[%i]: size = %i\n", diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h index bfc2845..88387a6 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.h +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.h @@ -298,7 +298,6 @@ struct i40e_rx_queue_stats { u64 alloc_page_failed; u64 alloc_buff_failed; u64 page_reuse_count; - u64 realloc_count; }; enum i40e_ring_state_t {
rx_stats.realloc_count was not being incremented after 1a557afc4dd5, so remove it. The debugfs string was left but hardcoded to 0. This is intended to prevent breaking any existing code / scripts that are parsing debugfs for i40e. Signed-off-by: Joe Damato <jdamato@fastly.com> Fixes: 1a557afc4dd5 ("i40e: Refactor receive routine") --- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 3 +-- drivers/net/ethernet/intel/i40e/i40e_txrx.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-)