Message ID | 20211213142914.3665037-1-vicamo.yang@canonical.com |
---|---|
Headers | show |
Series | platform/x86: amd-pmc: Fix s2idle failures on certain AMD laptops | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 12/13/21 7:29 AM, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1954633 > > [Impact] > > AMD Ryzen 7 platforms fail to s2idle when powered by bettery. > > [Fix] > > Upstream fix commit 49201b90af81 ("platform/x86: amd-pmc: Fix s2idle > failures on certain AMD laptops") from v5.16-rc5. > > [Test Case] > > Run checkbox suspend/resume tests on battey: > > $ checkbox-cli run \ > com.canonical.certification::stress-suspend-30-cycles-with-reboots-automated > > [Where problems could occur] > > This shortens AMD PMC communication poll delay to a half of the original > value. While we don't have much information about the exact value range > allowed, the side effect couldn't be evaluated practically. This change > was ACKed by AMD developers and has been marked cc stable, we'll > probably bump into it anyway. > > [Other Info] > > This may affect kernel >= 5.11. While Hirsute is near its EOL, it was > skipped here. > > Fabrizio Bertocci (1): > platform/x86: amd-pmc: Fix s2idle failures on certain AMD laptops > > drivers/platform/x86/amd-pmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
On 13.12.2021 16.29, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1954633 > > [Impact] > > AMD Ryzen 7 platforms fail to s2idle when powered by bettery. > > [Fix] > > Upstream fix commit 49201b90af81 ("platform/x86: amd-pmc: Fix s2idle > failures on certain AMD laptops") from v5.16-rc5. > > [Test Case] > > Run checkbox suspend/resume tests on battey: > > $ checkbox-cli run \ > com.canonical.certification::stress-suspend-30-cycles-with-reboots-automated > > [Where problems could occur] > > This shortens AMD PMC communication poll delay to a half of the original > value. While we don't have much information about the exact value range > allowed, the side effect couldn't be evaluated practically. This change > was ACKed by AMD developers and has been marked cc stable, we'll > probably bump into it anyway. > > [Other Info] > > This may affect kernel >= 5.11. While Hirsute is near its EOL, it was > skipped here. > > Fabrizio Bertocci (1): > platform/x86: amd-pmc: Fix s2idle failures on certain AMD laptops > > drivers/platform/x86/amd-pmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > applied to oem-5.14, thanks
On 13.12.2021 16.29, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1954633 > > [Impact] > > AMD Ryzen 7 platforms fail to s2idle when powered by bettery. > > [Fix] > > Upstream fix commit 49201b90af81 ("platform/x86: amd-pmc: Fix s2idle > failures on certain AMD laptops") from v5.16-rc5. > > [Test Case] > > Run checkbox suspend/resume tests on battey: > > $ checkbox-cli run \ > com.canonical.certification::stress-suspend-30-cycles-with-reboots-automated > > [Where problems could occur] > > This shortens AMD PMC communication poll delay to a half of the original > value. While we don't have much information about the exact value range > allowed, the side effect couldn't be evaluated practically. This change > was ACKed by AMD developers and has been marked cc stable, we'll > probably bump into it anyway. > > [Other Info] > > This may affect kernel >= 5.11. While Hirsute is near its EOL, it was > skipped here. > > Fabrizio Bertocci (1): > platform/x86: amd-pmc: Fix s2idle failures on certain AMD laptops > > drivers/platform/x86/amd-pmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > applied to oem-5.13, thanks
On 13.12.21 15:29, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1954633 > > [Impact] > > AMD Ryzen 7 platforms fail to s2idle when powered by bettery. > > [Fix] > > Upstream fix commit 49201b90af81 ("platform/x86: amd-pmc: Fix s2idle > failures on certain AMD laptops") from v5.16-rc5. > > [Test Case] > > Run checkbox suspend/resume tests on battey: > > $ checkbox-cli run \ > com.canonical.certification::stress-suspend-30-cycles-with-reboots-automated > > [Where problems could occur] > > This shortens AMD PMC communication poll delay to a half of the original > value. While we don't have much information about the exact value range > allowed, the side effect couldn't be evaluated practically. This change > was ACKed by AMD developers and has been marked cc stable, we'll > probably bump into it anyway. > > [Other Info] > > This may affect kernel >= 5.11. While Hirsute is near its EOL, it was > skipped here. > > Fabrizio Bertocci (1): > platform/x86: amd-pmc: Fix s2idle failures on certain AMD laptops > > drivers/platform/x86/amd-pmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> Thanks
On Mon, Dec 13, 2021 at 10:29:13PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1954633
The fix is already part of stable 5.15.8, so i'm not applying this one.
On 13.12.21 15:29, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1954633 > > [Impact] > > AMD Ryzen 7 platforms fail to s2idle when powered by bettery. > > [Fix] > > Upstream fix commit 49201b90af81 ("platform/x86: amd-pmc: Fix s2idle > failures on certain AMD laptops") from v5.16-rc5. > > [Test Case] > > Run checkbox suspend/resume tests on battey: > > $ checkbox-cli run \ > com.canonical.certification::stress-suspend-30-cycles-with-reboots-automated > > [Where problems could occur] > > This shortens AMD PMC communication poll delay to a half of the original > value. While we don't have much information about the exact value range > allowed, the side effect couldn't be evaluated practically. This change > was ACKed by AMD developers and has been marked cc stable, we'll > probably bump into it anyway. > > [Other Info] > > This may affect kernel >= 5.11. While Hirsute is near its EOL, it was > skipped here. > > Fabrizio Bertocci (1): > platform/x86: amd-pmc: Fix s2idle failures on certain AMD laptops > > drivers/platform/x86/amd-pmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to impish:linux. Thanks, Kleber