mbox series

[SRU,Unstable/OEM-5.14,0/4] Add support for NVIDIA EC backlight

Message ID 20211206063457.1522003-1-kai.heng.feng@canonical.com
Headers show
Series Add support for NVIDIA EC backlight | expand

Message

Kai-Heng Feng Dec. 6, 2021, 6:34 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1953286

[Impact]
Some system equipped with NVIDIA GFX cannot change screen brightness.

[Fix]
Add new way to change brightness.

[Test]
After the fix is applied, there's a new backlight sysfs
"nvidia_wmi_ec_backlight" can change the screen brightness.

[Where problems could occur]
The driver relies on BIOS to behave correctly. If the BIOS lies or has a
bug, the new backlight interface will overtake other backlight
interfaces. It's rather unlikely though.

Daniel Dadap (3):
  platform/x86: Add driver for ACPI WMAA EC-based backlight control
  platform/x86: Remove "WMAA" from identifier names in
    wmaa-backlight-wmi.c
  platform/x86: Rename wmaa-backlight-wmi to nvidia-wmi-ec-backlight

Kai-Heng Feng (1):
  UBUNTU: [Config] NVIDIA_WMI_EC_BACKLIGHT=m

 MAINTAINERS                                   |   6 +
 debian.master/config/annotations              |   1 +
 debian.master/config/config.common.ubuntu     |   1 +
 drivers/platform/x86/Kconfig                  |  15 ++
 drivers/platform/x86/Makefile                 |   1 +
 .../platform/x86/nvidia-wmi-ec-backlight.c    | 213 ++++++++++++++++++
 6 files changed, 237 insertions(+)
 create mode 100644 drivers/platform/x86/nvidia-wmi-ec-backlight.c

Comments

Timo Aaltonen Dec. 13, 2021, 12:36 p.m. UTC | #1
On 6.12.2021 8.34, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1953286
> 
> [Impact]
> Some system equipped with NVIDIA GFX cannot change screen brightness.
> 
> [Fix]
> Add new way to change brightness.
> 
> [Test]
> After the fix is applied, there's a new backlight sysfs
> "nvidia_wmi_ec_backlight" can change the screen brightness.
> 
> [Where problems could occur]
> The driver relies on BIOS to behave correctly. If the BIOS lies or has a
> bug, the new backlight interface will overtake other backlight
> interfaces. It's rather unlikely though.
> 
> Daniel Dadap (3):
>    platform/x86: Add driver for ACPI WMAA EC-based backlight control
>    platform/x86: Remove "WMAA" from identifier names in
>      wmaa-backlight-wmi.c
>    platform/x86: Rename wmaa-backlight-wmi to nvidia-wmi-ec-backlight
> 
> Kai-Heng Feng (1):
>    UBUNTU: [Config] NVIDIA_WMI_EC_BACKLIGHT=m
> 
>   MAINTAINERS                                   |   6 +
>   debian.master/config/annotations              |   1 +
>   debian.master/config/config.common.ubuntu     |   1 +
>   drivers/platform/x86/Kconfig                  |  15 ++
>   drivers/platform/x86/Makefile                 |   1 +
>   .../platform/x86/nvidia-wmi-ec-backlight.c    | 213 ++++++++++++++++++
>   6 files changed, 237 insertions(+)
>   create mode 100644 drivers/platform/x86/nvidia-wmi-ec-backlight.c
> 

applied to oem-5.14, thanks
Paolo Pisati Dec. 17, 2021, 10:37 a.m. UTC | #2
On Mon, Dec 06, 2021 at 02:34:50PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1953286