mbox series

[RESEND,0/1,SRU,H,I] Add F81966 watchdog support

Message ID 20211206055710.348049-1-acelan.kao@canonical.com
Headers show
Series Add F81966 watchdog support | expand

Message

AceLan Kao Dec. 6, 2021, 5:57 a.m. UTC
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1949063

[Impact]
f71808e_wdt watchdog driver can't recognize F81966 chip.

[Fix]
AAEON provides a patch to add the ID.
https://www.spinics.net/lists/kernel/msg4147351.html

[Test]
Testing was done on the Aaeon SSE-OPTI

[Where problems could occur]
Simply adding one ID, should not introduce any regressions.

[Misc]
This patch is for ODM project and need this to be included as soon as
possible, so we submit this patch as a sauce patch before upstream merges
it.
BTW, Jammy already included this commit when the patch was submitted for
the SRU the first time.

AaeonIot (1):
  UBUNTU: SAUCE: watchdog: f71808e_wdt: Add F81966 support

 drivers/watchdog/f71808e_wdt.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
 mode change 100644 => 100755 drivers/watchdog/f71808e_wdt.c

Comments

Tim Gardner Dec. 6, 2021, 3:11 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 12/5/21 10:57 PM, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1949063
> 
> [Impact]
> f71808e_wdt watchdog driver can't recognize F81966 chip.
> 
> [Fix]
> AAEON provides a patch to add the ID.
> https://www.spinics.net/lists/kernel/msg4147351.html
> 
> [Test]
> Testing was done on the Aaeon SSE-OPTI
> 
> [Where problems could occur]
> Simply adding one ID, should not introduce any regressions.
> 
> [Misc]
> This patch is for ODM project and need this to be included as soon as
> possible, so we submit this patch as a sauce patch before upstream merges
> it.
> BTW, Jammy already included this commit when the patch was submitted for
> the SRU the first time.
> 
> AaeonIot (1):
>    UBUNTU: SAUCE: watchdog: f71808e_wdt: Add F81966 support
> 
>   drivers/watchdog/f71808e_wdt.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>   mode change 100644 => 100755 drivers/watchdog/f71808e_wdt.c
>
Stefan Bader Dec. 9, 2021, 10:12 a.m. UTC | #2
On 06.12.21 06:57, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1949063
> 
> [Impact]
> f71808e_wdt watchdog driver can't recognize F81966 chip.
> 
> [Fix]
> AAEON provides a patch to add the ID.
> https://www.spinics.net/lists/kernel/msg4147351.html
> 
> [Test]
> Testing was done on the Aaeon SSE-OPTI
> 
> [Where problems could occur]
> Simply adding one ID, should not introduce any regressions.
> 
> [Misc]
> This patch is for ODM project and need this to be included as soon as
> possible, so we submit this patch as a sauce patch before upstream merges
> it.
> BTW, Jammy already included this commit when the patch was submitted for
> the SRU the first time.
> 
> AaeonIot (1):
>    UBUNTU: SAUCE: watchdog: f71808e_wdt: Add F81966 support
> 
>   drivers/watchdog/f71808e_wdt.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>   mode change 100644 => 100755 drivers/watchdog/f71808e_wdt.c
> 
With the explanation why we need it before upstream:

Acked-by: Stefan Bader <stefan.bader@canonical.com>

Btw, you mention Jammy already has this, yet the bug report has the Jammy task 
still in progress...
Stefan Bader Dec. 10, 2021, 8:46 a.m. UTC | #3
On 06.12.21 06:57, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1949063
> 
> [Impact]
> f71808e_wdt watchdog driver can't recognize F81966 chip.
> 
> [Fix]
> AAEON provides a patch to add the ID.
> https://www.spinics.net/lists/kernel/msg4147351.html
> 
> [Test]
> Testing was done on the Aaeon SSE-OPTI
> 
> [Where problems could occur]
> Simply adding one ID, should not introduce any regressions.
> 
> [Misc]
> This patch is for ODM project and need this to be included as soon as
> possible, so we submit this patch as a sauce patch before upstream merges
> it.
> BTW, Jammy already included this commit when the patch was submitted for
> the SRU the first time.
> 
> AaeonIot (1):
>    UBUNTU: SAUCE: watchdog: f71808e_wdt: Add F81966 support
> 
>   drivers/watchdog/f71808e_wdt.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>   mode change 100644 => 100755 drivers/watchdog/f71808e_wdt.c
> 

Applied to hirsute,impish:linux/master-next. Thanks.

-Stefan