| Message ID | cover.1637066805.git.matti.vaittinen@fi.rohmeurope.com |
|---|---|
| Headers | show |
| Series | Drop ROHM BD70528 support | expand |
On Tue, Nov 16, 2021 at 2:52 PM Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> wrote: > > Drop ROHM BD70528 support > > Unfortunately there has not been a big demand for ROHM BD70528 > IC. The few users I know control PMIC from separate M4-core, > which is not running Linux. I am not aware of any users of this > Linux driver. > > While I did really like this IC and writing the drivers for it, > seems like these drivers are becoming useless burden. So, I see > no point in maintaining them. Let's just drop the drivers if > there is no objections to this series. :( > > The regulator, WDG and power-supply drivers were already dropped. > > The RTC and clk drivers remain in use by few other ROHM IC drivers. > Nevertheless, they are already converted to not depend the BD70528 > defines during previous cycle. > > This series cleans the remaining pieces, GPIO, MFD, dt-bindings and > MAINTAINER entries. The GPIO code uses defines from MFD - but the GPIO > part is also depending on MFD KConfig entry - so there should be no > breakages even if the patches were applied to respective subsystem trees > and were not carried via single tree. FWIW, no objections from me. > --- > > Matti Vaittinen (4): > dt-bindings: mfd: regulator: Drop BD70528 support > gpio: bd70528 Drop BD70528 support > mfd: bd70528: Drop BD70528 support > MAINTAINERS: bd70528: Drop ROHM BD70528 drivers > > .../bindings/mfd/rohm,bd70528-pmic.txt | 102 ----- > .../regulator/rohm,bd70528-regulator.txt | 68 --- > MAINTAINERS | 8 - > drivers/gpio/Kconfig | 11 - > drivers/gpio/Makefile | 1 - > drivers/gpio/gpio-bd70528.c | 230 ----------- > drivers/mfd/Kconfig | 17 - > drivers/mfd/Makefile | 1 - > drivers/mfd/rohm-bd70528.c | 314 -------------- > include/linux/mfd/rohm-bd70528.h | 389 ------------------ > include/linux/mfd/rohm-generic.h | 1 - > 11 files changed, 1142 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt > delete mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd70528-regulator.txt > delete mode 100644 drivers/gpio/gpio-bd70528.c > delete mode 100644 drivers/mfd/rohm-bd70528.c > delete mode 100644 include/linux/mfd/rohm-bd70528.h > > -- > 2.31.1 > > > -- > Matti Vaittinen, Linux device drivers > ROHM Semiconductors, Finland SWDC > Kiviharjunlenkki 1E > 90220 OULU > FINLAND > > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ > Thanks to Simon Glass for the translation =]
On Tue, Nov 16, 2021 at 7:41 PM Matti Vaittinen <mazziesaccount@gmail.com> wrote: > > On 11/16/21 18:10, Andy Shevchenko wrote: > > On Tue, Nov 16, 2021 at 2:52 PM Matti Vaittinen > > <matti.vaittinen@fi.rohmeurope.com> wrote: > >> > >> Drop ROHM BD70528 support > >> > >> Unfortunately there has not been a big demand for ROHM BD70528 > >> IC. The few users I know control PMIC from separate M4-core, > >> which is not running Linux. I am not aware of any users of this > >> Linux driver. > >> > >> While I did really like this IC and writing the drivers for it, > >> seems like these drivers are becoming useless burden. So, I see > >> no point in maintaining them. Let's just drop the drivers if > >> there is no objections to this series. :( > >> > >> The regulator, WDG and power-supply drivers were already dropped. > >> > >> The RTC and clk drivers remain in use by few other ROHM IC drivers. > >> Nevertheless, they are already converted to not depend the BD70528 > >> defines during previous cycle. > >> > >> This series cleans the remaining pieces, GPIO, MFD, dt-bindings and > >> MAINTAINER entries. The GPIO code uses defines from MFD - but the GPIO > >> part is also depending on MFD KConfig entry - so there should be no > >> breakages even if the patches were applied to respective subsystem trees > >> and were not carried via single tree. > > > > FWIW, no objections from me. > > Thanks Andy! > > I see acks from Andu, Bartosz, Lee and Rob. It'd be nice to see ack from > Linus W too - but other than that - I guess this is good to go. Any > preferences regarding the tree(s) that could carry the patches? All via > MFD or each patch merged to the subsystem it fits the best? > > Best Regards > Matti Vaittinen Normally Lee takes MFD patches together with those touching relevant subsystems. Bart
On Tue, Nov 16, 2021 at 7:41 PM Matti Vaittinen <mazziesaccount@gmail.com> wrote: > I see acks from Andu, Bartosz, Lee and Rob. It'd be nice to see ack from > Linus W too - but other than that - I guess this is good to go. Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, 16 Nov 2021, Bartosz Golaszewski wrote: > On Tue, Nov 16, 2021 at 7:41 PM Matti Vaittinen > <mazziesaccount@gmail.com> wrote: > > > > On 11/16/21 18:10, Andy Shevchenko wrote: > > > On Tue, Nov 16, 2021 at 2:52 PM Matti Vaittinen > > > <matti.vaittinen@fi.rohmeurope.com> wrote: > > >> > > >> Drop ROHM BD70528 support > > >> > > >> Unfortunately there has not been a big demand for ROHM BD70528 > > >> IC. The few users I know control PMIC from separate M4-core, > > >> which is not running Linux. I am not aware of any users of this > > >> Linux driver. > > >> > > >> While I did really like this IC and writing the drivers for it, > > >> seems like these drivers are becoming useless burden. So, I see > > >> no point in maintaining them. Let's just drop the drivers if > > >> there is no objections to this series. :( > > >> > > >> The regulator, WDG and power-supply drivers were already dropped. > > >> > > >> The RTC and clk drivers remain in use by few other ROHM IC drivers. > > >> Nevertheless, they are already converted to not depend the BD70528 > > >> defines during previous cycle. > > >> > > >> This series cleans the remaining pieces, GPIO, MFD, dt-bindings and > > >> MAINTAINER entries. The GPIO code uses defines from MFD - but the GPIO > > >> part is also depending on MFD KConfig entry - so there should be no > > >> breakages even if the patches were applied to respective subsystem trees > > >> and were not carried via single tree. > > > > > > FWIW, no objections from me. > > > > Thanks Andy! > > > > I see acks from Andu, Bartosz, Lee and Rob. It'd be nice to see ack from > > Linus W too - but other than that - I guess this is good to go. Any > > preferences regarding the tree(s) that could carry the patches? All via > > MFD or each patch merged to the subsystem it fits the best? > > > > Best Regards > > Matti Vaittinen > > Normally Lee takes MFD patches together with those touching relevant subsystems. Yep, it's on the list.
On Tue, 16 Nov 2021, Matti Vaittinen wrote: > The only known BD70528 use-cases are such that the PMIC is controlled > from separate MCU which is not running Linux. I am not aware of > any Linux driver users. Furthermore, it seems there is no demand for > this IC. Let's ease the maintenance burden and drop the driver. We can > always add it back if there is sudden need for it. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > Acked-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/mfd/Kconfig | 17 -- > drivers/mfd/Makefile | 1 - > drivers/mfd/rohm-bd70528.c | 314 ------------------------- > include/linux/mfd/rohm-bd70528.h | 389 ------------------------------- > include/linux/mfd/rohm-generic.h | 1 - > 5 files changed, 722 deletions(-) > delete mode 100644 drivers/mfd/rohm-bd70528.c > delete mode 100644 include/linux/mfd/rohm-bd70528.h Applied, thanks.
On Tue, 16 Nov 2021, Matti Vaittinen wrote: > The only known BD70528 use-cases are such that the PMIC is controlled > from separate MCU which is not running Linux. I am not aware of > any Linux driver users. Furthermore, it seems there is no demand for > this IC. Let's ease the maintenance burden and drop the driver. We can > always add it back if there is sudden need for it. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > drivers/gpio/Kconfig | 11 -- > drivers/gpio/Makefile | 1 - > drivers/gpio/gpio-bd70528.c | 230 ------------------------------------ > 3 files changed, 242 deletions(-) > delete mode 100644 drivers/gpio/gpio-bd70528.c Applied, thanks.
On Tue, 16 Nov 2021, Matti Vaittinen wrote: > The only known BD70528 use-cases are such that the PMIC is controlled > from separate MCU which is not running Linux. I am not aware of > any Linux driver users. Furthermore, it seems there is no demand for > this IC. > > Ease the maintenance burden and drop the driver. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > MAINTAINERS | 8 -------- > 1 file changed, 8 deletions(-) Applied, thanks.