Message ID | 20211111040631.21262-5-matt@traverse.com.au |
---|---|
State | Accepted |
Commit | fdb4a5fcd7458d6cf075d908a499f822a9787fac |
Delegated to: | Ilias Apalodimas |
Headers | show |
Series | drivers: tpm: Fix Atmel/Microchip TPMv1.2 issues | expand |
On Wed, 10 Nov 2021 at 21:06, Mathew McBride <matt@traverse.com.au> wrote: > > This driver was broken due to an empty offset byte being prepended > at the start of every transmission. > > The hardware does not mimic an EEPROM device with registers so > an offset byte is not required. > > Signed-off-by: Mathew McBride <matt@traverse.com.au> > Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > --- > drivers/tpm/tpm_atmel_twi.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Simon Glass <sjg@chromium.org>
Hi Simon, On Thu, 25 Nov 2021 at 02:12, Simon Glass <sjg@chromium.org> wrote: > > On Wed, 10 Nov 2021 at 21:06, Mathew McBride <matt@traverse.com.au> wrote: > > > > This driver was broken due to an empty offset byte being prepended > > at the start of every transmission. > > > > The hardware does not mimic an EEPROM device with registers so > > an offset byte is not required. > > > > Signed-off-by: Mathew McBride <matt@traverse.com.au> > > Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > > --- > > drivers/tpm/tpm_atmel_twi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > Reviewed-by: Simon Glass <sjg@chromium.org> Thanks those got merged a week ago into master!
diff --git a/drivers/tpm/tpm_atmel_twi.c b/drivers/tpm/tpm_atmel_twi.c index 4ff4cf4cd4..71b101406d 100644 --- a/drivers/tpm/tpm_atmel_twi.c +++ b/drivers/tpm/tpm_atmel_twi.c @@ -131,6 +131,7 @@ static int tpm_atmel_twi_xfer(struct udevice *dev, static int tpm_atmel_twi_probe(struct udevice *dev) { + i2c_set_chip_offset_len(dev, 0); return 0; }