| Message ID | 20211122222440.21177-3-j@jannau.net |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Apple Arm patform device tree and bindings fixes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 20 lines checked |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
> From: Janne Grunau <j@jannau.net> > Date: Mon, 22 Nov 2021 23:24:39 +0100 > > The intention was to have a SoC-specific and base compatible string > to allow forward compatibility and SoC specific quirks, > > Fixes: df7c4a8c1b47 ("dt-bindings: i2c: Add Apple I2C controller bindings") > Signed-off-by: Janne Grunau <j@jannau.net> > Cc: Mark Kettenis <kettenis@openbsd.org> > Reviewed-by: Sven Peter <sven@svenpeter.dev> Reviewed-by: Mark Kettenis <kettenis@openbsd.org> > --- > Documentation/devicetree/bindings/i2c/apple,i2c.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > index 22fc8483256f..82b953181a52 100644 > --- a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > @@ -20,9 +20,9 @@ allOf: > > properties: > compatible: > - enum: > - - apple,t8103-i2c > - - apple,i2c > + items: > + - const: apple,t8103-i2c > + - const: apple,i2c > > reg: > maxItems: 1 > @@ -51,7 +51,7 @@ unevaluatedProperties: false > examples: > - | > i2c@35010000 { > - compatible = "apple,t8103-i2c"; > + compatible = "apple,t8103-i2c", "apple,i2c"; > reg = <0x35010000 0x4000>; > interrupt-parent = <&aic>; > interrupts = <0 627 4>; > -- > 2.34.0 > >
On Mon, Nov 22, 2021 at 11:24:39PM +0100, Janne Grunau wrote: > The intention was to have a SoC-specific and base compatible string > to allow forward compatibility and SoC specific quirks, > > Fixes: df7c4a8c1b47 ("dt-bindings: i2c: Add Apple I2C controller bindings") > Signed-off-by: Janne Grunau <j@jannau.net> > Cc: Mark Kettenis <kettenis@openbsd.org> > Reviewed-by: Sven Peter <sven@svenpeter.dev> Acked-by: Wolfram Sang <wsa@kernel.org>
On Mon, 22 Nov 2021 23:24:39 +0100, Janne Grunau wrote: > The intention was to have a SoC-specific and base compatible string > to allow forward compatibility and SoC specific quirks, > > Fixes: df7c4a8c1b47 ("dt-bindings: i2c: Add Apple I2C controller bindings") > Signed-off-by: Janne Grunau <j@jannau.net> > Cc: Mark Kettenis <kettenis@openbsd.org> > Reviewed-by: Sven Peter <sven@svenpeter.dev> > --- > Documentation/devicetree/bindings/i2c/apple,i2c.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml index 22fc8483256f..82b953181a52 100644 --- a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml @@ -20,9 +20,9 @@ allOf: properties: compatible: - enum: - - apple,t8103-i2c - - apple,i2c + items: + - const: apple,t8103-i2c + - const: apple,i2c reg: maxItems: 1 @@ -51,7 +51,7 @@ unevaluatedProperties: false examples: - | i2c@35010000 { - compatible = "apple,t8103-i2c"; + compatible = "apple,t8103-i2c", "apple,i2c"; reg = <0x35010000 0x4000>; interrupt-parent = <&aic>; interrupts = <0 627 4>;
The intention was to have a SoC-specific and base compatible string to allow forward compatibility and SoC specific quirks, Fixes: df7c4a8c1b47 ("dt-bindings: i2c: Add Apple I2C controller bindings") Signed-off-by: Janne Grunau <j@jannau.net> Cc: Mark Kettenis <kettenis@openbsd.org> Reviewed-by: Sven Peter <sven@svenpeter.dev> --- Documentation/devicetree/bindings/i2c/apple,i2c.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)