| Message ID | 20211116195627.482400-1-cascardo@canonical.com |
|---|---|
| Headers | show |
| Series | LP: #1950239 - creat09 failing on XFS | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> The Bionic backports (patches 3 & 4) look large and invasive until you note the structure tag name changes don't really change the overall logic, rather its just changing names and consolidating some tags. On 11/16/21 12:56 PM, Thadeu Lima de Souza Cascardo wrote: > BugLink: https://bugs.launchpad.net/bugs/1950239 > > [Impact] > setgid files may be created on setgid directories owned by the directory > group by users not belonging to that group. That is restricted to XFS. > > [Fix/Backport] > The fix for 5.11 and 5.10 kernels is one simple commit with a minor > backport conflict fixup on 5.10. > > 5.4, on the other hand, required other 3 pre-requisites, which could be > picked cleanly. On 4.15, however, they needed a lot of mangling and fixes. > > [Test case] > creat09 LTP test case. > > [Potential regression] > The creation of files on XFS may have the wrong attributes. Also, on 5.4 > and 4.15, the potential regression is larger, also affecting quota, > statistics and other interfaces where uid, gid and projid are exposed. >
On 16.11.21 20:56, Thadeu Lima de Souza Cascardo wrote: > BugLink: https://bugs.launchpad.net/bugs/1950239 > > [Impact] > setgid files may be created on setgid directories owned by the directory > group by users not belonging to that group. That is restricted to XFS. > > [Fix/Backport] > The fix for 5.11 and 5.10 kernels is one simple commit with a minor > backport conflict fixup on 5.10. > > 5.4, on the other hand, required other 3 pre-requisites, which could be > picked cleanly. On 4.15, however, they needed a lot of mangling and fixes. > > [Test case] > creat09 LTP test case. > > [Potential regression] > The creation of files on XFS may have the wrong attributes. Also, on 5.4 > and 4.15, the potential regression is larger, also affecting quota, > statistics and other interfaces where uid, gid and projid are exposed. > OK, assuming this has been at least quick tested and I really do not want to know the details... Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 16.11.21 20:56, Thadeu Lima de Souza Cascardo wrote: > BugLink: https://bugs.launchpad.net/bugs/1950239 > > [Impact] > setgid files may be created on setgid directories owned by the directory > group by users not belonging to that group. That is restricted to XFS. > > [Fix/Backport] > The fix for 5.11 and 5.10 kernels is one simple commit with a minor > backport conflict fixup on 5.10. > > 5.4, on the other hand, required other 3 pre-requisites, which could be > picked cleanly. On 4.15, however, they needed a lot of mangling and fixes. > > [Test case] > creat09 LTP test case. > > [Potential regression] > The creation of files on XFS may have the wrong attributes. Also, on 5.4 > and 4.15, the potential regression is larger, also affecting quota, > statistics and other interfaces where uid, gid and projid are exposed. > Applied to bionic,focal,hirsute:linux/master-next. Thanks. -Stefan