[1/1] ARM: tegra: paz00: Fix board pinmux table.

This fix updates the CDEV1 pinmux for the paz00 board to be as in the
Harmony board. Paz00 board is originally based on Harmony design.

Signed-off-by: Leon Romanovsky <leon@leon.nu>
---
 arch/arm/mach-tegra/board-paz00-pinmux.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Hi Leon,

Am Samstag 15 Oktober 2011, 17:18:33 schrieb Leon Romanovsky:
> This fix updates the CDEV1 pinmux for the paz00 board to be as in the
> Harmony board. Paz00 board is originally based on Harmony design.

the fact that this patch makes sound work on paz00 does not necessary mean
that this is the "right thing" to do. First, the initial state should be
TRISTATE, because sound layer should switch between NORMAL/TRISTATE 
automaticly to save some power. Second, Android has TEGRA_PUPD_PULL_DOWN 
with sound working and I didn't found out yet why this also works.

So there is something strange going on and we should first find out what
it is. Furthermore, there is no codec (ALC5632) and no glue for paz00 yet 
in the mainline kernel (and of course no board support for it) so this can 
still wait IMHO.

I will include your patch in the series which will add sound support once
the fog has lifted a bit.

Thanks

Marc

> Signed-off-by: Leon Romanovsky <leon@leon.nu>
> ---
>  arch/arm/mach-tegra/board-paz00-pinmux.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-tegra/board-paz00-pinmux.c b/arch/arm/mach-tegra/board-paz00-pinmux.c
> index bdd2627..7de8182 100644
> --- a/arch/arm/mach-tegra/board-paz00-pinmux.c
> +++ b/arch/arm/mach-tegra/board-paz00-pinmux.c
> @@ -27,7 +27,7 @@ static struct tegra_pingroup_config paz00_pinmux[] = {
>  	{TEGRA_PINGROUP_ATC,   TEGRA_MUX_GMI,           TEGRA_PUPD_NORMAL,    TEGRA_TRI_NORMAL},
>  	{TEGRA_PINGROUP_ATD,   TEGRA_MUX_GMI,           TEGRA_PUPD_NORMAL,    TEGRA_TRI_NORMAL},
>  	{TEGRA_PINGROUP_ATE,   TEGRA_MUX_GMI,           TEGRA_PUPD_NORMAL,    TEGRA_TRI_NORMAL},
> -	{TEGRA_PINGROUP_CDEV1, TEGRA_MUX_PLLA_OUT,      TEGRA_PUPD_PULL_DOWN, TEGRA_TRI_TRISTATE},
> +	{TEGRA_PINGROUP_CDEV1, TEGRA_MUX_PLLA_OUT,      TEGRA_PUPD_NORMAL,    TEGRA_TRI_NORMAL},
>  	{TEGRA_PINGROUP_CDEV2, TEGRA_MUX_PLLP_OUT4,     TEGRA_PUPD_PULL_DOWN, TEGRA_TRI_NORMAL},
>  	{TEGRA_PINGROUP_CRTP,  TEGRA_MUX_CRT,           TEGRA_PUPD_NORMAL,    TEGRA_TRI_TRISTATE},
>  	{TEGRA_PINGROUP_CSUS,  TEGRA_MUX_PLLC_OUT1,     TEGRA_PUPD_PULL_DOWN, TEGRA_TRI_TRISTATE},
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

> Am Samstag 15 Oktober 2011, 17:18:33 schrieb Leon Romanovsky:
> > This fix updates the CDEV1 pinmux for the paz00 board to be as in the
> > Harmony board. Paz00 board is originally based on Harmony design.
>
> the fact that this patch makes sound work on paz00 does not necessary mean
> that this is the "right thing" to do. First, the initial state should be
> TRISTATE, because sound layer should switch between NORMAL/TRISTATE
> automaticly to save some power. Second, Android has TEGRA_PUPD_PULL_DOWN
> with sound working and I didn't found out yet why this also works.

I already said before, but will say again. Our board has many commons
to the Harmony board, so our reference is
arch/arm/mach-tegra/board-harmony-pinmux.c
http://git.kernel.org/?p=linux/kernel/git/olof/tegra.git;a=history;f=arch/arm/mach-tegra/board-harmony-pinmux.c;hb=103e1e14441ea86454921cdaf552c9f5c1f7c7c1
In the initial commit (42a7bf4d2686145bea03ff9b87d83868cc514f47)
pushed by Colin, the CDEV1 indeed has TEGRA_PUPD_PULL_DOWN and
TEGRA_TRI_TRISTATE
(http://git.kernel.org/?p=linux/kernel/git/olof/tegra.git;a=blob;f=arch/arm/mach-tegra/board-harmony-pinmux.c;h=50b15d500cacc73817258202178b0b79fc42478b;hb=42a7bf4d2686145bea03ff9b87d83868cc514f47#l28),
but later in the commit (ef2b1a0f1eb299c2d00addfee3a2631395d9bdb5)
pushed by Stephen, the CDEV1 was changed.

I did the same.

>
> So there is something strange going on and we should first find out what
> it is. Furthermore, there is no codec (ALC5632) and no glue for paz00 yet
> in the mainline kernel (and of course no board support for it) so this can
> still wait IMHO.

I have a different view on it. For me, everything that fixes incorrect
behavior and doesn't brake anything, must be included as soon as
possible.possible.

>
> I will include your patch in the series which will add sound support once
> the fog has lifted a bit.
>
> Thanks
>
> Marc
>
> > Signed-off-by: Leon Romanovsky <leon@leon.nu>
> > ---
> >  arch/arm/mach-tegra/board-paz00-pinmux.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-tegra/board-paz00-pinmux.c b/arch/arm/mach-tegra/board-paz00-pinmux.c
> > index bdd2627..7de8182 100644
> > --- a/arch/arm/mach-tegra/board-paz00-pinmux.c
> > +++ b/arch/arm/mach-tegra/board-paz00-pinmux.c
> > @@ -27,7 +27,7 @@ static struct tegra_pingroup_config paz00_pinmux[] = {
> >       {TEGRA_PINGROUP_ATC,   TEGRA_MUX_GMI,           TEGRA_PUPD_NORMAL,    TEGRA_TRI_NORMAL},
> >       {TEGRA_PINGROUP_ATD,   TEGRA_MUX_GMI,           TEGRA_PUPD_NORMAL,    TEGRA_TRI_NORMAL},
> >       {TEGRA_PINGROUP_ATE,   TEGRA_MUX_GMI,           TEGRA_PUPD_NORMAL,    TEGRA_TRI_NORMAL},
> > -     {TEGRA_PINGROUP_CDEV1, TEGRA_MUX_PLLA_OUT,      TEGRA_PUPD_PULL_DOWN, TEGRA_TRI_TRISTATE},
> > +     {TEGRA_PINGROUP_CDEV1, TEGRA_MUX_PLLA_OUT,      TEGRA_PUPD_NORMAL,    TEGRA_TRI_NORMAL},
> >       {TEGRA_PINGROUP_CDEV2, TEGRA_MUX_PLLP_OUT4,     TEGRA_PUPD_PULL_DOWN, TEGRA_TRI_NORMAL},
> >       {TEGRA_PINGROUP_CRTP,  TEGRA_MUX_CRT,           TEGRA_PUPD_NORMAL,    TEGRA_TRI_TRISTATE},
> >       {TEGRA_PINGROUP_CSUS,  TEGRA_MUX_PLLC_OUT1,     TEGRA_PUPD_PULL_DOWN, TEGRA_TRI_TRISTATE},
> >
>



--
Leon Romanovsky | Independent Linux Consultant
        www.leon.nu | leon@leon.nu
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html