| Message ID | 20211117113800.260741-1-robert.foss@linaro.org |
|---|---|
| Headers | show |
| Series | Remove clock-lanes DT property from CAMSS | expand |
Hi Robert, small nitpick: The subject would be more clear with "arm64: dts: qcom: apq8016-sbc: ..." instead of "msm8916: ..." like in your sdm845-db845c patch, since only apq8016-sbc is modified. On Wed, Nov 17, 2021 at 12:37:59PM +0100, Robert Foss wrote: > The clock-lanes property is no longer used as it is not programmable by > the CSIPHY hardware block of Qcom ISPs and should be removed. > > Signed-off-by: Robert Foss <robert.foss@linaro.org> > --- > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 -- Can you rebase this on 5.16-rc1? All of apq8016-sbc.dtsi is now in apq8016-sbc.dts (the extra dtsi did not have any good use). Thanks, Stephan
Thanks Stephan. On Wed, 17 Nov 2021 at 13:42, Stephan Gerhold <stephan@gerhold.net> wrote: > > Hi Robert, > > small nitpick: The subject would be more clear with > "arm64: dts: qcom: apq8016-sbc: ..." instead of "msm8916: ..." like in > your sdm845-db845c patch, since only apq8016-sbc is modified. Will do. > > On Wed, Nov 17, 2021 at 12:37:59PM +0100, Robert Foss wrote: > > The clock-lanes property is no longer used as it is not programmable by > > the CSIPHY hardware block of Qcom ISPs and should be removed. > > > > Signed-off-by: Robert Foss <robert.foss@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 -- > > Can you rebase this on 5.16-rc1? All of apq8016-sbc.dtsi is now in > apq8016-sbc.dts (the extra dtsi did not have any good use). Ack. > > Thanks, > Stephan
Changes since v1: - Rob: Instead of documenting and fixing the use of the clock-lanes property, remove it, since it is is not programmable and therefore shouldn't be exposed in the DT. Robert Foss (4): media: camss: csiphy: Move to hardcode CSI Clock Lane number media: dt-bindings: media: camss: Remove clock-lane property arm64: dts: qcom: msm8916: Remove clock-lanes property from &camss node arm64: dts: qcom: sdm845-db845c: Remove clock-lanes property from &camss node .../bindings/media/qcom,msm8916-camss.yaml | 10 --------- .../bindings/media/qcom,msm8996-camss.yaml | 20 ------------------ .../bindings/media/qcom,sdm660-camss.yaml | 20 ------------------ .../bindings/media/qcom,sdm845-camss.yaml | 17 --------------- arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 -- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 3 --- .../qcom/camss/camss-csiphy-2ph-1-0.c | 19 +++++++++++++++-- .../qcom/camss/camss-csiphy-3ph-1-0.c | 17 ++++++++++++++- .../media/platform/qcom/camss/camss-csiphy.c | 21 +------------------ .../media/platform/qcom/camss/camss-csiphy.h | 7 +++++++ 10 files changed, 41 insertions(+), 95 deletions(-)