mbox series

[u-boot-marvell,00/11] Another kwbimage series

Message ID 20211108171251.25382-1-kabel@kernel.org
Headers show
Series Another kwbimage series | expand

Message

Marek Behún Nov. 8, 2021, 5:12 p.m. UTC
From: Marek Behún <marek.behun@nic.cz>

Hi Stefan,

Pali has prepared another series of patches for kwbimage, I have reviewed
them.

Marek

Pali Rohár (11):
  tools: kwbimage: Add support for new commands UART_PORT and UART_MPP
  tools: kwbimage: Explicitly set version also for kwbimage v0
  tools: kwbimage: Set BOOT_FROM by default to SPI
  tools: kwbimage: Fix validation of kwbimage v0
  tools: kwbimage: Remove unused enums and prototypes
  tools: kwbimage: Align final UART image to 128 bytes
  tools: kwbimage: Do not put final image padding to the image data size
  tools: kwbimage: Align kwbimage header to proper size
  tools: kwbimage: Fill the real header size into the main header
  tools: kwbimage: Properly calculate and align kwbimage v0 header size
  tools: kwbimage: Properly set srcaddr in kwbimage v0

 tools/kwbimage.c | 250 ++++++++++++++++++++++++++++++++---------------
 tools/kwbimage.h |  25 +----
 2 files changed, 174 insertions(+), 101 deletions(-)

Comments

Stefan Roese Nov. 10, 2021, 5:41 a.m. UTC | #1
Hi Marek,
Hi Pali,

On 08.11.21 18:12, Marek Behún wrote:
> From: Marek Behún <marek.behun@nic.cz>
> 
> Hi Stefan,
> 
> Pali has prepared another series of patches for kwbimage, I have reviewed
> them.

Thanks. Just checking with you: Does this series include / supersede
these 2 patches:

http://patchwork.ozlabs.org/project/uboot/patch/20211105222958.17034-1-pali@kernel.org/
http://patchwork.ozlabs.org/project/uboot/patch/20211105223042.17104-1-pali@kernel.org/

Or are then still "open" for pulling as well?

Thanks,
Stefan

> Marek
> 
> Pali Rohár (11):
>    tools: kwbimage: Add support for new commands UART_PORT and UART_MPP
>    tools: kwbimage: Explicitly set version also for kwbimage v0
>    tools: kwbimage: Set BOOT_FROM by default to SPI
>    tools: kwbimage: Fix validation of kwbimage v0
>    tools: kwbimage: Remove unused enums and prototypes
>    tools: kwbimage: Align final UART image to 128 bytes
>    tools: kwbimage: Do not put final image padding to the image data size
>    tools: kwbimage: Align kwbimage header to proper size
>    tools: kwbimage: Fill the real header size into the main header
>    tools: kwbimage: Properly calculate and align kwbimage v0 header size
>    tools: kwbimage: Properly set srcaddr in kwbimage v0
> 
>   tools/kwbimage.c | 250 ++++++++++++++++++++++++++++++++---------------
>   tools/kwbimage.h |  25 +----
>   2 files changed, 174 insertions(+), 101 deletions(-)
> 

Viele Grüße,
Stefan Roese
Pali Rohár Nov. 10, 2021, 8:19 a.m. UTC | #2
On Wednesday 10 November 2021 06:41:01 Stefan Roese wrote:
> Hi Marek,
> Hi Pali,
> 
> On 08.11.21 18:12, Marek Behún wrote:
> > From: Marek Behún <marek.behun@nic.cz>
> > 
> > Hi Stefan,
> > 
> > Pali has prepared another series of patches for kwbimage, I have reviewed
> > them.
> 
> Thanks. Just checking with you: Does this series include / supersede
> these 2 patches:
> 
> http://patchwork.ozlabs.org/project/uboot/patch/20211105222958.17034-1-pali@kernel.org/
> http://patchwork.ozlabs.org/project/uboot/patch/20211105223042.17104-1-pali@kernel.org/
> 
> Or are then still "open" for pulling as well?

Above two patches are for kwboot. This patch series is for
mkimage/kwbimage. So they are for different tools, independent and above
two patches are still "open", waiting for review.

> Thanks,
> Stefan
> 
> > Marek
> > 
> > Pali Rohár (11):
> >    tools: kwbimage: Add support for new commands UART_PORT and UART_MPP
> >    tools: kwbimage: Explicitly set version also for kwbimage v0
> >    tools: kwbimage: Set BOOT_FROM by default to SPI
> >    tools: kwbimage: Fix validation of kwbimage v0
> >    tools: kwbimage: Remove unused enums and prototypes
> >    tools: kwbimage: Align final UART image to 128 bytes
> >    tools: kwbimage: Do not put final image padding to the image data size
> >    tools: kwbimage: Align kwbimage header to proper size
> >    tools: kwbimage: Fill the real header size into the main header
> >    tools: kwbimage: Properly calculate and align kwbimage v0 header size
> >    tools: kwbimage: Properly set srcaddr in kwbimage v0
> > 
> >   tools/kwbimage.c | 250 ++++++++++++++++++++++++++++++++---------------
> >   tools/kwbimage.h |  25 +----
> >   2 files changed, 174 insertions(+), 101 deletions(-)
> > 
> 
> Viele Grüße,
> Stefan Roese
> 
> -- 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
Stefan Roese Nov. 10, 2021, 1:52 p.m. UTC | #3
On 08.11.21 18:12, Marek Behún wrote:
> From: Marek Behún <marek.behun@nic.cz>
> 
> Hi Stefan,
> 
> Pali has prepared another series of patches for kwbimage, I have reviewed
> them.
> 
> Marek
> 
> Pali Rohár (11):
>    tools: kwbimage: Add support for new commands UART_PORT and UART_MPP
>    tools: kwbimage: Explicitly set version also for kwbimage v0
>    tools: kwbimage: Set BOOT_FROM by default to SPI
>    tools: kwbimage: Fix validation of kwbimage v0
>    tools: kwbimage: Remove unused enums and prototypes
>    tools: kwbimage: Align final UART image to 128 bytes
>    tools: kwbimage: Do not put final image padding to the image data size
>    tools: kwbimage: Align kwbimage header to proper size
>    tools: kwbimage: Fill the real header size into the main header
>    tools: kwbimage: Properly calculate and align kwbimage v0 header size
>    tools: kwbimage: Properly set srcaddr in kwbimage v0
> 
>   tools/kwbimage.c | 250 ++++++++++++++++++++++++++++++++---------------
>   tools/kwbimage.h |  25 +----
>   2 files changed, 174 insertions(+), 101 deletions(-)
> 

Applied to u-boot-marvell/master

Thanks,
Stefan