| Message ID | 20211029004102.1719211-1-rep.dot.nop@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Bump required minimum DejaGnu version to 1.5.3 | expand |
On Fri, Oct 29, 2021 at 2:42 AM Bernhard Reutner-Fischer via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > From: Bernhard Reutner-Fischer <aldot@gcc.gnu.org> > > Bump required DejaGnu version to 1.5.3 (or later). > Ok for trunk? OK. Thanks, Richard. > gcc/ChangeLog: > > * doc/install.texi: Bump required minimum DejaGnu version. > --- > gcc/doc/install.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi > index 36c8280d7da..094469b9a4e 100644 > --- a/gcc/doc/install.texi > +++ b/gcc/doc/install.texi > @@ -452,7 +452,7 @@ Necessary when modifying @command{gperf} input files, e.g.@: > @file{gcc/cp/cfns.gperf} to regenerate its associated header file, e.g.@: > @file{gcc/cp/cfns.h}. > > -@item DejaGnu 1.4.4 > +@item DejaGnu version 1.5.3 (or later) > @itemx Expect > @itemx Tcl > @c Once Tcl 8.5 or higher is required, remove any obsolete > -- > 2.33.0 >
On Fri, Oct 29, 2021 at 09:32:21AM +0200, Richard Biener via Gcc-patches wrote: > On Fri, Oct 29, 2021 at 2:42 AM Bernhard Reutner-Fischer via > Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > > > From: Bernhard Reutner-Fischer <aldot@gcc.gnu.org> > > > > Bump required DejaGnu version to 1.5.3 (or later). > > Ok for trunk? > > OK. If we really want to require such a new version of DejaGnu (most machines I use have 1.5.1 or older), can we include it with GCC please? Segher
On 11/4/21 12:55, Segher Boessenkool wrote: > On Fri, Oct 29, 2021 at 09:32:21AM +0200, Richard Biener via Gcc-patches wrote: >> On Fri, Oct 29, 2021 at 2:42 AM Bernhard Reutner-Fischer via >> Gcc-patches <gcc-patches@gcc.gnu.org> wrote: >>> >>> From: Bernhard Reutner-Fischer <aldot@gcc.gnu.org> >>> >>> Bump required DejaGnu version to 1.5.3 (or later). >>> Ok for trunk? >> >> OK. > > If we really want to require such a new version of DejaGnu (most > machines I use have 1.5.1 or older), can we include it with GCC please? Do you mean in contrib/download_prerequisites? Note the version 1.5.1 is 8 years old, what legacy system do you use that has such an old version? Martin > > > Segher >
On Thu, Nov 4, 2021 at 12:57 PM Segher Boessenkool <segher@kernel.crashing.org> wrote: > > On Fri, Oct 29, 2021 at 09:32:21AM +0200, Richard Biener via Gcc-patches wrote: > > On Fri, Oct 29, 2021 at 2:42 AM Bernhard Reutner-Fischer via > > Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > > > > > From: Bernhard Reutner-Fischer <aldot@gcc.gnu.org> > > > > > > Bump required DejaGnu version to 1.5.3 (or later). > > > Ok for trunk? > > > > OK. > > If we really want to require such a new version of DejaGnu (most > machines I use have 1.5.1 or older), can we include it with GCC please? I checked before approving that all regularly supported SLES releases have 1.5.3 or newer (in fact they even have 1.6+). Only before SLE12 SP2 you had the chance to run into 1.4.4. I guess you run into old versions on big-endian ppc-linux which tend to be quite old if you rely on enterprise OS? Richard. > > Segher
On Thu, 4 Nov 2021 at 12:42, Richard Biener via Gcc <gcc@gcc.gnu.org> wrote: > > On Thu, Nov 4, 2021 at 12:57 PM Segher Boessenkool > <segher@kernel.crashing.org> wrote: > > > > On Fri, Oct 29, 2021 at 09:32:21AM +0200, Richard Biener via Gcc-patches wrote: > > > On Fri, Oct 29, 2021 at 2:42 AM Bernhard Reutner-Fischer via > > > Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > > > > > > > From: Bernhard Reutner-Fischer <aldot@gcc.gnu.org> > > > > > > > > Bump required DejaGnu version to 1.5.3 (or later). > > > > Ok for trunk? > > > > > > OK. > > > > If we really want to require such a new version of DejaGnu (most > > machines I use have 1.5.1 or older), can we include it with GCC please? > > I checked before approving that all regularly supported SLES releases have > 1.5.3 or newer (in fact they even have 1.6+). Only before SLE12 SP2 you > had the chance to run into 1.4.4. I guess you run into old versions on > big-endian ppc-linux which tend to be quite old if you rely on enterprise OS? Like most of the ones in the compile farm, which run CentOS 7 and have 1.5.1. I've installed a newer version in /opt/cfarm on most of the machines that need it. I'm still in favour of updating the minimum version, because otherwise we have FAILs for correct tests. The old version is just not good enough.
On Thu, Nov 04, 2021 at 01:22:24PM +0100, Martin Liška wrote: > On 11/4/21 12:55, Segher Boessenkool wrote: > >On Fri, Oct 29, 2021 at 09:32:21AM +0200, Richard Biener via Gcc-patches > >wrote: > >>On Fri, Oct 29, 2021 at 2:42 AM Bernhard Reutner-Fischer via > >>Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > >>> > >>>From: Bernhard Reutner-Fischer <aldot@gcc.gnu.org> > >>> > >>>Bump required DejaGnu version to 1.5.3 (or later). > >>>Ok for trunk? > >> > >>OK. > > > >If we really want to require such a new version of DejaGnu (most > >machines I use have 1.5.1 or older), can we include it with GCC please? > > Do you mean in contrib/download_prerequisites? I was thinking as actual code, so we can make modifications where we need to / want to as well. But your idea is much less contentious :-) > Note the version 1.5.1 is 8 years old, what legacy system do you use that > has such > an old version? CentOS 7. Some of those systems cannot run CentOS 8. And CentOS 8 will reach EoL in less than two months, and CentOS Stream is not an option at all (and even if it were, it cannot work on many of the machines). Everything else on CentOS 7 is supported by GCC (it is the oldest supported for pretty much everything, but still). It would be bad for DejaGnu to be the limiting factor :-/ Segher
On Thu, Nov 4, 2021 at 8:12 PM Segher Boessenkool <segher@kernel.crashing.org> wrote: > > On Thu, Nov 04, 2021 at 01:22:24PM +0100, Martin Liška wrote: > > On 11/4/21 12:55, Segher Boessenkool wrote: > > >On Fri, Oct 29, 2021 at 09:32:21AM +0200, Richard Biener via Gcc-patches > > >wrote: > > >>On Fri, Oct 29, 2021 at 2:42 AM Bernhard Reutner-Fischer via > > >>Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > >>> > > >>>From: Bernhard Reutner-Fischer <aldot@gcc.gnu.org> > > >>> > > >>>Bump required DejaGnu version to 1.5.3 (or later). > > >>>Ok for trunk? > > >> > > >>OK. > > > > > >If we really want to require such a new version of DejaGnu (most > > >machines I use have 1.5.1 or older), can we include it with GCC please? > > > > Do you mean in contrib/download_prerequisites? > > I was thinking as actual code, so we can make modifications where we > need to / want to as well. But your idea is much less contentious :-) > > > Note the version 1.5.1 is 8 years old, what legacy system do you use that > > has such > > an old version? > > CentOS 7. Some of those systems cannot run CentOS 8. And CentOS 8 will > reach EoL in less than two months, and CentOS Stream is not an option at > all (and even if it were, it cannot work on many of the machines). > > Everything else on CentOS 7 is supported by GCC (it is the oldest > supported for pretty much everything, but still). It would be bad for > DejaGnu to be the limiting factor :-/ So just contribute updated dejagnu packages to CentOS 7 "backports" or whatever means exists there? Btw, openSUSE Tumbleweed still has ppc64 (non-le) support and I bet Debian has that as well. Richard. > > Segher
On Fri, 5 Nov 2021 at 09:35, Richard Biener via Gcc <gcc@gcc.gnu.org> wrote: > So just contribute updated dejagnu packages to CentOS 7 "backports" or > whatever means exists there? Yes, we could add a newer dejagnu to EPEL.
diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index 36c8280d7da..094469b9a4e 100644 --- a/gcc/doc/install.texi +++ b/gcc/doc/install.texi @@ -452,7 +452,7 @@ Necessary when modifying @command{gperf} input files, e.g.@: @file{gcc/cp/cfns.gperf} to regenerate its associated header file, e.g.@: @file{gcc/cp/cfns.h}. -@item DejaGnu 1.4.4 +@item DejaGnu version 1.5.3 (or later) @itemx Expect @itemx Tcl @c Once Tcl 8.5 or higher is required, remove any obsolete
From: Bernhard Reutner-Fischer <aldot@gcc.gnu.org> Bump required DejaGnu version to 1.5.3 (or later). Ok for trunk? gcc/ChangeLog: * doc/install.texi: Bump required minimum DejaGnu version. --- gcc/doc/install.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)