mbox series

[SRU,Unstable/OEM-5.13/OEM-5.14,0/1] Fix missing recording from headset mic

Message ID 20211007165323.281865-1-kai.heng.feng@canonical.com
Headers show
Series Fix missing recording from headset mic | expand

Message

Kai-Heng Feng Oct. 7, 2021, 4:53 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1946383

[Impact]
When using headset mic to record, the beginning of 2 seconds period is
not recorded.

[Fix]
Skip shutup routines for the codec. The shutup routines somehow
interferes headset mic recording.

[Test]
External headset mic no longer records blank period once the patch is
applied.

[Where problems could occur]
Shutup routines are mainly for outputs like headphone and speakers.
Since the patch is using a rather generic match for both ALC236 and
ALC256, many systems might start to observe pop sound from the audio
outputs.

Kailang Yang (1):
  ALSA: hda/realtek - ALC236 headset MIC recording issue

 sound/pci/hda/patch_realtek.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Timo Aaltonen Oct. 7, 2021, 5:22 p.m. UTC | #1 
On 7.10.2021 19.53, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1946383
> 
> [Impact]
> When using headset mic to record, the beginning of 2 seconds period is
> not recorded.
> 
> [Fix]
> Skip shutup routines for the codec. The shutup routines somehow
> interferes headset mic recording.
> 
> [Test]
> External headset mic no longer records blank period once the patch is
> applied.
> 
> [Where problems could occur]
> Shutup routines are mainly for outputs like headphone and speakers.
> Since the patch is using a rather generic match for both ALC236 and
> ALC256, many systems might start to observe pop sound from the audio
> outputs.
> 
> Kailang Yang (1):
>    ALSA: hda/realtek - ALC236 headset MIC recording issue
> 
>   sound/pci/hda/patch_realtek.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 

applied to oem-5.13 and oem-5.14, thanks
Andrea Righi Oct. 26, 2021, 11:10 a.m. UTC | #2 
On Fri, Oct 08, 2021 at 12:53:22AM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1946383
> 
> [Impact]
> When using headset mic to record, the beginning of 2 seconds period is
> not recorded.
> 
> [Fix]
> Skip shutup routines for the codec. The shutup routines somehow
> interferes headset mic recording.
> 
> [Test]
> External headset mic no longer records blank period once the patch is
> applied.
> 
> [Where problems could occur]
> Shutup routines are mainly for outputs like headphone and speakers.
> Since the patch is using a rather generic match for both ALC236 and
> ALC256, many systems might start to observe pop sound from the audio
> outputs.

Already applied to unstable/5.15.

-Andrea