| Message ID | 20211024215718.28969-1-digetx@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v3] dt-bindings: opp: Allow multi-worded OPP entry names | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
On 25-10-21, 00:57, Dmitry Osipenko wrote: > Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP > tables use multi-word names where first part is freq and second voltage > because different hardware versions use different voltages for the same > freqs. Allow OPP entry to have multi-worded name separated by hyphen. > This silences DT checker warnings about wrong naming scheme. > > Reviewed-by: David Heidelberg <david@ixit.cz> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > > Changelog: > > v3: - Viresh Kumar suggested that we shouldn't support postfix variant. > I dropped variant with postfix naming scheme and multi-wording > support of table names. > > v2: - In addition to a multi-wording support, support of the postfix > *-opp-table naming scheme is added to the updated pattern. > > Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > index ae3ae4d39843..f79343960539 100644 > --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > @@ -33,7 +33,7 @@ properties: > type: boolean > > patternProperties: > - '^opp-?[0-9]+$': > + '^opp(-[0-9]+)*$': > type: object > description: > One or more OPP nodes describing voltage-current-frequency combinations. LGTM, will apply once Rob Acks it.
On Mon, Oct 25, 2021 at 12:57:18AM +0300, Dmitry Osipenko wrote: > Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP > tables use multi-word names where first part is freq and second voltage > because different hardware versions use different voltages for the same > freqs. Allow OPP entry to have multi-worded name separated by hyphen. > This silences DT checker warnings about wrong naming scheme. > > Reviewed-by: David Heidelberg <david@ixit.cz> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > > Changelog: > > v3: - Viresh Kumar suggested that we shouldn't support postfix variant. > I dropped variant with postfix naming scheme and multi-wording > support of table names. > > v2: - In addition to a multi-wording support, support of the postfix > *-opp-table naming scheme is added to the updated pattern. > > Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > index ae3ae4d39843..f79343960539 100644 > --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > @@ -33,7 +33,7 @@ properties: > type: boolean > > patternProperties: > - '^opp-?[0-9]+$': > + '^opp(-[0-9]+)*$': This drops support for cases like 'opp1' which there are a ton of. It should be '^opp(-?[0-9]+)*$' if we want to keep that support. I'd love to be stricter, but trying to find a balance. Rob
28.10.2021 00:19, Rob Herring пишет: > On Mon, Oct 25, 2021 at 12:57:18AM +0300, Dmitry Osipenko wrote: >> Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP >> tables use multi-word names where first part is freq and second voltage >> because different hardware versions use different voltages for the same >> freqs. Allow OPP entry to have multi-worded name separated by hyphen. >> This silences DT checker warnings about wrong naming scheme. >> >> Reviewed-by: David Heidelberg <david@ixit.cz> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> >> Changelog: >> >> v3: - Viresh Kumar suggested that we shouldn't support postfix variant. >> I dropped variant with postfix naming scheme and multi-wording >> support of table names. >> >> v2: - In addition to a multi-wording support, support of the postfix >> *-opp-table naming scheme is added to the updated pattern. >> >> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml >> index ae3ae4d39843..f79343960539 100644 >> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml >> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml >> @@ -33,7 +33,7 @@ properties: >> type: boolean >> >> patternProperties: >> - '^opp-?[0-9]+$': >> + '^opp(-[0-9]+)*$': > > This drops support for cases like 'opp1' which there are a ton of. It > should be '^opp(-?[0-9]+)*$' if we want to keep that support. > > I'd love to be stricter, but trying to find a balance. Good catch, let me make v4.
diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml index ae3ae4d39843..f79343960539 100644 --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml @@ -33,7 +33,7 @@ properties: type: boolean patternProperties: - '^opp-?[0-9]+$': + '^opp(-[0-9]+)*$': type: object description: One or more OPP nodes describing voltage-current-frequency combinations.