| Message ID | 20211001000417.15334-1-leoyang.li@nxp.com |
|---|---|
| Headers | show |
| Series | Cleanup of LS1021a device trees | expand |
> -----Original Message----- > From: Li Yang <leoyang.li@nxp.com> > Sent: Friday, October 1, 2021 5:34 AM > To: Shawn Guo <shawnguo@kernel.org>; Rob Herring > <robh+dt@kernel.org>; devicetree@vger.kernel.org; Oleksij Rempel > <linux@rempel-privat.de>; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org > Cc: Leo Li <leoyang.li@nxp.com> > Subject: [EXT] [PATCH v2 16/16] ARM: dts: ls1021a-tsn: use generic > "jedec,spi-nor" compatible for flash > > Caution: EXT Email > > We cannot list all the possible chips used in different board revisions, just > use the generic "jedec,spi-nor" compatible instead. This also fixes > dtbs_check error: > ['s25fl256s1', 's25fl512s', 'jedec,spi-nor'] is too long > > Signed-off-by: Li Yang <leoyang.li@nxp.com> Reviewed-by: Kuldeep Singh <kuldeep.singh@nxp.com> > --- > arch/arm/boot/dts/ls1021a-tsn.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/ls1021a-tsn.dts b/arch/arm/boot/dts/ls1021a- > tsn.dts > index 8005efc5c812..ff0ffb22768b 100644 > --- a/arch/arm/boot/dts/ls1021a-tsn.dts > +++ b/arch/arm/boot/dts/ls1021a-tsn.dts > @@ -251,7 +251,7 @@ &qspi { > > flash@0 { > /* Rev. A uses 64MB flash, Rev. B & C use 32MB flash */ > - compatible = "jedec,spi-nor", "s25fl256s1", "s25fl512s"; > + compatible = "jedec,spi-nor"; > spi-max-frequency = <20000000>; > #address-cells = <1>; > #size-cells = <1>; > -- > 2.25.1
Hi Leo, > -----Original Message----- > From: Li Yang <leoyang.li@nxp.com> > Sent: Friday, October 1, 2021 5:34 AM > To: Shawn Guo <shawnguo@kernel.org>; Rob Herring > <robh+dt@kernel.org>; devicetree@vger.kernel.org; Oleksij Rempel > <linux@rempel-privat.de>; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org > Cc: Leo Li <leoyang.li@nxp.com> > Subject: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI > flash > > Caution: EXT Email > > Add the missing node for qspi flash. > > Signed-off-by: Li Yang <leoyang.li@nxp.com> > --- > arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts > b/arch/arm/boot/dts/ls1021a-qds.dts > index e2aa569ff404..522e1dc51059 100644 > --- a/arch/arm/boot/dts/ls1021a-qds.dts > +++ b/arch/arm/boot/dts/ls1021a-qds.dts > @@ -286,6 +286,21 @@ tbi0: tbi-phy@8 { > }; > }; > > +&qspi { > + num-cs = <2>; Please drop "num-cs" property as it is not used by qspi driver. > + status = "okay"; > + > + qflash0: flash@0 { Can we have flash chip name instead of qflash? There is no hard requirement, it will help in aligning node properties with other board properties such as LX2160A-RDB, LS1046A-RDB etc. With above fixed, Reviewed-by: Kuldeep Singh <kuldeep.singh@nxp.com> > + compatible = "jedec,spi-nor"; > + #address-cells = <1>; > + #size-cells = <1>; > + spi-max-frequency = <20000000>; > + reg = <0>; > + spi-rx-bus-width = <4>; > + spi-tx-bus-width = <4>; > + }; > +}; > + > &sai2 { > status = "okay"; > }; > -- > 2.25.1
On Fri, Oct 1, 2021 at 12:30 AM Kuldeep Singh <kuldeep.singh@nxp.com> wrote: > > Hi Leo, > > > -----Original Message----- > > From: Li Yang <leoyang.li@nxp.com> > > Sent: Friday, October 1, 2021 5:34 AM > > To: Shawn Guo <shawnguo@kernel.org>; Rob Herring > > <robh+dt@kernel.org>; devicetree@vger.kernel.org; Oleksij Rempel > > <linux@rempel-privat.de>; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org > > Cc: Leo Li <leoyang.li@nxp.com> > > Subject: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI > > flash > > > > Caution: EXT Email > > > > Add the missing node for qspi flash. > > > > Signed-off-by: Li Yang <leoyang.li@nxp.com> > > --- > > arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts > > b/arch/arm/boot/dts/ls1021a-qds.dts > > index e2aa569ff404..522e1dc51059 100644 > > --- a/arch/arm/boot/dts/ls1021a-qds.dts > > +++ b/arch/arm/boot/dts/ls1021a-qds.dts > > @@ -286,6 +286,21 @@ tbi0: tbi-phy@8 { > > }; > > }; > > > > +&qspi { > > + num-cs = <2>; > > Please drop "num-cs" property as it is not used by qspi driver. > > > + status = "okay"; > > + > > + qflash0: flash@0 { > > Can we have flash chip name instead of qflash? > There is no hard requirement, it will help in aligning node properties with other board properties such as LX2160A-RDB, LS1046A-RDB etc. Thanks for the review. I find that there is no reference to the label at all. I don't know why we added it in the first place. Probably we can just remove it? > > With above fixed, > Reviewed-by: Kuldeep Singh <kuldeep.singh@nxp.com> > > > + compatible = "jedec,spi-nor"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + spi-max-frequency = <20000000>; > > + reg = <0>; > > + spi-rx-bus-width = <4>; > > + spi-tx-bus-width = <4>; > > + }; > > +}; > > + > > &sai2 { > > status = "okay"; > > }; > > -- > > 2.25.1 >
> -----Original Message----- > From: Li Yang <leoyang.li@nxp.com> > Sent: Saturday, October 2, 2021 1:38 AM > To: Kuldeep Singh <kuldeep.singh@nxp.com> > Cc: Shawn Guo <shawnguo@kernel.org>; Rob Herring <robh+dt@kernel.org>; > devicetree@vger.kernel.org; Oleksij Rempel <linux@rempel-privat.de>; linux- > arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for > QSPI flash > > Caution: EXT Email > > On Fri, Oct 1, 2021 at 12:30 AM Kuldeep Singh <kuldeep.singh@nxp.com> > wrote: > > > > Hi Leo, > > > > > -----Original Message----- > > > From: Li Yang <leoyang.li@nxp.com> > > > Sent: Friday, October 1, 2021 5:34 AM > > > To: Shawn Guo <shawnguo@kernel.org>; Rob Herring > > > <robh+dt@kernel.org>; devicetree@vger.kernel.org; Oleksij Rempel > > > <linux@rempel-privat.de>; linux-arm-kernel@lists.infradead.org; > > > linux- kernel@vger.kernel.org > > > Cc: Leo Li <leoyang.li@nxp.com> > > > Subject: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for > > > QSPI flash > > > > > > Caution: EXT Email > > > > > > Add the missing node for qspi flash. > > > > > > Signed-off-by: Li Yang <leoyang.li@nxp.com> > > > --- > > > arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts > > > b/arch/arm/boot/dts/ls1021a-qds.dts > > > index e2aa569ff404..522e1dc51059 100644 > > > --- a/arch/arm/boot/dts/ls1021a-qds.dts > > > +++ b/arch/arm/boot/dts/ls1021a-qds.dts > > > @@ -286,6 +286,21 @@ tbi0: tbi-phy@8 { > > > }; > > > }; > > > > > > +&qspi { > > > + num-cs = <2>; > > > > Please drop "num-cs" property as it is not used by qspi driver. > > > > > + status = "okay"; > > > + > > > + qflash0: flash@0 { > > > > Can we have flash chip name instead of qflash? > > There is no hard requirement, it will help in aligning node properties with > other board properties such as LX2160A-RDB, LS1046A-RDB etc. > > Thanks for the review. I find that there is no reference to the label at all. I > don't know why we added it in the first place. Probably we can just remove it? I believe yes, though I haven't checked it but I think it's safe to remove label and keep only flash@0. Regards Kuldeep
This is a series of patches trying to cleanup the LS1021a based device trees including: - Add missing nodes - Update to use SPDX tags - Fix existing schema check issues in dts - Update related bindings to deal with some check issues Changes in V2 - Spin-off the IFC binding related patches into a separate series due to its dependency on driver changes - Added two more fixes about thermal-zones node and flash compatible - Remove copyright updates - Updated description in i2c binding patch to clarify the intension - Added Acked-by tag Li Yang (16): dt-bindings: arm: fsl: add ls1021a-tsn board dt-bindings: i2c: imx: update schema to align with original txt binding ARM: dts: ls1021a: change to use SPDX identifiers ARM: dts: ls1021a-qds: Add node for QSPI flash ARM: dts: ls1021a: update pcie nodes for dt-schema check ARM: dts: ls1021a: fix board compatible to follow binding schema ARM: dts: ls1021a: breakup long values in thermal node ARM: dts: ls1021a: disable ifc node by default ARM: dts: ls1021a: remove regulators simple-bus ARM: dts: ls1021a: fix memory node for schema check ARM: dts: ls1021a: add #dma-cells to qdma node ARM: dts: ls1021a: add #power-domain-cells for power-controller node ARM: dts: ls1021a-qds: change fpga to simple-mfd device ARM: dts: ls1021a-tsn: remove undocumented property "position" from mma8452 node ARM: dts: ls1021a: move thermal-zones node out of soc/ ARM: dts: ls1021a-tsn: use generic "jedec,spi-nor" compatible for flash .../devicetree/bindings/arm/fsl.yaml | 1 + .../devicetree/bindings/i2c/i2c-imx.yaml | 12 +- arch/arm/boot/dts/ls1021a-qds.dts | 86 +++----- arch/arm/boot/dts/ls1021a-tsn.dts | 4 +- arch/arm/boot/dts/ls1021a-twr.dts | 63 +----- arch/arm/boot/dts/ls1021a.dtsi | 204 +++++++----------- 6 files changed, 124 insertions(+), 246 deletions(-)