| Message ID | 92fcd53a43dede52fbba52dc50c76042a6ce284c.1633104510.git.naveen.n.rao@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/bpf: Various fixes | expand |
On Fri, Oct 1, 2021 at 2:16 PM Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> wrote: > > From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > > SEEN_STACK is unused on PowerPC. Remove it. Also, have > SEEN_TAILCALL use 0x40000000. > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> Acked-by: Song Liu <songliubraving@fb.com> > --- > arch/powerpc/net/bpf_jit.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/net/bpf_jit.h b/arch/powerpc/net/bpf_jit.h > index 7e9b978b768ed9..89bd744c2bffd4 100644 > --- a/arch/powerpc/net/bpf_jit.h > +++ b/arch/powerpc/net/bpf_jit.h > @@ -125,8 +125,7 @@ > #define COND_LE (CR0_GT | COND_CMP_FALSE) > > #define SEEN_FUNC 0x20000000 /* might call external helpers */ > -#define SEEN_STACK 0x40000000 /* uses BPF stack */ > -#define SEEN_TAILCALL 0x80000000 /* uses tail calls */ > +#define SEEN_TAILCALL 0x40000000 /* uses tail calls */ > > #define SEEN_VREG_MASK 0x1ff80000 /* Volatile registers r3-r12 */ > #define SEEN_NVREG_MASK 0x0003ffff /* Non volatile registers r14-r31 */ > -- > 2.33.0 >
On Fri, Oct 1, 2021 at 11:15 PM Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> wrote: > > From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > > SEEN_STACK is unused on PowerPC. Remove it. Also, have > SEEN_TAILCALL use 0x40000000. > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> Acked-by: Johan Almbladh <johan.almbladh@anyfinetworks.com> Tested-by: Johan Almbladh <johan.almbladh@anyfinetworks.com> > --- > arch/powerpc/net/bpf_jit.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/net/bpf_jit.h b/arch/powerpc/net/bpf_jit.h > index 7e9b978b768ed9..89bd744c2bffd4 100644 > --- a/arch/powerpc/net/bpf_jit.h > +++ b/arch/powerpc/net/bpf_jit.h > @@ -125,8 +125,7 @@ > #define COND_LE (CR0_GT | COND_CMP_FALSE) > > #define SEEN_FUNC 0x20000000 /* might call external helpers */ > -#define SEEN_STACK 0x40000000 /* uses BPF stack */ > -#define SEEN_TAILCALL 0x80000000 /* uses tail calls */ > +#define SEEN_TAILCALL 0x40000000 /* uses tail calls */ > > #define SEEN_VREG_MASK 0x1ff80000 /* Volatile registers r3-r12 */ > #define SEEN_NVREG_MASK 0x0003ffff /* Non volatile registers r14-r31 */ > -- > 2.33.0 >
Le 01/10/2021 à 23:14, Naveen N. Rao a écrit : > From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > > SEEN_STACK is unused on PowerPC. Remove it. Also, have > SEEN_TAILCALL use 0x40000000. Why change SEEN_TAILCALL ? Would it be a problem to leave it as is ? > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> > --- > arch/powerpc/net/bpf_jit.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/net/bpf_jit.h b/arch/powerpc/net/bpf_jit.h > index 7e9b978b768ed9..89bd744c2bffd4 100644 > --- a/arch/powerpc/net/bpf_jit.h > +++ b/arch/powerpc/net/bpf_jit.h > @@ -125,8 +125,7 @@ > #define COND_LE (CR0_GT | COND_CMP_FALSE) > > #define SEEN_FUNC 0x20000000 /* might call external helpers */ > -#define SEEN_STACK 0x40000000 /* uses BPF stack */ > -#define SEEN_TAILCALL 0x80000000 /* uses tail calls */ > +#define SEEN_TAILCALL 0x40000000 /* uses tail calls */ > > #define SEEN_VREG_MASK 0x1ff80000 /* Volatile registers r3-r12 */ > #define SEEN_NVREG_MASK 0x0003ffff /* Non volatile registers r14-r31 */ >
Christophe Leroy wrote: > > > Le 01/10/2021 à 23:14, Naveen N. Rao a écrit : >> From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> >> >> SEEN_STACK is unused on PowerPC. Remove it. Also, have >> SEEN_TAILCALL use 0x40000000. > > Why change SEEN_TAILCALL ? Would it be a problem to leave it as is ? > >> >> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> >> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> I prefer the bit usage to be contiguous. Changing SEEN_TAILCALL isn't a problem either. - Naveen
Le 04/10/2021 à 20:11, Naveen N. Rao a écrit : > Christophe Leroy wrote: >> >> >> Le 01/10/2021 à 23:14, Naveen N. Rao a écrit : >>> From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> >>> >>> SEEN_STACK is unused on PowerPC. Remove it. Also, have >>> SEEN_TAILCALL use 0x40000000. >> >> Why change SEEN_TAILCALL ? Would it be a problem to leave it as is ? >> >>> >>> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> >>> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> > > I prefer the bit usage to be contiguous. Changing SEEN_TAILCALL isn't a > problem either. > Well you are adding SEEN_BIG_PROG in following patch so it would still be contiguous at the end. I don't really mind but I thought it would be less churn to just leave SEEN_TAILCALL as is and re-use 0x40000000 for SEEN_BIG_PROG. Anyway Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Christophe Leroy wrote: > > > Le 04/10/2021 à 20:11, Naveen N. Rao a écrit : >> Christophe Leroy wrote: >>> >>> >>> Le 01/10/2021 à 23:14, Naveen N. Rao a écrit : >>>> From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> >>>> >>>> SEEN_STACK is unused on PowerPC. Remove it. Also, have >>>> SEEN_TAILCALL use 0x40000000. >>> >>> Why change SEEN_TAILCALL ? Would it be a problem to leave it as is ? >>> >>>> >>>> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> >>>> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> >> >> I prefer the bit usage to be contiguous. Changing SEEN_TAILCALL isn't a >> problem either. >> > > Well you are adding SEEN_BIG_PROG in following patch so it would still > be contiguous at the end. > > I don't really mind but I thought it would be less churn to just leave > SEEN_TAILCALL as is and re-use 0x40000000 for SEEN_BIG_PROG. Ah ok. This patch was from a different series and it made more sense to change the bit number there. I have reused the patch here as-is since the change is fairly trivial. - Naveen
diff --git a/arch/powerpc/net/bpf_jit.h b/arch/powerpc/net/bpf_jit.h index 7e9b978b768ed9..89bd744c2bffd4 100644 --- a/arch/powerpc/net/bpf_jit.h +++ b/arch/powerpc/net/bpf_jit.h @@ -125,8 +125,7 @@ #define COND_LE (CR0_GT | COND_CMP_FALSE) #define SEEN_FUNC 0x20000000 /* might call external helpers */ -#define SEEN_STACK 0x40000000 /* uses BPF stack */ -#define SEEN_TAILCALL 0x80000000 /* uses tail calls */ +#define SEEN_TAILCALL 0x40000000 /* uses tail calls */ #define SEEN_VREG_MASK 0x1ff80000 /* Volatile registers r3-r12 */ #define SEEN_NVREG_MASK 0x0003ffff /* Non volatile registers r14-r31 */