| Message ID | 20210909084441.1756-1-rsalvaterra@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Rui Salvaterra |
| Headers | show |
| Series | ramips: switch to kernel 5.10 | expand |
czw., 9 wrz 2021 o 10:49 Rui Salvaterra <rsalvaterra@gmail.com> napisał(a): > > Tested on mt7621 (Redmi AC2100) and running stable for several months. > Hi Rui, Please remember, if this patch will be merged before my PR #4255 [1], all mt7620 JBOOT devices will be broken. The reason is simple: The 5.10 kernel will be > 2MB. My PR will switch all mt7620 JBOOT devices to the OKLI loader. Best Regards, Pawel [1] https://github.com/openwrt/openwrt/pull/4255 > Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> > --- > target/linux/ramips/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/linux/ramips/Makefile b/target/linux/ramips/Makefile > index d3f2d4b8fc..c9fc1aa58a 100644 > --- a/target/linux/ramips/Makefile > +++ b/target/linux/ramips/Makefile > @@ -10,8 +10,7 @@ BOARDNAME:=MediaTek Ralink MIPS > SUBTARGETS:=mt7620 mt7621 mt76x8 rt288x rt305x rt3883 > FEATURES:=squashfs gpio > > -KERNEL_PATCHVER:=5.4 > -KERNEL_TESTING_PATCHVER:=5.10 > +KERNEL_PATCHVER:=5.10 > > define Target/Description > Build firmware images for Ralink RT288x/RT3xxx based boards. > -- > 2.33.0 > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
"Paweł Dembicki" <paweldembicki@gmail.com> schreef op 9 september 2021 13:47:36 CEST: >czw., 9 wrz 2021 o 10:49 Rui Salvaterra <rsalvaterra@gmail.com> napisał(a): >> >> Tested on mt7621 (Redmi AC2100) and running stable for several months. >> > >Hi Rui, > >Please remember, if this patch will be merged before my PR #4255 [1], >all mt7620 JBOOT devices will be broken. > >The reason is simple: The 5.10 kernel will be > 2MB. My PR will switch >all mt7620 JBOOT devices to the OKLI loader. Would something similar need to be done for the mt76x8 subtarget? I just have a single one of these but I reckon they are equally flash-starved... Cheers Stijn > >Best Regards, >Pawel > >[1] https://github.com/openwrt/openwrt/pull/4255 > >> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> >> --- >> target/linux/ramips/Makefile | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/target/linux/ramips/Makefile b/target/linux/ramips/Makefile >> index d3f2d4b8fc..c9fc1aa58a 100644 >> --- a/target/linux/ramips/Makefile >> +++ b/target/linux/ramips/Makefile >> @@ -10,8 +10,7 @@ BOARDNAME:=MediaTek Ralink MIPS >> SUBTARGETS:=mt7620 mt7621 mt76x8 rt288x rt305x rt3883 >> FEATURES:=squashfs gpio >> >> -KERNEL_PATCHVER:=5.4 >> -KERNEL_TESTING_PATCHVER:=5.10 >> +KERNEL_PATCHVER:=5.10 >> >> define Target/Description >> Build firmware images for Ralink RT288x/RT3xxx based boards. >> -- >> 2.33.0 >> >> >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel > >_______________________________________________ >openwrt-devel mailing list >openwrt-devel@lists.openwrt.org >https://lists.openwrt.org/mailman/listinfo/openwrt-devel Hi,
Hi, Op donderdag 9 september 2021 om 9u44 schreef Rui Salvaterra <rsalvaterra@gmail.com>: > Tested on mt7621 (Redmi AC2100) and running stable for several months. > > Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> Tested on: - mt7620: TP-Link Archer C2 AC750 - mt7621: Asus RT-AC57U v1 - mt76x8: TP-Link RE305 v3 Pawel raised a valid point though, and I think my similar question about mt76x8 deserves consideration as well. Tested-by: Stijn Segers <foss@volatilesystems.org> > --- > target/linux/ramips/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/linux/ramips/Makefile > b/target/linux/ramips/Makefile > index d3f2d4b8fc..c9fc1aa58a 100644 > --- a/target/linux/ramips/Makefile > +++ b/target/linux/ramips/Makefile > @@ -10,8 +10,7 @@ BOARDNAME:=MediaTek Ralink MIPS > SUBTARGETS:=mt7620 mt7621 mt76x8 rt288x rt305x rt3883 > FEATURES:=squashfs gpio > > -KERNEL_PATCHVER:=5.4 > -KERNEL_TESTING_PATCHVER:=5.10 > +KERNEL_PATCHVER:=5.10 > > define Target/Description > Build firmware images for Ralink RT288x/RT3xxx based boards. > -- > 2.33.0 > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Hi, > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] > On Behalf Of Stijn Segers > Sent: Donnerstag, 9. September 2021 14:26 > To: openwrt-devel@lists.openwrt.org; Paweł Dembicki > <paweldembicki@gmail.com>; Rui Salvaterra <rsalvaterra@gmail.com> > Cc: OpenWrt Development List <openwrt-devel@lists.openwrt.org>; Adrian > Schmutzler <freifunk@adrianschmutzler.de>; David Bauer <mail@david- > bauer.net> > Subject: Re: [PATCH] ramips: switch to kernel 5.10 > > "Paweł Dembicki" <paweldembicki@gmail.com> schreef op 9 september > 2021 13:47:36 CEST: > >czw., 9 wrz 2021 o 10:49 Rui Salvaterra <rsalvaterra@gmail.com> napisał(a): > >> > >> Tested on mt7621 (Redmi AC2100) and running stable for several months. > >> > > > >Hi Rui, > > > >Please remember, if this patch will be merged before my PR #4255 [1], > >all mt7620 JBOOT devices will be broken. > > > >The reason is simple: The 5.10 kernel will be > 2MB. My PR will switch > >all mt7620 JBOOT devices to the OKLI loader. > > Would something similar need to be done for the mt76x8 subtarget? > > I just have a single one of these but I reckon they are equally flash-starved... But if KERNEL_SIZE/IMAGE_SIZE is set properly there, those would just fail to build, so no harm could be done? Best Adrian > > Cheers > > Stijn > > > > >Best Regards, > >Pawel > > > >[1] https://github.com/openwrt/openwrt/pull/4255 > > > >> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> > >> --- > >> target/linux/ramips/Makefile | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> diff --git a/target/linux/ramips/Makefile > >> b/target/linux/ramips/Makefile index d3f2d4b8fc..c9fc1aa58a 100644 > >> --- a/target/linux/ramips/Makefile > >> +++ b/target/linux/ramips/Makefile > >> @@ -10,8 +10,7 @@ BOARDNAME:=MediaTek Ralink MIPS > >> SUBTARGETS:=mt7620 mt7621 mt76x8 rt288x rt305x rt3883 > >> FEATURES:=squashfs gpio > >> > >> -KERNEL_PATCHVER:=5.4 > >> -KERNEL_TESTING_PATCHVER:=5.10 > >> +KERNEL_PATCHVER:=5.10 > >> > >> define Target/Description > >> Build firmware images for Ralink RT288x/RT3xxx based boards. > >> -- > >> 2.33.0 > >> > >> > >> _______________________________________________ > >> openwrt-devel mailing list > >> openwrt-devel@lists.openwrt.org > >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > > >_______________________________________________ > >openwrt-devel mailing list > >openwrt-devel@lists.openwrt.org > >https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > Hi, > -- > Sent from my smartphone with K-9 Mail. Please excuse my brevity. > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Hi Adrian, Op zondag 26 september 2021 om 23u45 schreef Adrian Schmutzler <mail@adrianschmutzler.de>: > Hi, > >> -----Original Message----- >> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] >> On Behalf Of Stijn Segers >> Sent: Donnerstag, 9. September 2021 14:26 >> To: openwrt-devel@lists.openwrt.org; Paweł Dembicki >> <paweldembicki@gmail.com>; Rui Salvaterra <rsalvaterra@gmail.com> >> Cc: OpenWrt Development List <openwrt-devel@lists.openwrt.org>; >> Adrian >> Schmutzler <freifunk@adrianschmutzler.de>; David Bauer <mail@david- >> bauer.net> >> Subject: Re: [PATCH] ramips: switch to kernel 5.10 >> >> "Paweł Dembicki" <paweldembicki@gmail.com> schreef op 9 september >> 2021 13:47:36 CEST: >> >czw., 9 wrz 2021 o 10:49 Rui Salvaterra <rsalvaterra@gmail.com> >> napisał(a): >> >> >> >> Tested on mt7621 (Redmi AC2100) and running stable for several >> months. >> >> >> > >> >Hi Rui, >> > >> >Please remember, if this patch will be merged before my PR #4255 >> [1], >> >all mt7620 JBOOT devices will be broken. >> > >> >The reason is simple: The 5.10 kernel will be > 2MB. My PR will >> switch >> >all mt7620 JBOOT devices to the OKLI loader. >> >> Would something similar need to be done for the mt76x8 subtarget? >> >> I just have a single one of these but I reckon they are equally >> flash-starved... > > But if KERNEL_SIZE/IMAGE_SIZE is set properly there, those would just > fail to build, so no harm could be done? That is a valid point. I checked master: $ grep "define Device" image/mt7620.mk|wc -l 119 $ grep \ KERNEL_SIZE image/mt7620.mk|wc -l 1 $ grep "define Device" image/mt76x8.mk|wc -l 80 $ grep \ KERNEL_SIZE image/mt76x8.mk|wc -l 0 That's not encouraging I guess :-P. And just having IMAGE_SIZE defined won't prevent the bootloader from choking on an oversized kernel, or am I wrong about that? Cheers Stijn > > Best > > Adrian > >> >> Cheers >> >> Stijn >> >> > >> >Best Regards, >> >Pawel >> > >> >[1] https://github.com/openwrt/openwrt/pull/4255 >> > >> >> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> >> >> --- >> >> target/linux/ramips/Makefile | 3 +-- >> >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> >> >> diff --git a/target/linux/ramips/Makefile >> >> b/target/linux/ramips/Makefile index d3f2d4b8fc..c9fc1aa58a >> 100644 >> >> --- a/target/linux/ramips/Makefile >> >> +++ b/target/linux/ramips/Makefile >> >> @@ -10,8 +10,7 @@ BOARDNAME:=MediaTek Ralink MIPS >> >> SUBTARGETS:=mt7620 mt7621 mt76x8 rt288x rt305x rt3883 >> >> FEATURES:=squashfs gpio >> >> >> >> -KERNEL_PATCHVER:=5.4 >> >> -KERNEL_TESTING_PATCHVER:=5.10 >> >> +KERNEL_PATCHVER:=5.10 >> >> >> >> define Target/Description >> >> Build firmware images for Ralink RT288x/RT3xxx based >> boards. >> >> -- >> >> 2.33.0 >> >> >> >> >> >> _______________________________________________ >> >> openwrt-devel mailing list >> >> openwrt-devel@lists.openwrt.org >> >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel >> > >> >_______________________________________________ >> >openwrt-devel mailing list >> >openwrt-devel@lists.openwrt.org >> >https://lists.openwrt.org/mailman/listinfo/openwrt-devel >> >> Hi, >> -- >> Sent from my smartphone with K-9 Mail. Please excuse my brevity. >> >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
On Thu, Sep 9, 2021 at 5:49 AM Rui Salvaterra <rsalvaterra@gmail.com> wrote: > > Tested on mt7621 (Redmi AC2100) and running stable for several months. > > Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> > --- Tested on rt3883: Asus RT-N56U Tested-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Hi Stijn, > >> >all mt7620 JBOOT devices will be broken. ... > $ grep \ KERNEL_SIZE image/mt7620.mk|wc -l > 1 That one is under "define Device/amit_jboot", searching for that yields: $ git grep "\$(Device/amit_jboot)" | wc -l 8 So all JBOOT devices look covered. Which mt76x8 device(s) is missing a KERNEL_SIZE or fails to boot with 5.10? Ilya
Hi Ilya, Op maandag 27 september 2021 om 19u11 schreef Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>: > Hi Stijn, > >> >> >all mt7620 JBOOT devices will be broken. > ... >> $ grep \ KERNEL_SIZE image/mt7620.mk|wc -l >> 1 > That one is under "define Device/amit_jboot", searching for that > yields: > $ git grep "\$(Device/amit_jboot)" | wc -l > 8 > > So all JBOOT devices look covered. > > Which mt76x8 device(s) is missing a KERNEL_SIZE or fails to boot with > 5.10? The single mt76x8 device I have works, my reasoning was that maybe those needed further checks because most (all?) of them are small flash devices. That worry was triggered by the odd report of people bricking their device by flashing images with too big a kernel. That being said, that even seems to happen to beefy modern hardware like the mvebu platform, so... I may have been overly cautious (and worried). By now it's clear I am not wholly familiar with the finer points, so I'm happy with the answers I got (and what I learned) and I'll leave it at that. Thank you! Stijn > > Ilya > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Hi Adrian, On Wed, Sep 29, 2021 at 1:34 PM Stijn Segers <foss@volatilesystems.org> wrote: > > Hi Ilya, > > Op maandag 27 september 2021 om 19u11 schreef Ilya Lipnitskiy > <ilya.lipnitskiy@gmail.com>: > > Hi Stijn, > > > >> >> >all mt7620 JBOOT devices will be broken. > > ... > >> $ grep \ KERNEL_SIZE image/mt7620.mk|wc -l > >> 1 > > That one is under "define Device/amit_jboot", searching for that > > yields: > > $ git grep "\$(Device/amit_jboot)" | wc -l > > 8 > > > > So all JBOOT devices look covered. > > > > Which mt76x8 device(s) is missing a KERNEL_SIZE or fails to boot with > > 5.10? > > The single mt76x8 device I have works, my reasoning was that maybe > those needed further checks because most (all?) of them are small flash > devices. That worry was triggered by the odd report of people bricking > their device by flashing images with too big a kernel. That being said, > that even seems to happen to beefy modern hardware like the mvebu > platform, so... I may have been overly cautious (and worried). > > By now it's clear I am not wholly familiar with the finer points, so > I'm happy with the answers I got (and what I learned) and I'll leave it > at that. I think this patch can now be merged in. We can fix broken or devices with small flash incrementally, right? > > Thank you! > > Stijn > > > > > Ilya > > Thanks! Ilya
diff --git a/target/linux/ramips/Makefile b/target/linux/ramips/Makefile index d3f2d4b8fc..c9fc1aa58a 100644 --- a/target/linux/ramips/Makefile +++ b/target/linux/ramips/Makefile @@ -10,8 +10,7 @@ BOARDNAME:=MediaTek Ralink MIPS SUBTARGETS:=mt7620 mt7621 mt76x8 rt288x rt305x rt3883 FEATURES:=squashfs gpio -KERNEL_PATCHVER:=5.4 -KERNEL_TESTING_PATCHVER:=5.10 +KERNEL_PATCHVER:=5.10 define Target/Description Build firmware images for Ralink RT288x/RT3xxx based boards.
Tested on mt7621 (Redmi AC2100) and running stable for several months. Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> --- target/linux/ramips/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)