| Message ID | 20210919125536.117743-1-marcel@ziswiler.com |
|---|---|
| Headers | show |
| Series | ARM: prepare and add colibri imx6ull 1gb (emmc) support | expand |
On Sun, 19 Sep 2021 14:55:34 +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Simplify and unify the distinction between modules and carrier boards. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > Acked-by: Rob Herring <robh@kernel.org> > Reviewed-by: Fabio Estevam <festevam@gmail.com> > > --- > > Changes in v3: > - Add Fabio's reviewed-by. Thanks! > - Add Rob's ack. Thanks! > > Changes in v2: > - New patch cleaning-up dt-bindings documentation. > > .../devicetree/bindings/arm/fsl.yaml | 79 ++++++++++--------- > 1 file changed, 41 insertions(+), 38 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/arm/fsl.yaml:475:111: [warning] line too long (113 > 110 characters) (line-length) ./Documentation/devicetree/bindings/arm/fsl.yaml:612:111: [warning] line too long (113 > 110 characters) (line-length) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1529833 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Rob On Mon, 2021-09-20 at 07:28 -0500, Rob Herring wrote: > On Sun, 19 Sep 2021 14:55:34 +0200, Marcel Ziswiler wrote: > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > Simplify and unify the distinction between modules and carrier boards. > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Acked-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Fabio Estevam <festevam@gmail.com> > > > > --- > > > > Changes in v3: > > - Add Fabio's reviewed-by. Thanks! > > - Add Rob's ack. Thanks! > > > > Changes in v2: > > - New patch cleaning-up dt-bindings documentation. > > > > .../devicetree/bindings/arm/fsl.yaml | 79 ++++++++++--------- > > 1 file changed, 41 insertions(+), 38 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/arm/fsl.yaml:475:111: [warning] line too long (113 > 110 characters) > (line-length) > ./Documentation/devicetree/bindings/arm/fsl.yaml:612:111: [warning] line too long (113 > 110 characters) > (line-length) > > dtschema/dtc warnings/errors: > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1529833 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade Strange, I have done all of that but I still can not convince dt_binding_check on my system to show me that same yamllint warnings/errors on that fsl.yaml file. However, it otherwise seems to work as it shows dozens of other issues throughout Documentation/devicetree/bindings but those are not for me to fix, at least not right now (;-p). > Please check and re-submit. Anyway, I already prepared a V4 with this fixed. Just about to send it out. Thanks, and sorry again that I missed this. Cheers Marcel
On Mon, 2021-09-20 at 07:28 -0500, Rob Herring wrote: > On Sun, 19 Sep 2021 14:55:34 +0200, Marcel Ziswiler wrote: > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > Simplify and unify the distinction between modules and carrier boards. > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Acked-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Fabio Estevam <festevam@gmail.com> > > > > --- > > > > Changes in v3: > > - Add Fabio's reviewed-by. Thanks! > > - Add Rob's ack. Thanks! > > > > Changes in v2: > > - New patch cleaning-up dt-bindings documentation. > > > > .../devicetree/bindings/arm/fsl.yaml | 79 ++++++++++--------- > > 1 file changed, 41 insertions(+), 38 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/arm/fsl.yaml:475:111: [warning] line too long (113 > 110 characters) > (line-length) > ./Documentation/devicetree/bindings/arm/fsl.yaml:612:111: [warning] line too long (113 > 110 characters) > (line-length) > > dtschema/dtc warnings/errors: > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1529833 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade After submitting the fixed V4 I went back to my V3 branch and now it suddenly shows it properly. I guess, something got stuck somewhere (;-p). ⬢[zim@toolbox linux-next.git]$ make O=../../Builds/linux-arm-next-imx_v6_v7/ DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml dt_binding_check make[1]: Entering directory '/var/home/zim/Builds/linux-arm-next-imx_v6_v7' LINT Documentation/devicetree/bindings /var/home/zim/Sources/linux-next.git/Documentation/devicetree/bindings/arm/fsl.yaml:475:111: [warning] line too long (113 > 110 characters) (line-length) /var/home/zim/Sources/linux-next.git/Documentation/devicetree/bindings/arm/fsl.yaml:613:111: [warning] line too long (113 > 110 characters) (line-length) /var/home/zim/Sources/linux-next.git/Documentation/devicetree/bindings/arm/fsl.yaml:620:111: [warning] line too long (113 > 110 characters) (line-length) > Please check and re-submit. Anyway, the V4 has this all fixed. Thanks!
On Mon, Sep 20, 2021 at 9:19 AM Marcel Ziswiler <marcel.ziswiler@toradex.com> wrote: > > Hi Rob > > On Mon, 2021-09-20 at 07:28 -0500, Rob Herring wrote: > > On Sun, 19 Sep 2021 14:55:34 +0200, Marcel Ziswiler wrote: > > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > > > Simplify and unify the distinction between modules and carrier boards. > > > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > Acked-by: Rob Herring <robh@kernel.org> > > > Reviewed-by: Fabio Estevam <festevam@gmail.com> > > > > > > --- > > > > > > Changes in v3: > > > - Add Fabio's reviewed-by. Thanks! > > > - Add Rob's ack. Thanks! > > > > > > Changes in v2: > > > - New patch cleaning-up dt-bindings documentation. > > > > > > .../devicetree/bindings/arm/fsl.yaml | 79 ++++++++++--------- > > > 1 file changed, 41 insertions(+), 38 deletions(-) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > ./Documentation/devicetree/bindings/arm/fsl.yaml:475:111: [warning] line too long (113 > 110 characters) > > (line-length) > > ./Documentation/devicetree/bindings/arm/fsl.yaml:612:111: [warning] line too long (113 > 110 characters) > > (line-length) > > > > dtschema/dtc warnings/errors: > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/patch/1529833 > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > Strange, I have done all of that but I still can not convince dt_binding_check on my system to show me that > same yamllint warnings/errors on that fsl.yaml file. However, it otherwise seems to work as it shows dozens of > other issues throughout Documentation/devicetree/bindings but those are not for me to fix, at least not right > now (;-p). You shouldn't be seeing dozens of warnings unless you are on the current linux-next. linux-next shouldn't be the basis for your development as that's not a tree any maintainer applies patches to. Rob
From: Marcel Ziswiler <marcel.ziswiler@toradex.com> Clean-up imx_v6_v7_defconfig and then add support for the new Colibri iMX6ULL 1GB (eMMC) which builds on the success of the existing Colibri iMX6ULL SKUs using raw NAND but replaces this with more RAM (1 GB) and an eMMC (4 GB). Changes in v3: - Add Fabio's reviewed-by. Thanks! - Added fixes tag as pointed out by Stefan and Fabio. Thanks! - Add Rob's ack. Thanks! Changes in v2: - New patch cleaning-up dt-bindings documentation. - Fix indentation. - Use latest agreed upon SPDX-License-Identifier GPL-2.0+ OR MIT. - Drop AG in our copyright statement as recommended by our legal. - New patch documenting dt-bindings. Marcel Ziswiler (8): ARM: imx_v6_v7_defconfig: enable mtd physmap ARM: imx_v6_v7_defconfig: enable fb ARM: imx_v6_v7_defconfig: change snd soc tlv320aic3x to i2c variant ARM: imx_v6_v7_defconfig: rebuild default configuration ARM: imx_v6_v7_defconfig: build imx sdma driver as module ARM: imx_v6_v7_defconfig: enable bpf syscall and cgroup bpf dt-bindings: arm: fsl: clean-up all toradex boards/modules dt-bindings: arm: fsl: add toradex,colibri-imx6ull-emmc Max Krummenacher (1): ARM: dts: colibri-imx6ull-emmc: add device tree .../devicetree/bindings/arm/fsl.yaml | 87 ++++---- arch/arm/boot/dts/Makefile | 1 + .../boot/dts/imx6ull-colibri-emmc-eval-v3.dts | 17 ++ .../dts/imx6ull-colibri-emmc-nonwifi.dtsi | 185 ++++++++++++++++++ arch/arm/boot/dts/imx6ull-colibri.dtsi | 32 ++- arch/arm/configs/imx_v6_v7_defconfig | 46 ++--- 6 files changed, 299 insertions(+), 69 deletions(-) create mode 100644 arch/arm/boot/dts/imx6ull-colibri-emmc-eval-v3.dts create mode 100644 arch/arm/boot/dts/imx6ull-colibri-emmc-nonwifi.dtsi