diff mbox series

[v4,5/9] ARM: imx_v6_v7_defconfig: build imx sdma driver as module

Message ID 20210920144938.314588-6-marcel@ziswiler.com
State New
Headers show
Series ARM: prepare and add colibri imx6ull 1gb (emmc) support | expand

Commit Message

Marcel Ziswiler Sept. 20, 2021, 2:49 p.m. UTC
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Build CONFIG_IMX_SDMA as a module to avoid the following boot issue:

[    5.214751] imx-sdma 20ec000.sdma: Direct firmware load for
 imx/sdma/sdma-imx6q.bin failed with error -2
[    5.215762] imx-sdma 20ec000.sdma: Falling back to sysfs fallback
 for: imx/sdma/sdma-imx6q.bin

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>

---

(no changes since v3)

Changes in v3:
- Add Fabio's reviewed-by. Thanks!

 arch/arm/configs/imx_v6_v7_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Vasut Sept. 20, 2021, 2:52 p.m. UTC | #1
On 9/20/21 4:49 PM, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Build CONFIG_IMX_SDMA as a module to avoid the following boot issue:
> 
> [    5.214751] imx-sdma 20ec000.sdma: Direct firmware load for
>   imx/sdma/sdma-imx6q.bin failed with error -2
> [    5.215762] imx-sdma 20ec000.sdma: Falling back to sysfs fallback
>   for: imx/sdma/sdma-imx6q.bin

Isn't there some ROM-side SDMA firmware baked into the MX6 which is used 
as a fallback if loading newer one from filesystem fails ? I suspect the 
default ROM firmware might be buggy.
Marcel Ziswiler Sept. 20, 2021, 3:55 p.m. UTC | #2
On Mon, 2021-09-20 at 16:52 +0200, Marek Vasut wrote:
> On 9/20/21 4:49 PM, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > Build CONFIG_IMX_SDMA as a module to avoid the following boot issue:
> > 
> > [    5.214751] imx-sdma 20ec000.sdma: Direct firmware load for
> >   imx/sdma/sdma-imx6q.bin failed with error -2
> > [    5.215762] imx-sdma 20ec000.sdma: Falling back to sysfs fallback
> >   for: imx/sdma/sdma-imx6q.bin
> 
> Isn't there some ROM-side SDMA firmware baked into the MX6 which is used 
> as a fallback if loading newer one from filesystem fails ? I suspect the 
> default ROM firmware might be buggy.

I'm not so sure about this. At least it seems to fail if no external firmware can be loaded.
Marek Vasut Sept. 20, 2021, 4:14 p.m. UTC | #3
On 9/20/21 5:55 PM, Marcel Ziswiler wrote:
> On Mon, 2021-09-20 at 16:52 +0200, Marek Vasut wrote:
>> On 9/20/21 4:49 PM, Marcel Ziswiler wrote:
>>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>>
>>> Build CONFIG_IMX_SDMA as a module to avoid the following boot issue:
>>>
>>> [    5.214751] imx-sdma 20ec000.sdma: Direct firmware load for
>>>    imx/sdma/sdma-imx6q.bin failed with error -2
>>> [    5.215762] imx-sdma 20ec000.sdma: Falling back to sysfs fallback
>>>    for: imx/sdma/sdma-imx6q.bin
>>
>> Isn't there some ROM-side SDMA firmware baked into the MX6 which is used
>> as a fallback if loading newer one from filesystem fails ? I suspect the
>> default ROM firmware might be buggy.
> 
> I'm not so sure about this. At least it seems to fail if no external firmware can be loaded.

See e.g. SDMA chapter in MX6SDLRM or similar, it does talk about 4k boot 
ROM, which contains scripts and utilities later referenced by scripts in 
RAM. It might be worth looking into that a bit further, but that seems 
like a separate topic from this patch.
Lucas Stach Sept. 20, 2021, 4:50 p.m. UTC | #4
Am Montag, dem 20.09.2021 um 18:14 +0200 schrieb Marek Vasut:
> On 9/20/21 5:55 PM, Marcel Ziswiler wrote:
> > On Mon, 2021-09-20 at 16:52 +0200, Marek Vasut wrote:
> > > On 9/20/21 4:49 PM, Marcel Ziswiler wrote:
> > > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > > > 
> > > > Build CONFIG_IMX_SDMA as a module to avoid the following boot issue:
> > > > 
> > > > [    5.214751] imx-sdma 20ec000.sdma: Direct firmware load for
> > > >    imx/sdma/sdma-imx6q.bin failed with error -2
> > > > [    5.215762] imx-sdma 20ec000.sdma: Falling back to sysfs fallback
> > > >    for: imx/sdma/sdma-imx6q.bin
> > > 
> > > Isn't there some ROM-side SDMA firmware baked into the MX6 which is used
> > > as a fallback if loading newer one from filesystem fails ? I suspect the
> > > default ROM firmware might be buggy.
> > 
> > I'm not so sure about this. At least it seems to fail if no external firmware can be loaded.
> 
> See e.g. SDMA chapter in MX6SDLRM or similar, it does talk about 4k boot 
> ROM, which contains scripts and utilities later referenced by scripts in 
> RAM. It might be worth looking into that a bit further, but that seems 
> like a separate topic from this patch.
> 
Yep, most of the systems we ship do work with the ROM firmware, which
should be picked when firmware loading fails.

The RAM firmware is useful in some cases like multichannel SAI or now
to work around the SPI DMA issue on i.MX6.

Regards,
Lucas
Shawn Guo Oct. 5, 2021, 3:24 a.m. UTC | #5
On Mon, Sep 20, 2021 at 04:49:34PM +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Build CONFIG_IMX_SDMA as a module to avoid the following boot issue:
> 
> [    5.214751] imx-sdma 20ec000.sdma: Direct firmware load for
>  imx/sdma/sdma-imx6q.bin failed with error -2
> [    5.215762] imx-sdma 20ec000.sdma: Falling back to sysfs fallback
>  for: imx/sdma/sdma-imx6q.bin
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 21803cd2d1ba7..c0008b7faf2ce 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -380,7 +380,7 @@  CONFIG_RTC_DRV_MXC_V2=y
 CONFIG_RTC_DRV_SNVS=y
 CONFIG_DMADEVICES=y
 CONFIG_FSL_EDMA=y
-CONFIG_IMX_SDMA=y
+CONFIG_IMX_SDMA=m
 CONFIG_MXS_DMA=y
 CONFIG_DMATEST=m
 CONFIG_STAGING=y