diff mbox series

[v1,2/7] ARM: imx_v6_v7_defconfig: enable fb

Message ID 20210819140345.357167-3-marcel@ziswiler.com
State New
Headers show
Series ARM: prepare and add colibri imx6ull 1gb (emmc) support | expand

Commit Message

Marcel Ziswiler Aug. 19, 2021, 2:03 p.m. UTC 
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Enable CONFIG_FB which is nowadays required for CONFIG_DRM_PANEL_LVDS,
CONFIG_DRM_PANEL_SIMPLE, CONFIG_DRM_PANEL_SEIKO_43WVF1G,
CONFIG_FB_MODE_HELPERS, CONFIG_BACKLIGHT_PWM, CONFIG_BACKLIGHT_GPIO,
CONFIG_FRAMEBUFFER_CONSOLE, CONFIG_LOGO, CONFIG_FONTS, CONFIG_FONT_8x8
and CONFIG_FONT_8x16.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---

 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam Aug. 26, 2021, 7:03 p.m. UTC | #1 
Hi Marcel,

On Thu, Aug 19, 2021 at 11:04 AM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Enable CONFIG_FB which is nowadays required for CONFIG_DRM_PANEL_LVDS,
> CONFIG_DRM_PANEL_SIMPLE, CONFIG_DRM_PANEL_SEIKO_43WVF1G,
> CONFIG_FB_MODE_HELPERS, CONFIG_BACKLIGHT_PWM, CONFIG_BACKLIGHT_GPIO,
> CONFIG_FRAMEBUFFER_CONSOLE, CONFIG_LOGO, CONFIG_FONTS, CONFIG_FONT_8x8
> and CONFIG_FONT_8x16.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Yes, I noticed that I had no LCD output on an imx6ull-evk board and
after selecting CONFIG_FB it works again.

For the entire series:

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Stefan Wahren Aug. 27, 2021, 3:33 p.m. UTC | #2 
Hi,

Am 26.08.21 um 21:03 schrieb Fabio Estevam:
> Hi Marcel,
>
> On Thu, Aug 19, 2021 at 11:04 AM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>
>> Enable CONFIG_FB which is nowadays required for CONFIG_DRM_PANEL_LVDS,
>> CONFIG_DRM_PANEL_SIMPLE, CONFIG_DRM_PANEL_SEIKO_43WVF1G,
>> CONFIG_FB_MODE_HELPERS, CONFIG_BACKLIGHT_PWM, CONFIG_BACKLIGHT_GPIO,
>> CONFIG_FRAMEBUFFER_CONSOLE, CONFIG_LOGO, CONFIG_FONTS, CONFIG_FONT_8x8
>> and CONFIG_FONT_8x16.
>>
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Yes, I noticed that I had no LCD output on an imx6ull-evk board and
> after selecting CONFIG_FB it works again.

this was caused by:

f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB")

Best regards

>
> For the entire series:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fabio Estevam Sept. 13, 2021, 9:57 p.m. UTC | #3 
On Fri, Aug 27, 2021 at 12:33 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> Hi,
>
> Am 26.08.21 um 21:03 schrieb Fabio Estevam:
> > Hi Marcel,
> >
> > On Thu, Aug 19, 2021 at 11:04 AM Marcel Ziswiler <marcel@ziswiler.com> wrote:
> >> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >>
> >> Enable CONFIG_FB which is nowadays required for CONFIG_DRM_PANEL_LVDS,
> >> CONFIG_DRM_PANEL_SIMPLE, CONFIG_DRM_PANEL_SEIKO_43WVF1G,
> >> CONFIG_FB_MODE_HELPERS, CONFIG_BACKLIGHT_PWM, CONFIG_BACKLIGHT_GPIO,
> >> CONFIG_FRAMEBUFFER_CONSOLE, CONFIG_LOGO, CONFIG_FONTS, CONFIG_FONT_8x8
> >> and CONFIG_FONT_8x16.
> >>
> >> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > Yes, I noticed that I had no LCD output on an imx6ull-evk board and
> > after selecting CONFIG_FB it works again.
>
> this was caused by:
>
> f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB")

Thanks, Stefan.

Marcel, I think you could resend this one with the Fixes tag and
hopefully it could be applied as a fix for 5.14-rc.

We can consider it as a regression fix, because it restores display
support on many i.MX boards on 5.14-rc.

Thanks
diff mbox series

Patch

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 70b3c377c4302..6618a009a105e 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -293,6 +293,7 @@  CONFIG_DRM_IMX_LDB=y
 CONFIG_DRM_IMX_HDMI=y
 CONFIG_DRM_ETNAVIV=y
 CONFIG_DRM_MXSFB=y
+CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_LCD_CLASS_DEVICE=y
 CONFIG_LCD_L4F00242T03=y