diff mbox series

[SRU,OEM-5.13] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 650 G8 Notebook PC

Message ID 20210816135916.48575-1-jeremy.szu@canonical.com
State New
Headers show
Series [SRU,OEM-5.13] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 650 G8 Notebook PC | expand

Commit Message

Jeremy Szu Aug. 16, 2021, 1:59 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1939473

The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is
using 0x02 to control mute LED and 0x01 to control micmute LED.
Therefore, add a quirk to make it works.

Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210810100846.65844-1-jeremy.szu@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit d07149aba2ef423eae94a9cc2a6365d0cdf6fd51)
Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Timo Aaltonen Aug. 17, 2021, 12:25 p.m. UTC | #1
On 16.8.2021 16.59, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1939473
> 
> The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is
> using 0x02 to control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
> 
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
> Cc: <stable@vger.kernel.org>
> Link: https://lore.kernel.org/r/20210810100846.65844-1-jeremy.szu@canonical.com
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit d07149aba2ef423eae94a9cc2a6365d0cdf6fd51)
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
> ---
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 58e185c6e77f..52b93f15e790 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -8342,6 +8342,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   	SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
> +	SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
> 

applied to oem-5.13, thanks
Stefan Bader Aug. 31, 2021, 1:37 p.m. UTC | #2
On 16.08.21 15:59, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1939473
> 
> The HP ProBook 650 G8 Notebook PC is using ALC236 codec which is
> using 0x02 to control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
> 
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
> Cc: <stable@vger.kernel.org>
> Link: https://lore.kernel.org/r/20210810100846.65844-1-jeremy.szu@canonical.com
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit d07149aba2ef423eae94a9cc2a6365d0cdf6fd51)
> Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com>
> ---
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 58e185c6e77f..52b93f15e790 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -8342,6 +8342,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   	SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
> +	SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
> 
This is yet another lingering submission of the same patch which was not 
self-NACKed!
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 58e185c6e77f..52b93f15e790 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8342,6 +8342,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
+	SND_PCI_QUIRK(0x103c, 0x8805, "HP ProBook 650 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),