| Message ID | 20210816074619.177383-1-wangkefeng.wang@huawei.com |
|---|---|
| Headers | show |
| Series | amba: Properly handle device probe without IRQ domain | expand |
On Mon, Aug 16, 2021 at 03:46:16PM +0800, Kefeng Wang wrote: > Patch 1 and 2 make some cleanup, and patch 3 use of_irq_get() instead of > irq_of_parse_and_map() to get irq number, return -EPROBE_DEFER if the irq > domain is not yet created, amba_device_add() will properly to handle the > no IRQ domain issue via deferred probe. > > Kefeng Wang (3): > amba: Drop unused functions about APB/AHB devices add > Revert "ARM: amba: make use of -1 IRQs warn" > amba: Properly handle device probe without IRQ domain > > drivers/amba/bus.c | 100 ++++++++++----------------------------- > drivers/of/platform.c | 6 +-- > include/linux/amba/bus.h | 18 ------- > 3 files changed, 27 insertions(+), 97 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org>
On 2021/8/18 6:27, Rob Herring wrote: > On Mon, Aug 16, 2021 at 03:46:16PM +0800, Kefeng Wang wrote: >> Patch 1 and 2 make some cleanup, and patch 3 use of_irq_get() instead of >> irq_of_parse_and_map() to get irq number, return -EPROBE_DEFER if the irq >> domain is not yet created, amba_device_add() will properly to handle the >> no IRQ domain issue via deferred probe. >> >> Kefeng Wang (3): >> amba: Drop unused functions about APB/AHB devices add >> Revert "ARM: amba: make use of -1 IRQs warn" >> amba: Properly handle device probe without IRQ domain >> >> drivers/amba/bus.c | 100 ++++++++++----------------------------- >> drivers/of/platform.c | 6 +-- >> include/linux/amba/bus.h | 18 ------- >> 3 files changed, 27 insertions(+), 97 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org> Thanks Rob. Hi Russell, should I send the patches to the ARM patch system? > . >
On Mon, Aug 23, 2021 at 10:19:23AM +0800, Kefeng Wang wrote: > > On 2021/8/18 6:27, Rob Herring wrote: > > On Mon, Aug 16, 2021 at 03:46:16PM +0800, Kefeng Wang wrote: > > > Patch 1 and 2 make some cleanup, and patch 3 use of_irq_get() instead of > > > irq_of_parse_and_map() to get irq number, return -EPROBE_DEFER if the irq > > > domain is not yet created, amba_device_add() will properly to handle the > > > no IRQ domain issue via deferred probe. > > > > > > Kefeng Wang (3): > > > amba: Drop unused functions about APB/AHB devices add > > > Revert "ARM: amba: make use of -1 IRQs warn" > > > amba: Properly handle device probe without IRQ domain > > > > > > drivers/amba/bus.c | 100 ++++++++++----------------------------- > > > drivers/of/platform.c | 6 +-- > > > include/linux/amba/bus.h | 18 ------- > > > 3 files changed, 27 insertions(+), 97 deletions(-) > > Reviewed-by: Rob Herring <robh@kernel.org> > > Thanks Rob. > > Hi Russell, should I send the patches to the ARM patch system? Yes please - I'll try to squeeze it in for this cycle but it's getting a tad late for that. Thanks.
On 2021/8/23 17:05, Russell King (Oracle) wrote: > On Mon, Aug 23, 2021 at 10:19:23AM +0800, Kefeng Wang wrote: >> On 2021/8/18 6:27, Rob Herring wrote: >>> On Mon, Aug 16, 2021 at 03:46:16PM +0800, Kefeng Wang wrote: >>>> Patch 1 and 2 make some cleanup, and patch 3 use of_irq_get() instead of >>>> irq_of_parse_and_map() to get irq number, return -EPROBE_DEFER if the irq >>>> domain is not yet created, amba_device_add() will properly to handle the >>>> no IRQ domain issue via deferred probe. >>>> >>>> Kefeng Wang (3): >>>> amba: Drop unused functions about APB/AHB devices add >>>> Revert "ARM: amba: make use of -1 IRQs warn" >>>> amba: Properly handle device probe without IRQ domain >>>> >>>> drivers/amba/bus.c | 100 ++++++++++----------------------------- >>>> drivers/of/platform.c | 6 +-- >>>> include/linux/amba/bus.h | 18 ------- >>>> 3 files changed, 27 insertions(+), 97 deletions(-) >>> Reviewed-by: Rob Herring <robh@kernel.org> >> Thanks Rob. >> >> Hi Russell, should I send the patches to the ARM patch system? > Yes please - I'll try to squeeze it in for this cycle but it's getting > a tad late for that. Thanks. Done, but the sequence of patches is reordered at ARM patch system, (using git send-email and deliver patch1/2/3 in order). BTW, could you give me some direction the following patchset[1] too if you have time, I have addressed your comments and resend, but there's been no new feedback for a long time. If it is too late for this cycle, I could resend them after 5.15-rc1. Many thanks. [1] https://lore.kernel.org/linux-arm-kernel/20210610123556.171328-1-wangkefeng.wang@huawei.com/ >